Johnny Lin has uploaded a new patch set (#10) to the change originally created by Jingle Hsu. ( https://review.coreboot.org/c/coreboot/+/43005 )
Change subject: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear on RTC failure
......................................................................
mb/ocp/deltalake: Send OEM IPMI command for CMOS clear on RTC failure
When RTC failure is detected, send IPMI OEM command to issue CMOS clear.
This is to let the payload (LinuxBoot) handle the IPMI OEM CMOS
clear command by resetting RTC data, erasing VPD_RW (TODO) and add a SEL, then
reboot the system.
Tested=on OCP Delta Lake, after removing RTC battery we can see the above
flow can be executed correctly.
Signed-off-by: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Change-Id: I27428c02e99040754e15e07782ec1ad8524def2f
---
M src/mainboard/ocp/deltalake/ipmi.c
M src/mainboard/ocp/deltalake/ipmi.h
M src/mainboard/ocp/deltalake/romstage.c
3 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/43005/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/43005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27428c02e99040754e15e07782ec1ad8524def2f
Gerrit-Change-Number: 43005
Gerrit-PatchSet: 10
Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43267 )
Change subject: drivers/i2c/adt7463: Drop dead code
......................................................................
drivers/i2c/adt7463: Drop dead code
Nothing selects this driver. Drop it before it grows moss.
Change-Id: I9311dd07b8259384badec65da649fa0cf2da1e01
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
D src/drivers/i2c/adt7463/Kconfig
D src/drivers/i2c/adt7463/Makefile.inc
D src/drivers/i2c/adt7463/adt7463.c
3 files changed, 0 insertions(+), 85 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43267/1
diff --git a/src/drivers/i2c/adt7463/Kconfig b/src/drivers/i2c/adt7463/Kconfig
deleted file mode 100644
index b942341..0000000
--- a/src/drivers/i2c/adt7463/Kconfig
+++ /dev/null
@@ -1,2 +0,0 @@
-config DRIVERS_I2C_ADT7463
- bool
diff --git a/src/drivers/i2c/adt7463/Makefile.inc b/src/drivers/i2c/adt7463/Makefile.inc
deleted file mode 100644
index d75981b..0000000
--- a/src/drivers/i2c/adt7463/Makefile.inc
+++ /dev/null
@@ -1 +0,0 @@
-ramstage-$(CONFIG_DRIVERS_I2C_ADT7463) += adt7463.c
diff --git a/src/drivers/i2c/adt7463/adt7463.c b/src/drivers/i2c/adt7463/adt7463.c
deleted file mode 100644
index 475ea9a..0000000
--- a/src/drivers/i2c/adt7463/adt7463.c
+++ /dev/null
@@ -1,82 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <device/device.h>
-#include <console/console.h>
-#include <device/smbus.h>
-
-/**
- * Do some S2881-specific HWM initialization for the ADT7463 chip.
- *
- * Should be factored out so that it can be more general.
- *
- * See Analog Devices ADT7463 datasheet, Rev C (2004):
- * http://www.analog.com/en/prod/0,,766_825_ADT7463,00.html
- */
-static void adt7463_init(struct device *adt7463)
-{
- int result;
-
- printk(BIOS_DEBUG, "ADT7463 is %s\n", dev_path(adt7463));
-
- /* Set all fans to 'Fastest Speed Calculated by All 3 Temperature
- * Channels Controls PWMx'.
- */
- result = smbus_write_byte(adt7463, 0x5c, 0xc2);
- result = smbus_write_byte(adt7463, 0x5d, 0xc2);
- result = smbus_write_byte(adt7463, 0x5e, 0xc2);
-
- /* Make sure that our fans never stop when temp. falls below Tmin,
- * but rather keep going at minimum duty cycle (applies to automatic
- * fan control mode only).
- */
- result = smbus_write_byte(adt7463, 0x62, 0xc0);
-
- /* Set minimum PWM duty cycle to 25%, rather than the default 50%. */
- result = smbus_write_byte(adt7463, 0x64, 0x40);
- result = smbus_write_byte(adt7463, 0x65, 0x40);
- result = smbus_write_byte(adt7463, 0x66, 0x40);
-
- /* Set Tmin to 55C, rather than the default 90C. Above this temperature
- * the fans will start blowing harder as temperature increases
- * (automatic mode only).
- */
- result = smbus_write_byte(adt7463, 0x67, 0x37);
- result = smbus_write_byte(adt7463, 0x68, 0x37);
- result = smbus_write_byte(adt7463, 0x69, 0x37);
-
- /* Set THERM limit to 70C, rather than the default 100C.
- * The fans will kick in at 100% if the sensors reach this temperature,
- * (only in automatic mode, but supposedly even when hardware is
- * locked up). This is a failsafe measure.
- */
- result = smbus_write_byte(adt7463, 0x6a, 0x46);
- result = smbus_write_byte(adt7463, 0x6b, 0x46);
- result = smbus_write_byte(adt7463, 0x6c, 0x46);
-
- /* Remote temperature 1 offset (LSB == 0.25C). */
- result = smbus_write_byte(adt7463, 0x70, 0x02);
-
- /* Remote temperature 2 offset (LSB == 0.25C). */
- result = smbus_write_byte(adt7463, 0x72, 0x01);
-
- /* Set TACH measurements to normal (1/second). */
- result = smbus_write_byte(adt7463, 0x78, 0xf0);
-
- printk(BIOS_DEBUG, "ADT7463 properly initialized\n");
-}
-
-static struct device_operations adt7463_operations = {
- .read_resources = noop_read_resources,
- .set_resources = noop_set_resources,
- .init = adt7463_init,
-};
-
-static void enable_dev(struct device *dev)
-{
- dev->ops = &adt7463_operations;
-}
-
-struct chip_operations drivers_i2c_adt7463_ops = {
- CHIP_NAME("adt7463")
- .enable_dev = enable_dev,
-};
--
To view, visit https://review.coreboot.org/c/coreboot/+/43267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9311dd07b8259384badec65da649fa0cf2da1e01
Gerrit-Change-Number: 43267
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange