coreboot-gerrit June 2020

coreboot-gerrit@coreboot.org

1 participants
2826 discussions

Change in coreboot[master]: soc/amd/picasso: add psp_verstage
by Martin Roth (Code Review) 23 Jun '20

23 Jun '20

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41816 ) Change subject: soc/amd/picasso: add psp_verstage ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/c/coreboot/+/41816/7/src/soc/amd/picasso/psp_ve… File src/soc/amd/picasso/psp_verstage/Makefile.inc: https://review.coreboot.org/c/coreboot/+/41816/7/src/soc/amd/picasso/psp_ve… PS7, Line 5: CPPFLAGS_verstage += -I$(src)/soc/amd/picasso/psp_verstage/include > Why are you replacing arch/mmio. […] I'll see what I can do. -- To view, visit https://review.coreboot.org/c/coreboot/+/41816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia58839caa5bfbae0408702ee8d02ef482f2861c4 Gerrit-Change-Number: 41816 Gerrit-PatchSet: 7 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 23 Jun 2020 15:07:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Drop stale code paths
by 9elements QA (Code Review) 23 Jun '20

23 Jun '20

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42618 ) Change subject: sb/intel/lynxpoint: Drop stale code paths ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 3/1/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/6715 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/6714 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/6713 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : FAIL : https://lava.9esec.io/r/6712 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/42618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I689bee55943b29990f54cb798b999940eae180bc Gerrit-Change-Number: 42618 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Tue, 23 Jun 2020 14:04:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/pcengines/apu2: Update GPIO Reads & writes"
by Michał Żygowski (Code Review) 23 Jun '20

23 Jun '20

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42684 ) Change subject: Revert "mb/pcengines/apu2: Update GPIO Reads & writes" ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > I thought Picasso team has already decided about the AMD GPIO abstraction layer. I didn't want to block their work and merged the change being reverted here. I will look into this patch series so we can get a more elegant implementation > > I mostly need the revert here for build purposes and ease of review on CB:42521. I have that next on my queue, no action expected from you until it is ready for testing. > > Designs can be replaced and decisions overruled when/if better approaches arise. The Picasso approach at least currently leaks x86 memory space #defines to psp-verstage and this makes it somewhat errorprone, there is some undesirable forking of sources too. I got some green light from Aaron and Raul to investigate another approach, which this topic:amd-acpimmio-alt will present. Thank you for clarification. Let me know if you would need help/reviews. -- To view, visit https://review.coreboot.org/c/coreboot/+/42684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacd80d1ca24c9d187ff2c8e68e57a609213bad08 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 23 Jun 2020 13:40:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/pcengines/apu2: Update GPIO Reads & writes"
by Kyösti Mälkki (Code Review) 23 Jun '20

23 Jun '20

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42684 ) Change subject: Revert "mb/pcengines/apu2: Update GPIO Reads & writes" ...................................................................... Patch Set 1: > Patch Set 1: > > I thought Picasso team has already decided about the AMD GPIO abstraction layer. I didn't want to block their work and merged the change being reverted here. I will look into this patch series so we can get a more elegant implementation I mostly need the revert here for build purposes and ease of review on CB:42521. I have that next on my queue, no action expected from you until it is ready for testing. Designs can be replaced and decisions overruled when/if better approaches arise. The Picasso approach at least currently leaks x86 memory space #defines to psp-verstage and this makes it somewhat errorprone, there is some undesirable forking of sources too. I got some green light from Aaron and Raul to investigate another approach, which this topic:amd-acpimmio-alt will present. -- To view, visit https://review.coreboot.org/c/coreboot/+/42684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacd80d1ca24c9d187ff2c8e68e57a609213bad08 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 23 Jun 2020 12:42:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add xhci0_force_gen1 parameter to AGESA FSP-S UPD
by chris wang (Code Review) 23 Jun '20

23 Jun '20

Hello Chris Wang, Eric Peers, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/42215 to review the following change. Change subject: Add xhci0_force_gen1 parameter to AGESA FSP-S UPD ...................................................................... Add xhci0_force_gen1 parameter to AGESA FSP-S UPD add xhci0_force_gen1 parameter for force xhci0 to gen1 BUG=b:156314787 BRANCH=trembyle-bringup TEST=Build, verified the device speed been forced to gen 1 on Trembyle. Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Iae601ae595827d7edfb99445f896f59fb136d88b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… Reviewed-by: Eric Peers <epeers(a)google.com> Commit-Queue: Eric Peers <epeers(a)google.com> Tested-by: Eric Peers <epeers(a)google.com> --- M src/vendorcode/amd/fsp/picasso/FspsUpd.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42215/1 diff --git a/src/vendorcode/amd/fsp/picasso/FspsUpd.h b/src/vendorcode/amd/fsp/picasso/FspsUpd.h index 66ea60b..afc06e1 100644 --- a/src/vendorcode/amd/fsp/picasso/FspsUpd.h +++ b/src/vendorcode/amd/fsp/picasso/FspsUpd.h @@ -44,7 +44,8 @@ /** Offset 0x00EC**/ uint8_t fch_usb_early_debug_select_enable; /** Offset 0x00ED**/ uint8_t unused8; /** Offset 0x00EE**/ uint32_t xhci_oc_pin_select; - /** Offset 0x00F2**/ uint8_t UnusedUpdSpace0[46]; + /** Offset 0x00F2**/ uint8_t xhci0_force_gen1; + /** Offset 0x00F3**/ uint8_t UnusedUpdSpace0[45]; /** Offset 0x0120**/ uint16_t UpdTerminator; } FSP_S_CONFIG; -- To view, visit https://review.coreboot.org/c/coreboot/+/42215 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae601ae595827d7edfb99445f896f59fb136d88b Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-MessageType: newchange

4 9

Change in coreboot[master]: [TEST] for debug FSP
by Maulik V Vaghela (Code Review) 23 Jun '20

23 Jun '20

Maulik V Vaghela has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42418 ) Change subject: [TEST] for debug FSP ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/42418 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87ca6bb3648291d20f24aa3d7b859a7d16ec2130 Gerrit-Change-Number: 42418 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: Revert "mb/pcengines/apu2: Update GPIO Reads & writes"
by Michał Żygowski (Code Review) 23 Jun '20

23 Jun '20

1 0

Change in coreboot[master]: acpi: Add support for calling method with parameter
by Sugnan Prabhu S (Code Review) 23 Jun '20

23 Jun '20

Sugnan Prabhu S has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41620 ) Change subject: acpi: Add support for calling method with parameter ...................................................................... Abandoned Not being used by SSDT patches anymore. -- To view, visit https://review.coreboot.org/c/coreboot/+/41620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcb67bd756dc8ae1dfd2d40020c273325583df0f Gerrit-Change-Number: 41620 Gerrit-PatchSet: 15 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: amd/pi/hudson: Add GPIO get function
by Kyösti Mälkki (Code Review) 23 Jun '20

23 Jun '20

Kyösti Mälkki has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/19159 ) Change subject: amd/pi/hudson: Add GPIO get function ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/19159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f681865715ab947b525320a6f9fc63af1334b59 Gerrit-Change-Number: 19159 Gerrit-PatchSet: 13 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT
by Sugnan Prabhu S (Code Review) 23 Jun '20

23 Jun '20

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 ) Change subject: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT ...................................................................... Patch Set 13: (4 comments) https://review.coreboot.org/c/coreboot/+/41758/1/src/drivers/intel/mipi_cam… File src/drivers/intel/mipi_camera/Kconfig: https://review.coreboot.org/c/coreboot/+/41758/1/src/drivers/intel/mipi_cam… PS1, Line 4: y > In my past experience I didn't have to make this change. […] Done https://review.coreboot.org/c/coreboot/+/41758/8/src/drivers/intel/mipi_cam… File src/drivers/intel/mipi_camera/Kconfig: https://review.coreboot.org/c/coreboot/+/41758/8/src/drivers/intel/mipi_cam… PS8, Line 4: default y > Why? This will add MIPI_CAMERA driver to every board. […] Reverted and added to jasperlake_rvp/Kconfig https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasper… File src/mainboard/intel/jasperlake_rvp/dsdt.asl: https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasper… PS1, Line 50: variant/acpi/camera.asl > Should this and the related files be deleted? Done https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasper… File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb: https://review.coreboot.org/c/coreboot/+/41758/1/src/mainboard/intel/jasper… PS1, Line 439: chip drivers/intel/mipi_camera : register "acpi_uid" = "327680" : register "acpi_name" = ""IPU0"" : register "chip_name" = ""Camera and Imaging Subsystem"" : register "device_type" = "INTEL_ACPI_CAMERA_CIO2" : : register "cio2_num_ports" = "2" : register "cio2_lanes_used[0]" = "2" : register "cio2_lanes_used[1]" = "2" : register "cio2_lane_endpoint[0]" = ""^I2C4.CAM0"" : register "cio2_lane_endpoint[1]" = ""^I2C5.CAM0"" : : device pci 05.0 on end # RP4 : end > Normally there'd be a separate CIO device. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/41758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib439572bc1d15ef02c86c7bfa88af6b16eb06f97 Gerrit-Change-Number: 41758 Gerrit-PatchSet: 13 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com> Gerrit-CC: Matt Delco <delco(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 23 Jun 2020 11:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt Delco <delco(a)chromium.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2020