Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30747
Change subject: cpu/amd/microcode: Search all containers
......................................................................
cpu/amd/microcode: Search all containers
Currently, it’s aborted if the first file is not found.
The commit was only tested with all microcode containers present in
CBFS.
If only one microcode update container is present, which is not the
first, it is skipped.
Change the return to continue to traverse all elements.
Fixes: 83e4c5613 (cpu/amd/microcode: Update parser to use stock microcode blobs)
Change-Id: I5195ff0334cf49cadc25de31822a9f2f2cd90490
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M src/cpu/amd/microcode/microcode.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/30747/1
diff --git a/src/cpu/amd/microcode/microcode.c b/src/cpu/amd/microcode/microcode.c
index e8ab175..622c6db 100644
--- a/src/cpu/amd/microcode/microcode.c
+++ b/src/cpu/amd/microcode/microcode.c
@@ -214,7 +214,7 @@
spin_unlock(romstage_microcode_cbfs_lock());
#endif
#endif
- return;
+ continue;
}
amd_update_microcode(ucode, ucode_len, equivalent_processor_rev_id);
--
To view, visit https://review.coreboot.org/c/coreboot/+/30747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5195ff0334cf49cadc25de31822a9f2f2cd90490
Gerrit-Change-Number: 30747
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange
Christoph Pomaska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35911 )
Change subject: [WIP] Documentation/basics: Add glossary
......................................................................
[WIP] Documentation/basics: Add glossary
The glossary is to contain common abbreviations and specific vocabulary.
Change-Id: I2ef9130f9cfecacdc0033deba3cde582fb991f54
Signed-off-by: Christoph Pomaska <c.pomaska(a)hosting.de>
---
A Documentation/basics/glossary.md
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/35911/1
diff --git a/Documentation/basics/glossary.md b/Documentation/basics/glossary.md
new file mode 100644
index 0000000..f820bf1
--- /dev/null
+++ b/Documentation/basics/glossary.md
@@ -0,0 +1,27 @@
+# Glossary
+
+## Intro
+This page explains the most common abbreviations and terms. It also contains additional reference for some more detailed info.
+
+## Intel-specific
+
+- IFD: Intel Flash Descriptor\
+ The Intel Flash Descriptor is used on Intel platforms to split the contents of a flash chip into multiple parts (regions).
+ Most boards contain the following regions:
+ * ifd
+ * me
+ * gbe
+ * bios
+ * platform data
+- ME: Intel Management Engine
+ The Intel Management Engine is a co-processor that runs proprietary code which resides next to the bios-firmware within the "me" flash-region.
+ On older platforms it is possible to disable the ME by removing the code from the flash-chip. Since Sandybridge it is only possible to disable the ME by removing most parts of it and making it crash on startup, disabling a watchdog that shuts off the whole system 30 minutes after startup. Since Skylake it not possible to remove anything from the ME without breaking it.
+- GbE: Gigabit Ethernet
+ This regions contains a firmware blob for Intel Gigabit Ethernet hardware. It is usually not used for mainboards that dont have Intel Gigabit ethernet onboard.
+- BIOS: Basic Input Output System
+ The BIOS region contains the firmware that is required to boot up and initialize the system/mainboard. This is the region where coreboot is usually written to.
+
+## coreboot-specific
+- CBFS: coreboot file system
+ The coreboot filesystem contains the files that are require for coreboot to work, such as the bootblock, payloads and romstage/ramstage binaries.
+
--
To view, visit https://review.coreboot.org/c/coreboot/+/35911
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ef9130f9cfecacdc0033deba3cde582fb991f54
Gerrit-Change-Number: 35911
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-MessageType: newchange
Christoph Pomaska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35910 )
Change subject: Documentation: Add basics section
......................................................................
Documentation: Add basics section
As discussed on the coreboot mailing list, I decided to create a section
called "basics" for basic hard- and software information and
documentation.
Change-Id: Ia7d3b4c6ee203708d4058c4e52550e1ed24c64d1
Signed-off-by: Christoph Pomaska <c.pomaska(a)hosting.de>
---
A Documentation/basics/index.md
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/35910/1
diff --git a/Documentation/basics/index.md b/Documentation/basics/index.md
new file mode 100644
index 0000000..a3ebff7
--- /dev/null
+++ b/Documentation/basics/index.md
@@ -0,0 +1,8 @@
+# basic and general information about hardware
+
+This section contains basic information and documentation about hardware
+that a coreboot dev has to deal with.
+
+## x86
+* [Super I/O](superio.md)
+
--
To view, visit https://review.coreboot.org/c/coreboot/+/35910
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7d3b4c6ee203708d4058c4e52550e1ed24c64d1
Gerrit-Change-Number: 35910
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-MessageType: newchange
Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39455 )
Change subject: Documentation/contributing/project_ideas.md: add resource allocation project
......................................................................
Documentation/contributing/project_ideas.md: add resource allocation project
Change-Id: I278ee622be2ab4a3d26bd5a180e7471236a828b8
---
M Documentation/contributing/project_ideas.md
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/39455/1
diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md
index 2c621f4..4198501 100644
--- a/Documentation/contributing/project_ideas.md
+++ b/Documentation/contributing/project_ideas.md
@@ -184,3 +184,15 @@
### Mentors
* TODO
+
+## Implement 64-bit resource allocation
+Currently the coreboot allocator is limited to 32-bit allocation, which can be
+problematic for systems with a large number of memory-mapped devices, or
+devices with large memory regions, or hot-pluggable buses.
+
+### Requirements
+* Understand the basics of PCI resource allocation, and be willing to learn
+ more about coreboot's resource allocation.
+
+### Mentors
+* Jeremy Soller <jeremy(a)system76.com>
--
To view, visit https://review.coreboot.org/c/coreboot/+/39455
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278ee622be2ab4a3d26bd5a180e7471236a828b8
Gerrit-Change-Number: 39455
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newchange
Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38832 )
Change subject: Documentation/ifdtool: modify IFD regions
......................................................................
Documentation/ifdtool: modify IFD regions
Add documentation about using ifdtool to modify the region rangers,
with examples.
Change-Id: I862bd851fc68365ca11aa0477ae4e4002f1eeea7
Signed-off-by: Marcello Sylvester Bauer <sylv(a)sylv.io>
---
M Documentation/ifdtool/layout.md
1 file changed, 53 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/38832/1
diff --git a/Documentation/ifdtool/layout.md b/Documentation/ifdtool/layout.md
index 950db6f..c09cfaa 100644
--- a/Documentation/ifdtool/layout.md
+++ b/Documentation/ifdtool/layout.md
@@ -4,7 +4,7 @@
layout of the flash. The Intel Flash Descriptor (IFD) which defines offsets and
sizes of various regions of flash and the [coreboot FMAP](../lib/flashmap.md).
-The FMAP should define all of the of the regions defined by the IFD to ensure
+The FMAP should define all offsets of the regions defined by the IFD to ensure
that those regions are accounted for by coreboot and will not be accidentally
modified.
@@ -23,7 +23,7 @@
|4|Platform Data|SI_PDR||
|8|EC Firmware|SI_EC|Most Chrome OS devices do not use this region; EC firmware is stored BIOS region of flash|
-## Validation
+## Modification
The ifdtool can be used to manipulate a firmware image with a IFD. This tool
will not take into account the FMAP while modifying the image which can lead to
@@ -32,6 +32,56 @@
ME, then when the ME is added by the ifdtool 6 MB will be written which could
overwrite 2 MB of the BIOS.
+### Manual Modification
+
+It is possible to adjust the IFD regions on a firmware image or on a Flash Descriptor file directly.
+In the case of modifying a complete firmware image, it will also move the data content of each region.
+
+The process consists of three steps:
+ 1) dump the ifd layout file out of the firmware/descriptor image
+ 2) modify the ifd region defined on the layout file
+ 3) update the firmware/descriptor image using the new layout
+
+#### Example - Reduce the ME Region size
+
+##### Step 1 - Dump IFD regions into a flashrom layout file
+ $ ifdtool -f ifd_old.layout descriptor.bin
+ Wrote layout to ifd-old.layout
+
+ $ cat ifd_old.layout
+ 00000000:00000fff fd
+ 00500000:007fffff bios
+ 00003000:004fffff me
+ 00001000:00002fff gbe
+
+##### Step 2 - Modify the layout file
+ $ diff ifd_old.layout ifd_new.layout
+ 2,3c2,3
+ < 00500000:007fffff bios
+ < 00003000:004fffff me
+ ---
+ > 00020000:007fffff bios
+ > 00003000:0001ffff me
+
+##### Step 3 - Update the IFD regions
+ $ ifdtool -n ifd_new.layout descriptor.bin
+ [...]
+ Writing new image to descriptor.bin.new
+
+### build-time Modification
+
+Instead of using the the ifdtool directly, it is possible to define a flashrom layout file in the
+coreboot configuration, so that it will be modified at build-time.
+
+ $ make menuconfig
+ Chipset --->
+ [*] Add Intel descriptor.bin file
+ (path/to/descriptor.bin) Path and filename of the descriptor.bin file
+ [*] update regions using a flashrom layout file
+ (path/to/ifd.layout) Path and filename flashrom layout file
+
+## Validation
+
In order to validate that the FMAP and the IFD are compatible the ifdtool
provides --validate (-t) option. `ifdtool -t` will read both the IFD and the
FMAP in the image and for every non empty region in the IFD if that region is
@@ -63,4 +113,4 @@
FMAP area SI_PDR:
offset: 0x007fc000
length: 0x00004000
-```
\ No newline at end of file
+```
--
To view, visit https://review.coreboot.org/c/coreboot/+/38832
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I862bd851fc68365ca11aa0477ae4e4002f1eeea7
Gerrit-Change-Number: 38832
Gerrit-PatchSet: 1
Gerrit-Owner: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-MessageType: newchange