Hello John Zhao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34249
to review the following change.
Change subject: cpu/x86: Initialize the argument value msr_index
......................................................................
cpu/x86: Initialize the argument value msr_index
Clang Static Analyzer version 8.0.0 treats the uninitialized argument
value msr_index as logic error in a function call. Just set msr_index
with 0 initially.
Change-Id: I051b290998207a1129ada06bb455f44c2d291975
Signed-off-by: John Zhao <john.zhao(a)intel.com>
---
M src/cpu/x86/mtrr/mtrr.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/34249/1
diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c
index 98449d5..4dc71d6 100644
--- a/src/cpu/x86/mtrr/mtrr.c
+++ b/src/cpu/x86/mtrr/mtrr.c
@@ -321,6 +321,7 @@
fixed_mtrrs_expose_amd_rwdram();
+ memset(&msr_index, 0, sizeof(msr_index));
memset(&fixed_msrs, 0, sizeof(fixed_msrs));
msr_num = 0;
--
To view, visit https://review.coreboot.org/c/coreboot/+/34249
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051b290998207a1129ada06bb455f44c2d291975
Gerrit-Change-Number: 34249
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange
Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT
......................................................................
mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so added config for the same.
Also updated the default path for config FSP_FILE according to the current coreboot directory structure.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95
Signed-off-by: Himanshu Sahdev <Coreboot(a)hcl.com>
---
M src/mainboard/intel/minnowmax/Kconfig
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/1
diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig
index ca24c92..0e3de50 100644
--- a/src/mainboard/intel/minnowmax/Kconfig
+++ b/src/mainboard/intel/minnowmax/Kconfig
@@ -37,7 +37,7 @@
config FSP_FILE
string
- default "../intel/fsp/baytrail/BAYTRAIL_FSP.fd"
+ default "3rdparty/fsp/BayTrailFspBinPkg/FspBin/BAYTRAIL_FSP.fd"
config CBFS_SIZE
hex
@@ -57,6 +57,10 @@
bool
default n
+config FSP_PACKAGE_DEFAULT
+ bool "Configure defaults for the Intel FSP package"
+ default n
+
config VGA_BIOS
bool
default y if FSP_PACKAGE_DEFAULT
--
To view, visit https://review.coreboot.org/c/coreboot/+/34630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95
Gerrit-Change-Number: 34630
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002476
Gerrit-MessageType: newchange