Change in ...coreboot[master]: Supplement motherboard name for G41M-GS

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

[XS] Change in coreboot[master]:...

Pixie (Code Review)

20 Apr 2019 20 Apr '19

7:10 a.m.

Pixie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32372

Change subject: Supplement motherboard name for G41M-GS ......................................................................

Supplement motherboard name for G41M-GS

A few months ago, Arthur Heymans rebased a few patches to add support for the G41M-GS to aid me in testing my G41M-S. The two boards are exact duplicates, save for the -GS having a gigabit LAN chip, and the G41M-S having a 100Mbit one. I did some scant testing, and it worked, but I had a lot of other projects ongoing. Now that I remembered thisagain, I'm here to commit the motherboard name.

Signed-off-by: Cheetah Pixie mayulithsv@gmail.com Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 --- M src/mainboard/asrock/g41c-gs/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32372/1

diff --git a/src/mainboard/asrock/g41c-gs/Kconfig.name b/src/mainboard/asrock/g41c-gs/Kconfig.name index 86a41aa..1a090ff3 100644 --- a/src/mainboard/asrock/g41c-gs/Kconfig.name +++ b/src/mainboard/asrock/g41c-gs/Kconfig.name @@ -5,7 +5,7 @@ bool "G41C-GS / G41C-S"

config BOARD_ASROCK_G41M_GS - bool "G41M-GS" + bool "G41M-GS / G41M-S"

config BOARD_ASROCK_G41M_S3 bool "G41M-S3"

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Arthur Heymans (Code Review)

20 Apr 20 Apr

11:48 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32372 )

Change subject: Supplement motherboard name for G41M-GS ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32372/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32372/1//COMMIT_MSG@7 PS1, Line 7: Supplement motherboard name for G41M-GS : : A few months ago, Arthur Heymans rebased a few patches to add : support for the G41M-GS to aid me in testing my G41M-S. The : two boards are exact duplicates, save for the -GS having a : gigabit LAN chip, and the G41M-S having a 100Mbit one. I did : some scant testing, and it worked, but I had a lot of other : projects ongoing. Now that I remembered thisagain, I'm here : to commit the motherboard name. Be more brief. something like: "mb/asrock/g41c-gs: Add G41M-S variant

This board is the same G41M-GS except for the ethernet NIC."

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 1 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Apr 2019 09:48:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Pixie (Code Review)

11:55 a.m.

Pixie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32372 )

Change subject: Supplement motherboard name for G41M-GS ......................................................................

Patch Set 1:

I have no idea how to amend that, but alright.

I'll be on IRC tomorrow morning again.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 1 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Apr 2019 09:55:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Pixie (Code Review)

10:31 p.m.

New subject: Change in ...coreboot[master]: "mb/asrock/g41c-gs: Add G41M-S variant

Hello Angel Pons, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32372

to look at the new patch set (#2).

Change subject: "mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

"mb/asrock/g41c-gs: Add G41M-S variant

It has the exact same hardware as the G41M-GS, with the exception of the ethernet NIC.

Signed-off-by: Cheetah Pixie mayulithsv@gmail.com Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 --- M src/mainboard/asrock/g41c-gs/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32372/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 2 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Arthur Heymans (Code Review)

21 Apr 21 Apr

3:47 p.m.

New subject: Change in ...coreboot[master]: "mb/asrock/g41c-gs: Add G41M-S variant

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32372 )

Change subject: "mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32372/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32372/2//COMMIT_MSG@7 PS2, Line 7: " remove

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 2 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 21 Apr 2019 13:47:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Pixie (Code Review)

10:09 p.m.

New subject: Change in ...coreboot[master]: mb/asrock/g41c-gs: Add G41M-S variant

Hello Angel Pons, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32372

to look at the new patch set (#3).

Change subject: mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

mb/asrock/g41c-gs: Add G41M-S variant

It has the exact same hardware as the G41M-GS, with the exception of the ethernet NIC.

Signed-off-by: Cheetah Pixie mayulithsv@gmail.com Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 --- M src/mainboard/asrock/g41c-gs/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32372/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 3 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Felix Held (Code Review)

4 Jun 4 Jun

2:33 p.m.

New subject: Change in ...coreboot[master]: mb/asrock/g41c-gs: Add G41M-S variant

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32372 )

Change subject: mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 3 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Jun 2019 12:33:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

5 Jun 5 Jun

12:59 a.m.

New subject: Change in ...coreboot[master]: mb/asrock/g41c-gs: Add G41M-S variant

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32372 )

Change subject: mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

Patch Set 3: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/32372/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32372/3//COMMIT_MSG@12 PS3, Line 12: Signed-off-by: Cheetah Pixie mayulithsv@gmail.com I've got concerns regarding this signed-off line.

https://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 3 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Jun 2019 22:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

1:27 p.m.

New subject: Change in ...coreboot[master]: mb/asrock/g41c-gs: Add G41M-S variant

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32372 )

Change subject: mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

Patch Set 3: -Code-Review

(1 comment)

https://review.coreboot.org/#/c/32372/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32372/3//COMMIT_MSG@12 PS3, Line 12: Signed-off-by: Cheetah Pixie mayulithsv@gmail.com

...

I've got concerns regarding this signed-off line. […]

ah, didn't spot that

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 3 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 05 Jun 2019 11:27:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

10:21 p.m.

New subject: [XS] Change in coreboot[master]: mb/asrock/g41c-gs: Add G41M-S variant

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32372?usp=email )

Change subject: mb/asrock/g41c-gs: Add G41M-S variant ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32372?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f77ec2c8cbd9c2f13e6890257cb7c5b1c77311 Gerrit-Change-Number: 32372 Gerrit-PatchSet: 3 Gerrit-Owner: Pixie mayulithsv@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pixie mayulithsv@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

265

days inactive

1835

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Felix Held (Code Review)
Martin L Roth (Code Review)
Pixie (Code Review)