coreboot-gerrit December 2020

coreboot-gerrit@coreboot.org

1 participants
3168 discussions

Change in coreboot[master]: mb/google/volteer: Add GPIO to drobit support
by Frank Chu (Code Review) 17 Dec '20

17 Dec '20

Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48497 ) Change subject: mb/google/volteer: Add GPIO to drobit support ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/48497/4/src/mainboard/google/volte… File src/mainboard/google/volteer/variants/drobit/gpio.c: https://review.coreboot.org/c/coreboot/+/48497/4/src/mainboard/google/volte… PS4, Line 144: > use tab instead of spaces please Done -- To view, visit https://review.coreboot.org/c/coreboot/+/48497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54ba182c6da3db282961b3c72a4d2d11d1001e95 Gerrit-Change-Number: 48497 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Fri, 18 Dec 2020 06:32:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Add GPIO to drobit support
by Frank Chu (Code Review) 17 Dec '20

17 Dec '20

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48497 to look at the new patch set (#5). Change subject: mb/google/volteer: Add GPIO to drobit support ...................................................................... mb/google/volteer: Add GPIO to drobit support Add support for gpio driver for drobit BUG=b:175351914 BRANCH=none TEST=emerge-volteer coreboot Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: I54ba182c6da3db282961b3c72a4d2d11d1001e95 --- M src/mainboard/google/volteer/variants/drobit/Makefile.inc A src/mainboard/google/volteer/variants/drobit/gpio.c 2 files changed, 185 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/48497/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/48497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54ba182c6da3db282961b3c72a4d2d11d1001e95 Gerrit-Change-Number: 48497 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: Update SPD table for galtic
by Frank Chu (Code Review) 17 Dec '20

17 Dec '20

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48655 to look at the new patch set (#3). Change subject: mb/google/dedede: Update SPD table for galtic ...................................................................... mb/google/dedede: Update SPD table for galtic galtic memory table as follow: value Vendor Part number 0x00 MICRON MT53E512M32D2NP-046 WT:E 0x00 HYNIX H9HCNNNBKMMLXR-NEE 0x01 MICRON MT53E1G32D2NP-046 WT:A 0x02 HYNIX H9HCNNNCPMMLXR-NEE BUG=b:170913840 BRANCH=none TEST=emerge-dedede coreboot Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: I30b8fe3f14e1af7bb5760530477f9311c6a4ee62 --- M src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc M src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt 3 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/48655/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/48655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30b8fe3f14e1af7bb5760530477f9311c6a4ee62 Gerrit-Change-Number: 48655 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Edward Dai <edwarddai(a)google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in em100[master]: EM100 changes
by Stefan Reinauer (Code Review) 17 Dec '20

17 Dec '20

Hello Duncan Laurie, I'd like you to do a code review. Please visit https://review.coreboot.org/c/em100/+/48592 to review the following change. Change subject: EM100 changes ...................................................................... EM100 changes Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Signed-off-by: Duncan Laurie <dlaurie(a)google.com> Change-Id: I0c9ba505ed59bb06f681423a98ccc58cfb99efdf --- M trace.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/92/48592/1 diff --git a/trace.c b/trace.c index 22517f9..4d6a26c 100644 --- a/trace.c +++ b/trace.c @@ -262,6 +262,7 @@ j = MAX_TRACE_BLOCKLENGTH; } } +#if 0 printf("\nTime: %06lld.%08lld", (timestamp - start_timestamp) / 100000000, @@ -270,10 +271,22 @@ printf(" command # %-6d : 0x%02x - %s", ++counter, spi_command, spi_cmd_vals->cmd_name); +#else + if (start_timestamp) + start_timestamp = 0; +#endif + if (spi_cmd_vals->uses_address) + printf("0x%02x @ 0x%08x (%s)\n", + spi_command, address, spi_cmd_vals->cmd_name); + else + printf("0x%02x (%s)\n", + spi_command, spi_cmd_vals->cmd_name); + curpos = 0; outbytes = 0; } +#if 0 /* this exploits 8bit wrap around in curpos */ unsigned char blocklen = (data[2 + i*8 + 1] - curpos); blocklen /= 8; @@ -296,6 +309,10 @@ address += 16; } } +#else + if (outbytes) + outbytes++; +#endif // this is because the em100 counts funny curpos = data[2 + i*8 + 1] + 0x10; fflush(stdout); -- To view, visit https://review.coreboot.org/c/em100/+/48592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I0c9ba505ed59bb06f681423a98ccc58cfb99efdf Gerrit-Change-Number: 48592 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/google/dedede: Update galtic device tree
by Frank Chu (Code Review) 17 Dec '20

17 Dec '20

Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48656 ) Change subject: mb/google/dedede: Update galtic device tree ...................................................................... Patch Set 6: (6 comments) https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… File src/mainboard/google/dedede/variants/galtic/overridetree.cb: https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… PS4, Line 11: Audio > Trackpad based on your config below. Done https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… PS4, Line 13: Trackpad > Audio based on your config below. Done https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… PS4, Line 39: > # USB Port Configuration […] Done https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… PS4, Line 56: device usb 2.6 on end > Why is it on? If you are not planning to use it, leave it off. Done https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… PS4, Line 79: ACPI_IRQ_WAKE_EDGE_LOW > HID devices should have level triggered interrupt. Done https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/deded… PS4, Line 90: ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ) > HID devices should have Level Triggered interrupt. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/48656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I270cd2a9783030ad3a080b9cfda8a133e801c5ce Gerrit-Change-Number: 48656 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Edward Dai <edwarddai(a)google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 18 Dec 2020 04:12:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Update galtic device tree
by build bot (Jenkins) (Code Review) 17 Dec '20

17 Dec '20

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48656 ) Change subject: mb/google/dedede: Update galtic device tree ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/48656/5/src/mainboard/google/deded… File src/mainboard/google/dedede/variants/galtic/overridetree.cb: https://review.coreboot.org/c/coreboot/+/48656/5/src/mainboard/google/deded… PS5, Line 39: # USB Port Configuration trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/48656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I270cd2a9783030ad3a080b9cfda8a133e801c5ce Gerrit-Change-Number: 48656 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Edward Dai <edwarddai(a)google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 18 Dec 2020 04:08:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Update galtic device tree
by Frank Chu (Code Review) 17 Dec '20

17 Dec '20

Hello build bot (Jenkins), Henry Sun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48656 to look at the new patch set (#6). Change subject: mb/google/dedede: Update galtic device tree ...................................................................... mb/google/dedede: Update galtic device tree Update galtic device tree override to match schematics. BUG=b:170913840 BRANCH=none TEST=emerge-dedede coreboot Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: I270cd2a9783030ad3a080b9cfda8a133e801c5ce --- M src/mainboard/google/dedede/variants/galtic/overridetree.cb 1 file changed, 78 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/48656/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/48656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I270cd2a9783030ad3a080b9cfda8a133e801c5ce Gerrit-Change-Number: 48656 Gerrit-PatchSet: 6 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Edward Dai <edwarddai(a)google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: Update galtic device tree
by Frank Chu (Code Review) 17 Dec '20

17 Dec '20

Hello build bot (Jenkins), Henry Sun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48656 to look at the new patch set (#5). Change subject: mb/google/dedede: Update galtic device tree ...................................................................... mb/google/dedede: Update galtic device tree Update galtic device tree override to match schematics. BUG=b:170913840 BRANCH=none TEST=emerge-dedede coreboot Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: I270cd2a9783030ad3a080b9cfda8a133e801c5ce --- M src/mainboard/google/dedede/variants/galtic/overridetree.cb 1 file changed, 78 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/48656/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/48656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I270cd2a9783030ad3a080b9cfda8a133e801c5ce Gerrit-Change-Number: 48656 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Edward Dai <edwarddai(a)google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8192: add pmif driver support for romstage
by Yidi Lin (Code Review) 17 Dec '20

17 Dec '20

Hello hsin-hsiung wang, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/46396 to review the following change. Change subject: soc/mediatek/mt8192: add pmif driver support for romstage ...................................................................... soc/mediatek/mt8192: add pmif driver support for romstage Add pmif driver support for romstage. TEST=Boots correctly on asurada p0. Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang(a)mediatek.com> Change-Id: I141bc30b034714657b743f3453b2782b4d8d4e43 --- M src/soc/mediatek/mt8192/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/46396/1 diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index 9542aa4..e7ff25d 100755 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -32,6 +32,7 @@ romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c romstage-y += ../common/timer.c romstage-y += ../common/uart.c +romstage-y += pmif.c pmif_clk.c pmif_spi.c pmif_spmi.c ramstage-y += auxadc.c ramstage-y += flash_controller.c -- To view, visit https://review.coreboot.org/c/coreboot/+/46396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I141bc30b034714657b743f3453b2782b4d8d4e43 Gerrit-Change-Number: 46396 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: soc/mediatek/mt8192: add 6359p driver support for romstage
by Yidi Lin (Code Review) 17 Dec '20

17 Dec '20

Hello hsin-hsiung wang, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/46397 to review the following change. Change subject: soc/mediatek/mt8192: add 6359p driver support for romstage ...................................................................... soc/mediatek/mt8192: add 6359p driver support for romstage Add 6359p driver support for romstage. TEST=Boots correctly on asurada p0. Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang(a)mediatek.com> Change-Id: I46bca69836d41e7c35b196d91d9fbdbdb7d71df7 --- M src/mainboard/google/asurada/romstage.c M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8192/include/soc/mt6359p.h M src/soc/mediatek/mt8192/mt6359p.c 4 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/46397/1 diff --git a/src/mainboard/google/asurada/romstage.c b/src/mainboard/google/asurada/romstage.c index 3d03bd4..bd5cd74 100644 --- a/src/mainboard/google/asurada/romstage.c +++ b/src/mainboard/google/asurada/romstage.c @@ -6,6 +6,7 @@ #include <soc/dramc_param.h> #include <soc/emi.h> #include <soc/mmu_operations.h> +#include <soc/mt6359p.h> /* This must be defined in chromeos.fmd in same name and size. */ #define CALIBRATION_REGION "RW_DDR_TRAINING" @@ -43,6 +44,7 @@ void platform_romstage_main(void) { + mt6359p_romstage_init(); mt_mem_init(&dparam_ops); mtk_mmu_after_dram(); } diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index e7ff25d..657aa8e 100755 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -33,6 +33,7 @@ romstage-y += ../common/timer.c romstage-y += ../common/uart.c romstage-y += pmif.c pmif_clk.c pmif_spi.c pmif_spmi.c +romstage-y += mt6359p.c ramstage-y += auxadc.c ramstage-y += flash_controller.c diff --git a/src/soc/mediatek/mt8192/include/soc/mt6359p.h b/src/soc/mediatek/mt8192/include/soc/mt6359p.h index ce7ef24..c0f01a0 100644 --- a/src/soc/mediatek/mt8192/include/soc/mt6359p.h +++ b/src/soc/mediatek/mt8192/include/soc/mt6359p.h @@ -41,6 +41,7 @@ #define VM18_VOL_REG_SHIFT 8 void mt6359p_init(void); +void mt6359p_romstage_init(void); void mt6359p_buck_set_voltage(u32 buck_id, u32 buck_uv); u32 mt6359p_buck_get_voltage(u32 buck_id); void mt6359p_set_vm18_voltage(u32 vm18_uv); diff --git a/src/soc/mediatek/mt8192/mt6359p.c b/src/soc/mediatek/mt8192/mt6359p.c index c70485d..2eb3f60 100644 --- a/src/soc/mediatek/mt8192/mt6359p.c +++ b/src/soc/mediatek/mt8192/mt6359p.c @@ -457,3 +457,12 @@ pmic_lp_setting(); pmic_wk_vs2_voter_setting(); } + +void mt6359p_romstage_init(void) +{ + if (pmif_arb == NULL) { + pmif_arb = get_pmif_controller(PMIF_SPI, 0); + if (pmif_arb == NULL) + die("ERROR - Failed to get pmif controller\n"); + } +} -- To view, visit https://review.coreboot.org/c/coreboot/+/46397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46bca69836d41e7c35b196d91d9fbdbdb7d71df7 Gerrit-Change-Number: 46397 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-MessageType: newchange

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2020