coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: soc/intel/common: Rename save state accessors
by Arthur Heymans (Code Review) 11 Nov '20

11 Nov '20

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37110 ) Change subject: soc/intel/common: Rename save state accessors ...................................................................... soc/intel/common: Rename save state accessors This avoids name collision with follow-up code that intends to reuse these names and replace this code. Change-Id: Ib24ab09e7f35bb231a8069905860c612d5e35454 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/apollolake/smihandler.c M src/soc/intel/cannonlake/smihandler.c M src/soc/intel/common/block/include/intelblocks/smihandler.h M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/icelake/smihandler.c M src/soc/intel/skylake/smihandler.c M src/soc/intel/tigerlake/smihandler.c 8 files changed, 71 insertions(+), 71 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37110/1 diff --git a/src/soc/intel/apollolake/smihandler.c b/src/soc/intel/apollolake/smihandler.c index 53d2b7e..f26d8ba 100644 --- a/src/soc/intel/apollolake/smihandler.c +++ b/src/soc/intel/apollolake/smihandler.c @@ -29,7 +29,7 @@ return 1; } -const struct smm_save_state_ops *get_smm_save_state_ops(void) +const struct intel_smm_save_state_ops *get_smm_save_state_ops(void) { return &em64t100_smm_ops; } diff --git a/src/soc/intel/cannonlake/smihandler.c b/src/soc/intel/cannonlake/smihandler.c index 4d0b241..1d57c7e 100644 --- a/src/soc/intel/cannonlake/smihandler.c +++ b/src/soc/intel/cannonlake/smihandler.c @@ -32,7 +32,7 @@ #define CSME0_BAR 0x0 #define CSME0_FID 0xb0 -const struct smm_save_state_ops *get_smm_save_state_ops(void) +const struct intel_smm_save_state_ops *get_smm_save_state_ops(void) { return &em64t101_smm_ops; } diff --git a/src/soc/intel/common/block/include/intelblocks/smihandler.h b/src/soc/intel/common/block/include/intelblocks/smihandler.h index d8520f1..afe8505 100644 --- a/src/soc/intel/common/block/include/intelblocks/smihandler.h +++ b/src/soc/intel/common/block/include/intelblocks/smihandler.h @@ -25,32 +25,32 @@ /* * The register value is used with get_reg and set_reg */ -enum smm_reg { - RAX, - RBX, - RCX, - RDX, +enum intel_smm_reg { + SMM_RAX, + SMM_RBX, + SMM_RCX, + SMM_RDX, }; -struct smm_save_state_ops { +struct intel_smm_save_state_ops { /* return io_misc_info from SMM Save State Area */ uint32_t (*get_io_misc_info)(void *state); /* return value of the requested register from * SMM Save State Area */ - uint64_t (*get_reg)(void *state, enum smm_reg reg); + uint64_t (*get_reg)(void *state, enum intel_smm_reg reg); - void (*set_reg)(void *state, enum smm_reg reg, uint64_t val); + void (*set_reg)(void *state, enum intel_smm_reg reg, uint64_t val); }; -typedef void (*smi_handler_t)(const struct smm_save_state_ops *save_state_ops); +typedef void (*smi_handler_t)(const struct intel_smm_save_state_ops *save_state_ops); /* * SOC SMI Handler has to provide this structure which has methods to access * the SOC specific SMM Save State Area */ -const struct smm_save_state_ops *get_smm_save_state_ops(void); +const struct intel_smm_save_state_ops *get_smm_save_state_ops(void); /* * southbridge_smi should be defined inside SOC specific code and should have @@ -67,7 +67,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_sleep( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -75,7 +75,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_apmc( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -83,7 +83,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_pm1( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -91,7 +91,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_gpe0( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -99,7 +99,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_mc( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -107,14 +107,14 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_monitor( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle * SMI_TCO event. The default functionality is provided in * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_tco( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -122,7 +122,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_periodic( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -130,7 +130,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_gpi( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * This function should be implemented in SOC specific code to handle @@ -138,7 +138,7 @@ * soc/intel/common/block/smm/smihandler.c */ void smihandler_southbridge_espi( - const struct smm_save_state_ops *save_state_ops); + const struct intel_smm_save_state_ops *save_state_ops); /* * Returns gnvs pointer within SMM context @@ -173,7 +173,7 @@ /* Mainboard handler for ESPI EMIs */ void mainboard_smi_espi_handler(void); -extern const struct smm_save_state_ops em64t100_smm_ops; +extern const struct intel_smm_save_state_ops em64t100_smm_ops; -extern const struct smm_save_state_ops em64t101_smm_ops; +extern const struct intel_smm_save_state_ops em64t101_smm_ops; #endif diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c index 0581d23..d76fb0a 100644 --- a/src/soc/intel/common/block/smm/smihandler.c +++ b/src/soc/intel/common/block/smm/smihandler.c @@ -87,7 +87,7 @@ /* Common Functions */ -static void *find_save_state(const struct smm_save_state_ops *save_state_ops, +static void *find_save_state(const struct intel_smm_save_state_ops *save_state_ops, int cmd) { int node; @@ -111,7 +111,7 @@ if (((io_misc_info >> 16) & 0xff) != APM_CNT) continue; /* Check AL against the requested command */ - reg_al = save_state_ops->get_reg(state, RAX); + reg_al = save_state_ops->get_reg(state, SMM_RAX); if (reg_al != cmd) continue; break; @@ -179,7 +179,7 @@ void smihandler_southbridge_sleep( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { uint32_t reg32; uint8_t slp_typ; @@ -275,7 +275,7 @@ } static void southbridge_smi_gsmi( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { u8 sub_command, ret; void *io_smi = NULL; @@ -285,19 +285,19 @@ if (!io_smi) return; /* Command and return value in EAX */ - sub_command = (save_state_ops->get_reg(io_smi, RAX) >> 8) + sub_command = (save_state_ops->get_reg(io_smi, SMM_RAX) >> 8) & 0xff; /* Parameter buffer in EBX */ - reg_ebx = save_state_ops->get_reg(io_smi, RBX); + reg_ebx = save_state_ops->get_reg(io_smi, SMM_RBX); /* drivers/elog/gsmi.c */ ret = gsmi_exec(sub_command, &reg_ebx); - save_state_ops->set_reg(io_smi, RAX, ret); + save_state_ops->set_reg(io_smi, SMM_RAX, ret); } static void southbridge_smi_store( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { u8 sub_command, ret; void *io_smi; @@ -307,14 +307,14 @@ if (!io_smi) return; /* Command and return value in EAX */ - sub_command = (save_state_ops->get_reg(io_smi, RAX) >> 8) & 0xff; + sub_command = (save_state_ops->get_reg(io_smi, SMM_RAX) >> 8) & 0xff; /* Parameter buffer in EBX */ - reg_ebx = save_state_ops->get_reg(io_smi, RBX); + reg_ebx = save_state_ops->get_reg(io_smi, SMM_RBX); /* drivers/smmstore/smi.c */ ret = smmstore_exec(sub_command, (void *)reg_ebx); - save_state_ops->set_reg(io_smi, RAX, ret); + save_state_ops->set_reg(io_smi, SMM_RAX, ret); } static void finalize(void) @@ -336,7 +336,7 @@ } void smihandler_southbridge_apmc( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { uint8_t reg8; void *state = NULL; @@ -379,7 +379,7 @@ state = find_save_state(save_state_ops, reg8); if (state) { /* EBX in the state save contains the GNVS pointer */ - uint32_t reg_ebx = save_state_ops->get_reg(state, RBX); + uint32_t reg_ebx = save_state_ops->get_reg(state, SMM_RBX); gnvs = (struct global_nvs_t *)(uintptr_t)reg_ebx; smm_initialized = 1; printk(BIOS_DEBUG, "SMI#: Setting GNVS to %p\n", gnvs); @@ -402,7 +402,7 @@ } void smihandler_southbridge_pm1( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { uint16_t pm1_sts = pmc_clear_pm1_status(); u16 pm1_en = pmc_read_pm1_enable(); @@ -420,13 +420,13 @@ } void smihandler_southbridge_gpe0( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { pmc_clear_all_gpe_status(); } void smihandler_southbridge_tco( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { uint32_t tco_sts = pmc_clear_tco_status(); @@ -443,7 +443,7 @@ } void smihandler_southbridge_periodic( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { uint32_t reg32; @@ -456,7 +456,7 @@ } void smihandler_southbridge_gpi( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { struct gpi_status smi_sts; @@ -468,7 +468,7 @@ } void smihandler_southbridge_espi( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { mainboard_smi_espi_handler(); } @@ -477,7 +477,7 @@ { int i; uint32_t smi_sts; - const struct smm_save_state_ops *save_state_ops; + const struct intel_smm_save_state_ops *save_state_ops; /* * We need to clear the SMI status registers, or we won't see what's @@ -519,22 +519,22 @@ return smm_state->io_misc_info; } -static uint64_t em64t100_smm_save_state_get_reg(void *state, enum smm_reg reg) +static uint64_t em64t100_smm_save_state_get_reg(void *state, enum intel_smm_reg reg) { uintptr_t value = 0; em64t100_smm_state_save_area_t *smm_state = state; switch (reg) { - case RAX: + case SMM_RAX: value = smm_state->rax; break; - case RBX: + case SMM_RBX: value = smm_state->rbx; break; - case RCX: + case SMM_RCX: value = smm_state->rcx; break; - case RDX: + case SMM_RDX: value = smm_state->rdx; break; default: @@ -543,21 +543,21 @@ return value; } -static void em64t100_smm_save_state_set_reg(void *state, enum smm_reg reg, +static void em64t100_smm_save_state_set_reg(void *state, enum intel_smm_reg reg, uint64_t val) { em64t100_smm_state_save_area_t *smm_state = state; switch (reg) { - case RAX: + case SMM_RAX: smm_state->rax = val; break; - case RBX: + case SMM_RBX: smm_state->rbx = val; break; - case RCX: + case SMM_RCX: smm_state->rcx = val; break; - case RDX: + case SMM_RDX: smm_state->rdx = val; break; default: @@ -571,22 +571,22 @@ return smm_state->io_misc_info; } -static uint64_t em64t101_smm_save_state_get_reg(void *state, enum smm_reg reg) +static uint64_t em64t101_smm_save_state_get_reg(void *state, enum intel_smm_reg reg) { uintptr_t value = 0; em64t101_smm_state_save_area_t *smm_state = state; switch (reg) { - case RAX: + case SMM_RAX: value = smm_state->rax; break; - case RBX: + case SMM_RBX: value = smm_state->rbx; break; - case RCX: + case SMM_RCX: value = smm_state->rcx; break; - case RDX: + case SMM_RDX: value = smm_state->rdx; break; default: @@ -595,21 +595,21 @@ return value; } -static void em64t101_smm_save_state_set_reg(void *state, enum smm_reg reg, +static void em64t101_smm_save_state_set_reg(void *state, enum intel_smm_reg reg, uint64_t val) { em64t101_smm_state_save_area_t *smm_state = state; switch (reg) { - case RAX: + case SMM_RAX: smm_state->rax = val; break; - case RBX: + case SMM_RBX: smm_state->rbx = val; break; - case RCX: + case SMM_RCX: smm_state->rcx = val; break; - case RDX: + case SMM_RDX: smm_state->rdx = val; break; default: @@ -617,13 +617,13 @@ } } -const struct smm_save_state_ops em64t100_smm_ops = { +const struct intel_smm_save_state_ops em64t100_smm_ops = { .get_io_misc_info = em64t100_smm_save_state_get_io_misc_info, .get_reg = em64t100_smm_save_state_get_reg, .set_reg = em64t100_smm_save_state_set_reg, }; -const struct smm_save_state_ops em64t101_smm_ops = { +const struct intel_smm_save_state_ops em64t101_smm_ops = { .get_io_misc_info = em64t101_smm_save_state_get_io_misc_info, .get_reg = em64t101_smm_save_state_get_reg, .set_reg = em64t101_smm_save_state_set_reg, diff --git a/src/soc/intel/common/block/smm/smitraphandler.c b/src/soc/intel/common/block/smm/smitraphandler.c index 974c489..b7e25e4 100644 --- a/src/soc/intel/common/block/smm/smitraphandler.c +++ b/src/soc/intel/common/block/smm/smitraphandler.c @@ -56,7 +56,7 @@ } void smihandler_southbridge_mc( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { u32 reg32 = inl(ACPI_BASE_ADDRESS + SMI_EN); @@ -68,7 +68,7 @@ } void smihandler_southbridge_monitor( - const struct smm_save_state_ops *save_state_ops) + const struct intel_smm_save_state_ops *save_state_ops) { #define IOTRAP(x) (trap_sts & (1 << x)) u32 trap_cycle; diff --git a/src/soc/intel/icelake/smihandler.c b/src/soc/intel/icelake/smihandler.c index b7c37d4..039900e 100644 --- a/src/soc/intel/icelake/smihandler.c +++ b/src/soc/intel/icelake/smihandler.c @@ -29,7 +29,7 @@ #define CSME0_BAR 0x0 #define CSME0_FID 0xb0 -const struct smm_save_state_ops *get_smm_save_state_ops(void) +const struct intel_smm_save_state_ops *get_smm_save_state_ops(void) { return &em64t101_smm_ops; } diff --git a/src/soc/intel/skylake/smihandler.c b/src/soc/intel/skylake/smihandler.c index 2e93075..50a82f9 100644 --- a/src/soc/intel/skylake/smihandler.c +++ b/src/soc/intel/skylake/smihandler.c @@ -20,7 +20,7 @@ #include <intelblocks/smihandler.h> #include <soc/pm.h> -const struct smm_save_state_ops *get_smm_save_state_ops(void) +const struct intel_smm_save_state_ops *get_smm_save_state_ops(void) { return &em64t101_smm_ops; } diff --git a/src/soc/intel/tigerlake/smihandler.c b/src/soc/intel/tigerlake/smihandler.c index bf07bea..25bdacc 100644 --- a/src/soc/intel/tigerlake/smihandler.c +++ b/src/soc/intel/tigerlake/smihandler.c @@ -29,7 +29,7 @@ #define CSME0_BAR 0x0 #define CSME0_FID 0xb0 -const struct smm_save_state_ops *get_smm_save_state_ops(void) +const struct intel_smm_save_state_ops *get_smm_save_state_ops(void) { return &em64t101_smm_ops; } -- To view, visit https://review.coreboot.org/c/coreboot/+/37110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib24ab09e7f35bb231a8069905860c612d5e35454 Gerrit-Change-Number: 37110 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

3 6

Change in coreboot[master]: cpu/x86/smm: Add a helper function returning top of save state
by Arthur Heymans (Code Review) 11 Nov '20

11 Nov '20

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37008 ) Change subject: cpu/x86/smm: Add a helper function returning top of save state ...................................................................... cpu/x86/smm: Add a helper function returning top of save state Some entries like smm base and smm revision have a fixed location in the save w.r.t. the save state top. Change-Id: I82dadcb966ee686c1652c7a1298dcb9938ae888c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/smihandler.c M src/cpu/x86/smm/smm_module_handler.c M src/include/cpu/x86/smm.h 3 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/37008/1 diff --git a/src/cpu/x86/smm/smihandler.c b/src/cpu/x86/smm/smihandler.c index 20417d1..79a3936 100644 --- a/src/cpu/x86/smm/smihandler.c +++ b/src/cpu/x86/smm/smihandler.c @@ -132,6 +132,13 @@ return (void *)base; } +uint8_t *smm_get_save_state_top(int cpu) +{ + const uint32_t smm_base = 0xa0000; + + return (uint8_t *)smm_base + SMM_ENTRY_OFFSET * 2 - (cpu * 0x400); +} + /** * @brief Interrupt handler for SMI# * diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index bd4d48c..80bff9f 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -114,6 +114,19 @@ return base; } +uint8_t *smm_get_save_state_top(int cpu) +{ + uint8_t *base; + + /* This function assumes all save states start at top of default + * SMRAM size space and are staggered down by save state size. */ + base = (void *)smm_runtime->smbase; + base += SMM_DEFAULT_SIZE; + base -= cpu * smm_runtime->save_state_size; + + return base; +} + asmlinkage void smm_handler_start(void *arg) { const struct smm_module_params *p; diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index cf107b1..0ade970 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -94,6 +94,7 @@ /* Retrieve SMM save state for a given CPU. WARNING: This does not take into * account CPUs which are configured to not save their state to RAM. */ void *smm_get_save_state(int cpu); +uint8_t *smm_get_save_state_top(int cpu); /* SMM Module Loading API */ -- To view, visit https://review.coreboot.org/c/coreboot/+/37008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82dadcb966ee686c1652c7a1298dcb9938ae888c Gerrit-Change-Number: 37008 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

4 6

Change in coreboot[master]: soc/intel/xeon_sp: Enable SMI handler
by Arthur Heymans (Code Review) 11 Nov '20

11 Nov '20

Arthur Heymans has uploaded a new patch set (#26) to the change originally created by Rocky Phagura. ( https://review.coreboot.org/c/coreboot/+/46231 ) Change subject: soc/intel/xeon_sp: Enable SMI handler ...................................................................... soc/intel/xeon_sp: Enable SMI handler SMI handler was not installed for Xeon_sp platforms. This enables SMM relocation and SMI handling. TESTED: - SMRR are correctly set - The save state revision is correct (0x00030101) - SMI's are properly generated and handled - SMM MSR save state are not supported, so relocate SMM on all cores in series - Verified on OCP/Deltalake mainboard. NOTE: - Code for accessing a CPU save state is not working for SMMLOADERV2, so some SMM features like GSMI, SMMSTORE, updating the ACPI GNVS pointer are not supported. - This hooks up to some soc/intel/common like TCO and ACPI GNVS. GNVS is broken and needs to be fixed separately. It is unknown if TCO is supported. This might require a cleanup in the future. Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506 Signed-off-by: Rocky Phagura <rphagura(a)fb.com> Signed-off-by: Christian Walter <christian.walter(a)9elements.com> Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/xeon_sp/Kconfig M src/soc/intel/xeon_sp/Makefile.inc M src/soc/intel/xeon_sp/cpx/Kconfig M src/soc/intel/xeon_sp/cpx/Makefile.inc M src/soc/intel/xeon_sp/cpx/cpu.c M src/soc/intel/xeon_sp/include/soc/nvs.h A src/soc/intel/xeon_sp/include/soc/smbus.h A src/soc/intel/xeon_sp/include/soc/smmrelocate.h M src/soc/intel/xeon_sp/skx/Kconfig M src/soc/intel/xeon_sp/skx/Makefile.inc M src/soc/intel/xeon_sp/skx/cpu.c A src/soc/intel/xeon_sp/smihandler.c A src/soc/intel/xeon_sp/smmrelocate.c 14 files changed, 226 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/46231/26 -- To view, visit https://review.coreboot.org/c/coreboot/+/46231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506 Gerrit-Change-Number: 46231 Gerrit-PatchSet: 26 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/releases: Add ASan to 4.13 relnotes
by Harshit Sharma (Code Review) 11 Nov '20

11 Nov '20

Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45118 ) Change subject: Documentation/releases: Add ASan to 4.13 relnotes ...................................................................... Documentation/releases: Add ASan to 4.13 relnotes Change-Id: I2953729c69dfcfa8b34192b3e1623fdfad87ca3a Signed-off-by: Harshit Sharma <harshitsharmajs(a)gmail.com> --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/45118/1 diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index dcc8bf4..388d291 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -49,4 +49,13 @@ CPU threads as possible limited only by SMRAM space and not by 64K. By default this loader version is disabled. Please see cpu/x86/Kconfig for more info. +### Address Sanitizer + +coreboot now has an in-built Address Sanitizer, a runtime memory debugger +designed to find out-of-bounds access and use-after-scope bugs. It is made +available on all x86 platforms in ramstage and on QEMU i440fx, Intel Apollo +Lake, and Haswell in romstage. Further, it can be enabled in romstage on other +x86 platforms as well. Refer [ASan documentation](../technotes/asan.md) for +more info. + ### Add significant changes here -- To view, visit https://review.coreboot.org/c/coreboot/+/45118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2953729c69dfcfa8b34192b3e1623fdfad87ca3a Gerrit-Change-Number: 45118 Gerrit-PatchSet: 1 Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: soc/intel/xeon_sp: Enable SMI handler
by Arthur Heymans (Code Review) 11 Nov '20

11 Nov '20

Arthur Heymans has uploaded a new patch set (#25) to the change originally created by Rocky Phagura. ( https://review.coreboot.org/c/coreboot/+/46231 ) Change subject: soc/intel/xeon_sp: Enable SMI handler ...................................................................... soc/intel/xeon_sp: Enable SMI handler SMI handler was not installed for Xeon_sp platforms. This enables SMM relocation and SMI handling. TESTED: - SMRR are correctly set - The save state revision is correct (0x00030101) - SMI's are properly generated and handled - SMM save state MSR don't work, so relocate SMM on all cores in series - Verified on OCP/Deltalake mainboard. NOTE: - Code for accessing a CPU save state is not working for SMMLOADERV2 Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506 Signed-off-by: Rocky Phagura <rphagura(a)fb.com> Signed-off-by: Christian Walter <christian.walter(a)9elements.com> Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/xeon_sp/Kconfig M src/soc/intel/xeon_sp/Makefile.inc M src/soc/intel/xeon_sp/cpx/Kconfig M src/soc/intel/xeon_sp/cpx/Makefile.inc M src/soc/intel/xeon_sp/cpx/cpu.c M src/soc/intel/xeon_sp/include/soc/nvs.h A src/soc/intel/xeon_sp/include/soc/smbus.h A src/soc/intel/xeon_sp/include/soc/smmrelocate.h M src/soc/intel/xeon_sp/skx/Kconfig M src/soc/intel/xeon_sp/skx/Makefile.inc M src/soc/intel/xeon_sp/skx/cpu.c A src/soc/intel/xeon_sp/smihandler.c A src/soc/intel/xeon_sp/smmrelocate.c 14 files changed, 226 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/46231/25 -- To view, visit https://review.coreboot.org/c/coreboot/+/46231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506 Gerrit-Change-Number: 46231 Gerrit-PatchSet: 25 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel/lynxpoint/sata.c: Simplify RMW operations
by Angel Pons (Code Review) 11 Nov '20

11 Nov '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47030 ) Change subject: sb/intel/lynxpoint/sata.c: Simplify RMW operations ...................................................................... sb/intel/lynxpoint/sata.c: Simplify RMW operations Introduce the `sir_unset_and_set_mask` helper and update the one PCI read-modify-write operation that is somehow not reproducible. Change-Id: I30ad6ef8ad97ee0a8dc2297fba5bbbfe24f00f1c Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/southbridge/intel/lynxpoint/sata.c 1 file changed, 13 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/47030/1 diff --git a/src/southbridge/intel/lynxpoint/sata.c b/src/southbridge/intel/lynxpoint/sata.c index d0aaa99..4174e1f 100644 --- a/src/southbridge/intel/lynxpoint/sata.c +++ b/src/southbridge/intel/lynxpoint/sata.c @@ -25,10 +25,17 @@ pci_write_config32(dev, SATA_SIRD, value); } +static inline void sir_unset_and_set_mask(struct device *dev, int idx, u32 unset, u32 set) +{ + pci_write_config32(dev, SATA_SIRI, idx); + + const u32 value = pci_read_config32(dev, SATA_SIRD) & ~unset; + pci_write_config32(dev, SATA_SIRD, value | set); +} + static void sata_init(struct device *dev) { u32 reg32; - u16 reg16; u32 *abar; @@ -70,10 +77,7 @@ pci_write_config32(dev, IDE_CONFIG, reg32); /* for AHCI, Port Enable is managed in memory mapped space */ - reg16 = pci_read_config16(dev, 0x92); - reg16 &= ~0x3f; - reg16 |= 0x8000 | config->sata_port_map; - pci_write_config16(dev, 0x92, reg16); + pci_update_config16(dev, 0x92, ~0x3f, 0x8000 | config->sata_port_map); udelay(2); /* Setup register 98h */ @@ -174,25 +178,16 @@ sir_write(dev, 0x64, 0x883c9001); /* Step 2: SIR 68h[15:0] = 880Ah */ - reg32 = sir_read(dev, 0x68); - reg32 &= 0xffff0000; - reg32 |= 0x880a; - sir_write(dev, 0x68, reg32); + sir_unset_and_set_mask(dev, 0x68, 0xffff, 0x880a); /* Step 3: SIR 60h[3] = 1 */ - reg32 = sir_read(dev, 0x60); - reg32 |= (1 << 3); - sir_write(dev, 0x60, reg32); + sir_unset_and_set_mask(dev, 0x60, 0, 1 << 3); /* Step 4: SIR 60h[0] = 1 */ - reg32 = sir_read(dev, 0x60); - reg32 |= (1 << 0); - sir_write(dev, 0x60, reg32); + sir_unset_and_set_mask(dev, 0x60, 0, 1 << 0); /* Step 5: SIR 60h[1] = 1 */ - reg32 = sir_read(dev, 0x60); - reg32 |= (1 << 1); - sir_write(dev, 0x60, reg32); + sir_unset_and_set_mask(dev, 0x60, 0, 1 << 1); /* Clock Gating */ sir_write(dev, 0x70, 0x3f00bf1f); -- To view, visit https://review.coreboot.org/c/coreboot/+/47030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30ad6ef8ad97ee0a8dc2297fba5bbbfe24f00f1c Gerrit-Change-Number: 47030 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

3 9

Change in coreboot[master]: mb/hp/folio_9480m: Drop `sata_ahci` from devtree
by Angel Pons (Code Review) 11 Nov '20

11 Nov '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47426 ) Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ...................................................................... mb/hp/folio_9480m: Drop `sata_ahci` from devtree Commit 8084b38568 (sb/intel/lynxpoint/sata: Always use AHCI mode) dropped the devtree option, but missed this recently-added mainboard. Change-Id: I6ab3a763c0bcd7431193c48e473639589b1a1e1a Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/hp/folio_9480m/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/47426/1 diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb index bd81d38..140aa84 100644 --- a/src/mainboard/hp/folio_9480m/devicetree.cb +++ b/src/mainboard/hp/folio_9480m/devicetree.cb @@ -36,7 +36,6 @@ register "gen2_dec" = "0x000c0101" register "gen4_dec" = "0x000402e9" register "xhci_default" = "1" - register "sata_ahci" = "1" register "sata_port1_gen3_dtle" = "0x6" # SATA(1), M.2(3) register "sata_port_map" = "0xa" -- To view, visit https://review.coreboot.org/c/coreboot/+/47426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ab3a763c0bcd7431193c48e473639589b1a1e1a Gerrit-Change-Number: 47426 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: WIP: mediatek/mt8192: spm: Add checks
by Nicolas Boichat (Code Review) 11 Nov '20

11 Nov '20

Nicolas Boichat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47283 ) Change subject: WIP: mediatek/mt8192: spm: Add checks ...................................................................... WIP: mediatek/mt8192: spm: Add checks 16-byte alignement is critical for program section, so let's assume it also is for the data section (before we accidentally hit the issue again, which is very unlikely as the 21 bytes of data would need to stride over a 4kb boundary). Also, add assertions to make sure the offsets are valid. BUG=b:172177570 TEST=Asurada boots up to shell, suspend works Signed-off-by: Nicolas Boichat <drinkcat(a)chromium.org> Change-Id: I1d0643368e4fb04e23b0fc1daef98f4b548dabc6 --- M 3rdparty/amd_blobs M 3rdparty/blobs M src/soc/mediatek/mt8192/spm.c 3 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/47283/1 diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index 335f577..539d31a 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit 335f577697f7d27353a84b8a156a67a1dbad255f +Subproject commit 539d31ab9ea89084fa5edf7cc9ac3122786d5454 diff --git a/3rdparty/blobs b/3rdparty/blobs index 0839a7c..5e8dd64 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 0839a7cb848f783b42aa133606c9e109174c4a55 +Subproject commit 5e8dd6456365461e725b53968ef8b82656d86560 diff --git a/src/soc/mediatek/mt8192/spm.c b/src/soc/mediatek/mt8192/spm.c index 4847377..b10268c 100644 --- a/src/soc/mediatek/mt8192/spm.c +++ b/src/soc/mediatek/mt8192/spm.c @@ -430,16 +430,22 @@ 0x1f17618b, 0x61acb7ed, 0x01a8f1a5, 0x1100040c, 0x00a041be, 0x48fc1f1f, 0x01a8f1a5, 0x1100040c, 0xf1a581b8, 0x000c01a8, 0x31be1120, 0x60ee1f1f, 0x01a8d1a5, 0x1140000c, 0x20688314, 0x0600800f, 0x07800000, 0xcfa58049, - 0x67670007, 0x3f20e74b, 0x01000100, 0x01000201, 0x02010201, 0x01000402, + 0x67670007, 0x3f20e74b, /* End of program */ + /* Padding to 16-byte alignment (14 bytes) */ + 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, + 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, + 0x00000000, 0x00000000, + /* Data */ + 0x01000100, 0x01000201, 0x02010201, 0x01000402, 0x02010402, 0x04020402, 0x01000803, 0x02010803, 0x04020803, 0x01001004, 0x02011004, 0x04021004, 0x08031004, 0x01002005, 0x02012005, 0x04022005, 0x08032005, 0x01004006, 0x02014006, 0x04024006, 0x08034006 }; -static struct spm_desc spm_firmware = { +static const struct spm_desc spm_firmware = { .version = "pcm_suspend_v1.45_20201028_mtcmosapi", - .pmem_words = 0x9c2, - .total_words = 0x9d7, + .pmem_words = 0x9d0, + .total_words = 0x9e5, .pmem_start = 0x10000000, .dmem_start = 0x10003800 }; @@ -937,6 +943,11 @@ pmem_start = spm_firmware.pmem_start; dmem_start = spm_firmware.dmem_start; + /* DMA needs 16-byte aligned source data. */ + assert((ptr % 16) == 0); + assert((pmem_words % 16) == 0); + assert(total_words == ARRAY_SIZE(spm_firmware_binary)); + /* tell IM where is PCM code (use slave mode if code existed) */ if (read32(&mtk_spm->md32pcm_dma0_src) != ptr || read32(&mtk_spm->md32pcm_dma0_dst) != pmem_start || -- To view, visit https://review.coreboot.org/c/coreboot/+/47283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d0643368e4fb04e23b0fc1daef98f4b548dabc6 Gerrit-Change-Number: 47283 Gerrit-PatchSet: 1 Gerrit-Owner: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-MessageType: newchange

2 5

Change in coreboot[master]: mt8192/mcupm.c: use load_blob_file to load the blob file
by Yidi Lin (Code Review) 11 Nov '20

11 Nov '20

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46931 ) Change subject: mt8192/mcupm.c: use load_blob_file to load the blob file ...................................................................... mt8192/mcupm.c: use load_blob_file to load the blob file Use load_blob_file to load the blob file. TEST=1. emerge-asurada coreboot chromeos-bootimage; 2. See following log during booting. load_blob_file: Load mcupm.bin in 35 msecs, size 115668 bytes 3. Test suspend/resume by: a. suspend (on DUT): echo mem > /sys/power/stat b. resume (on host): dut-control power_state:on Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com> Change-Id: I871cb3486ddf1346cf1aad16057192aa769918db --- M src/soc/mediatek/mt8192/mcupm.c 1 file changed, 4 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/46931/1 diff --git a/src/soc/mediatek/mt8192/mcupm.c b/src/soc/mediatek/mt8192/mcupm.c index 9391b05..df4111f 100644 --- a/src/soc/mediatek/mt8192/mcupm.c +++ b/src/soc/mediatek/mt8192/mcupm.c @@ -1,31 +1,22 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <arch/barrier.h> -#include <cbfs.h> #include <console/console.h> #include <device/mmio.h> #include <soc/mcupm.h> -#include <string.h> +#include <soc/mtlib_common.h> #define ABNORMALBOOT_REG (0x0C55FAA0) -#define BUF_SIZE (128 * KiB) -static uint8_t mcupm_bin[BUF_SIZE] __aligned(8); +#define MCUPM_BLOB_FILE "mcupm.bin" void mcupm_init(void) { - const char *file_name = "mcupm.bin"; - size_t fw_size = cbfs_boot_load_file(file_name, - mcupm_bin, - sizeof(mcupm_bin), - CBFS_TYPE_RAW); - - if (fw_size == 0) - die("MCUPM file :mcupm.bin not found."); + if (load_blob_file(MCUPM_BLOB_FILE, MCUPM_SRAM_BASE)) + die("MCUPM file :%s not found.", MCUPM_BLOB_FILE); write32(&mt8192_mcupm->sw_rstn, 0x0); /* Clear abnormal boot register */ write32((void *)ABNORMALBOOT_REG, 0x0); - memcpy((void *)MCUPM_SRAM_BASE, mcupm_bin, fw_size); /* Memory barrier to ensure that all fw code is loaded * before we release the reset pin. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/46931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I871cb3486ddf1346cf1aad16057192aa769918db Gerrit-Change-Number: 46931 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: DO-NOT-SUBMIT: ignore changes under 3rdparty folder
by Yidi Lin (Code Review) 11 Nov '20

11 Nov '20

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46412 ) Change subject: DO-NOT-SUBMIT: ignore changes under 3rdparty folder ...................................................................... DO-NOT-SUBMIT: ignore changes under 3rdparty folder Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com> Change-Id: I1651e27f2875647d9cd1b50c6520c7c8c74f2488 --- M .gitmodules M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/qc_blobs 5 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/46412/1 diff --git a/.gitmodules b/.gitmodules index 4350a2c..626bf52 100644 --- a/.gitmodules +++ b/.gitmodules @@ -2,7 +2,7 @@ path = 3rdparty/blobs url = ../blobs.git update = none - ignore = dirty + ignore = all [submodule "util/nvidia-cbootimage"] path = util/nvidia/cbootimage url = ../nvidia-cbootimage.git @@ -25,7 +25,7 @@ path = 3rdparty/fsp url = ../fsp.git update = none - ignore = dirty + ignore = all [submodule "opensbi"] path = 3rdparty/opensbi url = ../opensbi.git @@ -33,7 +33,7 @@ path = 3rdparty/intel-microcode url = ../intel-microcode.git update = none - ignore = dirty + ignore = all [submodule "3rdparty/ffs"] path = 3rdparty/ffs url = ../ffs.git @@ -41,7 +41,7 @@ path = 3rdparty/amd_blobs url = ../amd_blobs update = none - ignore = dirty + ignore = all [submodule "3rdparty/cmocka"] path = 3rdparty/cmocka url = ../cmocka.git @@ -50,7 +50,7 @@ path = 3rdparty/qc_blobs url = ../qc_blobs.git update = none - ignore = dirty + ignore = all [submodule "3rdparty/intel-sec-tools"] path = 3rdparty/intel-sec-tools url = ../9esec-security-tooling.git diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index e393a88..335f577 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit e393a885c89f8ee3f05242a9e42578c60931b49d +Subproject commit 335f577697f7d27353a84b8a156a67a1dbad255f diff --git a/3rdparty/blobs b/3rdparty/blobs index 1aff9c3..96ae35c 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 1aff9c32eb15fc0e9da2f389f9b77e06d6fd3a21 +Subproject commit 96ae35c462d903d6940d982e61bea697103b7af6 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 0e4288f..ee319ae 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 0e4288f81f806620c65f70ee2bcf94b69d574096 +Subproject commit ee319ae7bc59e88b60142f40a9ec1b46656de4db diff --git a/3rdparty/qc_blobs b/3rdparty/qc_blobs index 6b7fe49..11b212c 160000 --- a/3rdparty/qc_blobs +++ b/3rdparty/qc_blobs @@ -1 +1 @@ -Subproject commit 6b7fe498eb782b8f9758f28dd53bb0697be0d0b0 +Subproject commit 11b212c273b930885d1bee0b00a223a73628c852 -- To view, visit https://review.coreboot.org/c/coreboot/+/46412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1651e27f2875647d9cd1b50c6520c7c8c74f2488 Gerrit-Change-Number: 46412 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-MessageType: newchange

2 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020