Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48178 )
Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR
......................................................................
cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR
Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/cpu/x86/64bit/exit32.inc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48178/1
diff --git a/src/cpu/x86/64bit/exit32.inc b/src/cpu/x86/64bit/exit32.inc
index 6722cfd..d35eb13 100644
--- a/src/cpu/x86/64bit/exit32.inc
+++ b/src/cpu/x86/64bit/exit32.inc
@@ -24,8 +24,9 @@
drop_longmode:
/* Ensure cache is clean. */
+#if defined(__RAMSTAGE__)
wbinvd
-
+#endif
/* Set 32-bit code segment and ss */
mov $CODE_SEG, %rcx
/* SetCodeSelector32 will drop us to protected mode on return */
--
To view, visit https://review.coreboot.org/c/coreboot/+/48178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91
Gerrit-Change-Number: 48178
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44039 )
Change subject: [WIP] mb/google/volteer: Use device aliases
......................................................................
[WIP] mb/google/volteer: Use device aliases
Use the device aliases provided by tigerlake chipset.cb instead of
the raw pci device+function. Take advantage of the default states
in chipset.cb and only list the devices that are enabled for volteer.
Change-Id: I5620004afd7fa4d50389f32dd79148960a2b2662
Signed-off-by: Duncan Laurie <dlaurie(a)google.com>
---
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
M src/mainboard/google/volteer/variants/volteer/overridetree.cb
2 files changed, 36 insertions(+), 91 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/44039/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 53bbe5a..80e2041 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -47,7 +47,6 @@
register "HeciEnabled" = "1"
# FSP configuration
- register "SaGv" = "SaGv_Enabled"
register "SmbusEnable" = "0"
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0
@@ -286,10 +285,8 @@
}"
device domain 0 on
- #From EDS(575683)
- device pci 00.0 on end # Host Bridge 0x9A14:U/0x9A12:Y
- device pci 02.0 on end # Graphics
- device pci 04.0 on
+ device ref igpu on end
+ device ref dptf on
# Default DPTF Policy for all Volteer boards if not overridden
chip drivers/intel/dptf
## Active Policy
@@ -379,81 +376,35 @@
device generic 0 on end
end
end # DPTF 0x9A03
- device pci 05.0 off end # IPU 0x9A19
- device pci 06.0 off end # PEG60 0x9A09
- device pci 07.0 on end # TBT_PCIe0 0x9A23
- device pci 07.1 on end # TBT_PCIe1 0x9A25
- device pci 07.2 off end # TBT_PCIe2 0x9A27
- device pci 07.3 off end # TBT_PCIe3 0x9A29
- device pci 08.0 on end # GNA 0x9A11
- device pci 09.0 off end # NPK 0x9A33
- device pci 0a.0 off end # Crash-log SRAM 0x9A0D
- device pci 0d.0 on end # USB xHCI 0x9A13
- device pci 0d.1 off end # USB xDCI (OTG) 0x9A15
- device pci 0d.2 on end # TBT DMA0 0x9A1B
- device pci 0d.3 off end # TBT DMA1 0x9A1D
- device pci 0e.0 off end # VMD 0x9A0B
-
- # From PCH EDS(576591)
- device pci 10.2 on end # CNVi: BT 0xA0F5 - A0F7
- device pci 10.6 off end # THC0 0xA0D0
- device pci 10.7 off end # THC1 0xA0D1
-
- device pci 12.0 off end # SensorHUB 0xA0FC
- device pci 12.6 off end # GSPI2 0x34FB
-
- device pci 13.0 off end # GSPI3 0xA0FD
-
- device pci 14.0 on end # USB3.1 xHCI 0xA0ED
- device pci 14.1 off end # USB3.1 xDCI 0xA0EE
- device pci 14.2 on end # Shared RAM 0xA0EF
+ device ref tbt_pcie_rp0 on end
+ device ref tbt_pcie_rp1 on end
+ device ref gna on end
+ device ref north_xhci on end
+ device ref tbt_dma0 on end
+ device ref cnvi_bt on end
+ device ref south_xhci on end
+ device ref shared_ram on end
chip drivers/intel/wifi
register "wake" = "GPE0_PME_B0"
- device pci 14.3 on end # CNVi: WiFi 0xA0F0 - A0F3
+ device ref cnvi_wifi on end
end
- device pci 15.0 on end # I2C #0 0xA0E8
- device pci 15.1 on end # I2C1 0xA0E9
- device pci 15.2 on end # I2C2 0xA0EA
- device pci 15.3 on end # I2C3 0xA0EB
-
- device pci 16.0 on end # HECI1 0xA0E0
- device pci 16.1 off end # HECI2 0xA0E1
- device pci 16.2 off end # CSME 0xA0E2
- device pci 16.3 off end # CSME 0xA0E3
- device pci 16.4 off end # HECI3 0xA0E4
- device pci 16.5 off end # HECI4 0xA0E5
-
- device pci 17.0 on end # SATA 0xA0D3
-
- device pci 19.0 on end # I2C4 0xA0C5
- device pci 19.1 on end # I2C5 0xA0C6
- device pci 19.2 off end # UART2 0xA0C7
-
- device pci 1c.0 on end # RP1 0xA0B8
- device pci 1c.1 off end # RP2 0xA0B9
- device pci 1c.2 off end # RP3 0xA0BA
- device pci 1c.3 off end # RP4 0xA0BB
- device pci 1c.4 off end # RP5 0xA0BC
- device pci 1c.5 off end # WWAN RP6 0xA0BD
- device pci 1c.6 on end # RP7 0xA0BE
- device pci 1c.7 on end # SD Card RP8 0xA0BF
-
- device pci 1d.0 on end # RP9 0xA0B0
- device pci 1d.1 off end # RP10 0xA0B1
- device pci 1d.2 on end # RP11 0xA0B2
- device pci 1d.3 off end # RP12 0xA0B3
-
- device pci 1e.0 on end # UART0 0xA0A8
- device pci 1e.1 off end # UART1 0xA0A9
- device pci 1e.2 on
+ device ref heci1 on end
+ device ref sata on end
+ device ref pcie_rp1 on end
+ device ref pcie_rp7 on end
+ device ref pcie_rp8 on end
+ device ref pcie_rp9 on end
+ device ref pcie_rp11 on end
+ device ref uart0 on end
+ device ref gspi0 on
chip drivers/spi/acpi
register "hid" = "ACPI_DT_NAMESPACE_HID"
register "compat_string" = ""google,cr50""
register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C21_IRQ)"
device spi 0 on end
end
- end # GSPI0 0xA0AA
- device pci 1e.3 on
+ end
+ device ref gspi1 on
chip drivers/spi/acpi
register "name" = ""CRFP""
register "hid" = "ACPI_DT_NAMESPACE_HID"
@@ -462,18 +413,12 @@
register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW_WAKE(GPP_C20)"
device spi 0 on end
end # FPMCU
- end # GSPI1 0xA0AB
- device pci 1f.0 on
+ end
+ device ref pch_espi on
chip ec/google/chromeec
device pnp 0c09.0 on end
end
- end # eSPI 0xA080 - A09F
- device pci 1f.1 off end # P2SB 0xA0A0
- device pci 1f.2 hidden end # PMC 0xA0A1
- device pci 1f.3 on end # Intel HD audio 0xA0C8-A0CF
- device pci 1f.4 off end # SMBus 0xA0A3
- device pci 1f.5 on end # SPI 0xA0A4
- device pci 1f.6 off end # GbE 0x15E1/0x15E2
- device pci 1f.7 off end # TH 0xA0A6
+ end
+ device ref hda on end
end
end
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
index c7350cb..8c95956 100644
--- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb
@@ -44,7 +44,7 @@
},
}"
device domain 0 on
- device pci 15.0 on
+ device ref i2c0 on
chip drivers/i2c/generic
register "hid" = ""10EC5682""
register "name" = ""RT58""
@@ -81,7 +81,7 @@
end
end
end
- device pci 15.1 on
+ device ref i2c1 on
chip drivers/i2c/hid
register "generic.hid" = ""GDIX0000""
register "generic.desc" = ""Goodix Touchscreen""
@@ -124,8 +124,8 @@
register "key.label" = ""pen_eject""
device generic 0 on end
end
- end # I2C1 0xA0E9
- device pci 15.2 on
+ end
+ device ref i2c2 on
chip drivers/i2c/sx9310
register "desc" = ""SAR0 Proximity Sensor""
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)"
@@ -156,8 +156,8 @@
register "reg_sar_ctrl2" = "0x3c"
device i2c 28 on end
end
- end # I2C2 0xA0EA
- device pci 19.1 on
+ end
+ device ref i2c5 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
@@ -166,8 +166,8 @@
register "probed" = "1"
device i2c 15 on end
end
- end # I2C5 0xA0C6
- device pci 1f.3 on
+ end
+ device ref hda on
chip drivers/generic/max98357a
register "hid" = ""MX98357A""
register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)"
@@ -197,7 +197,7 @@
end
end
end
- device pci 1f.2 hidden
+ device ref pmc hidden
# The pmc_mux chip driver is a placeholder for the
# PMC.MUX device in the ACPI hierarchy.
chip drivers/intel/pmc_mux
@@ -230,6 +230,6 @@
end
end
end
- end # PMC
+ end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/44039
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5620004afd7fa4d50389f32dd79148960a2b2662
Gerrit-Change-Number: 44039
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-MessageType: newchange
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48190 )
Change subject: mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
......................................................................
mb/google/deltaur: Restrict RW_DIAG to lower 16MiB
This change restricts RW_DIAG region to lower 16MiB to ensure that the
extended BIOS checker for FMAP does not complain about 16MiB boundary
crossing.
I haven't updated any other regions to occupy the newly freed space
but it is fine since this board is dead and should be dropped from
coreboot soon.
Signed-off-by: Furquan Shaikh <furquan(a)google.com>
Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3
---
M src/mainboard/google/deltaur/chromeos.fmd
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/48190/1
diff --git a/src/mainboard/google/deltaur/chromeos.fmd b/src/mainboard/google/deltaur/chromeos.fmd
index bbec112..a84a448 100644
--- a/src/mainboard/google/deltaur/chromeos.fmd
+++ b/src/mainboard/google/deltaur/chromeos.fmd
@@ -6,9 +6,9 @@
SI_PDR(PRESERVE)@0x602000 0x4000
}
SI_BIOS@0x606000 0x19fa000 {
- RW_DIAG@0x0 0x10ca000 {
- RW_LEGACY(CBFS)@0x0 0x10ba000
- DIAG_NVRAM@0x10ba000 0x10000
+ RW_DIAG@0x0 0x9fa000 {
+ RW_LEGACY(CBFS)@0x0 0x9ea000
+ DIAG_NVRAM@0x9ea000 0x10000
}
RW_SECTION_A@0x10ca000 0x280000 {
VBLOCK_A@0x0 0x10000
--
To view, visit https://review.coreboot.org/c/coreboot/+/48190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19ab204fbe3e020e42baf68bfa350dcff32066a3
Gerrit-Change-Number: 48190
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: newchange