Change in coreboot[master]: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Rudolph (Code Review)

30 Nov 2020 30 Nov '20

8:06 p.m.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR

Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/64bit/exit32.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48178/1

diff --git a/src/cpu/x86/64bit/exit32.inc b/src/cpu/x86/64bit/exit32.inc index 6722cfd..d35eb13 100644 --- a/src/cpu/x86/64bit/exit32.inc +++ b/src/cpu/x86/64bit/exit32.inc @@ -24,8 +24,9 @@

drop_longmode: /* Ensure cache is clean. */ +#if defined(__RAMSTAGE__) wbinvd - +#endif /* Set 32-bit code segment and ss */ mov $CODE_SEG, %rcx /* SetCodeSelector32 will drop us to protected mode on return */

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Arthur Heymans (Code Review)

1 Dec 1 Dec

5:30 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48178/4/src/cpu/x86/64bit/exit32.in... File src/cpu/x86/64bit/exit32.inc:

https://review.coreboot.org/c/coreboot/+/48178/4/src/cpu/x86/64bit/exit32.in... PS4, Line 27: #if defined(__RAMSTAGE__) maybe !ENV_ROMSTAGE_OR_BEFORE?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Tue, 01 Dec 2020 16:30:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

2 Dec 2 Dec

7:14 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48178

to look at the new patch set (#5).

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR

Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/64bit/exit32.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48178/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

3 Dec 3 Dec

10:36 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48178/4/src/cpu/x86/64bit/exit32.in... File src/cpu/x86/64bit/exit32.inc:

https://review.coreboot.org/c/coreboot/+/48178/4/src/cpu/x86/64bit/exit32.in... PS4, Line 27: #if defined(__RAMSTAGE__)

...

maybe !ENV_ROMSTAGE_OR_BEFORE?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Dec 2020 09:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

12:05 p.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48178

to look at the new patch set (#7).

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR

Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/64bit/exit32.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48178/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Arthur Heymans (Code Review)

12:12 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48178/7/src/cpu/x86/64bit/exit32.in... File src/cpu/x86/64bit/exit32.inc:

https://review.coreboot.org/c/coreboot/+/48178/7/src/cpu/x86/64bit/exit32.in... PS7, Line 26: ENV_ROMSTAGE_OR_BEFORE sry: !ENV_CACHE_AS_RAM is even better.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Dec 2020 11:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

8 Dec 8 Dec

9:45 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48178

to look at the new patch set (#8).

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR

Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/64bit/exit32.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48178/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Arthur Heymans (Code Review)

10:06 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Dec 2020 09:06:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

10:11 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48178/7/src/cpu/x86/64bit/exit32.in... File src/cpu/x86/64bit/exit32.inc:

https://review.coreboot.org/c/coreboot/+/48178/7/src/cpu/x86/64bit/exit32.in... PS7, Line 26: ENV_ROMSTAGE_OR_BEFORE

...

sry: !ENV_CACHE_AS_RAM is even better.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 08 Dec 2020 09:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

10 Dec 10 Dec

8:30 a.m.

Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48178 )

Change subject: cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR ......................................................................

cpu/x86/64bit/exit32.inc: Don't invalidate cache in CAR

Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48178 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/64bit/exit32.inc 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved

diff --git a/src/cpu/x86/64bit/exit32.inc b/src/cpu/x86/64bit/exit32.inc index 6722cfd..91cccb5 100644 --- a/src/cpu/x86/64bit/exit32.inc +++ b/src/cpu/x86/64bit/exit32.inc @@ -23,9 +23,10 @@ #endif

drop_longmode: +#if !ENV_CACHE_AS_RAM /* Ensure cache is clean. */ wbinvd - +#endif /* Set 32-bit code segment and ss */ mov $CODE_SEG, %rcx /* SetCodeSelector32 will drop us to protected mode on return */

-- To view, visit https://review.coreboot.org/c/coreboot/+/48178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a4e988d38b548e1c88ffcc5f5ada2e91ff6ba91 Gerrit-Change-Number: 48178 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1241

days inactive

1251

days old

coreboot-gerrit@coreboot.org

9 comments

2 participants

tags (0)

participants (2)

Arthur Heymans (Code Review)
Patrick Rudolph (Code Review)