Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48454 )
Change subject: arch/x86/smbios.c: Fix compilation on x86_64 ......................................................................
arch/x86/smbios.c: Fix compilation on x86_64
Change-Id: I07780f9a6fa577d7b6bb63884071a7e1ce1bdbfa Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/smbios.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/48454/1
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index aabeb10..aaf989d 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -414,7 +414,7 @@ #if CONFIG(CHROMEOS) && CONFIG(HAVE_ACPI_TABLES) u32 version_offset = (u32)smbios_string_table_len(t->eos); /* SMBIOS offsets start at 1 rather than 0 */ - chromeos_get_chromeos_acpi()->vbt10 = (u32)t->eos + (version_offset - 1); + chromeos_get_chromeos_acpi()->vbt10 = (uintptr_t)t->eos + (version_offset - 1); #endif t->bios_version = smbios_add_string(t->eos, get_bios_version()); uint32_t rom_size = CONFIG_ROM_SIZE;
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48454 )
Change subject: arch/x86/smbios.c: Fix compilation on x86_64 ......................................................................
Patch Set 1: Code-Review+2
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48454 )
Change subject: arch/x86/smbios.c: Fix compilation on x86_64 ......................................................................
arch/x86/smbios.c: Fix compilation on x86_64
Change-Id: I07780f9a6fa577d7b6bb63884071a7e1ce1bdbfa Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48454 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/smbios.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index aabeb10..aaf989d 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -414,7 +414,7 @@ #if CONFIG(CHROMEOS) && CONFIG(HAVE_ACPI_TABLES) u32 version_offset = (u32)smbios_string_table_len(t->eos); /* SMBIOS offsets start at 1 rather than 0 */ - chromeos_get_chromeos_acpi()->vbt10 = (u32)t->eos + (version_offset - 1); + chromeos_get_chromeos_acpi()->vbt10 = (uintptr_t)t->eos + (version_offset - 1); #endif t->bios_version = smbios_add_string(t->eos, get_bios_version()); uint32_t rom_size = CONFIG_ROM_SIZE;
-
Arthur Heymans (Code Review) -
Patrick Rudolph (Code Review)