Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20237 )
Change subject: superiotool: add basic support for SCH5545
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/20237/4/util/superiotool/smsc.c
File util/superiotool/smsc.c:
https://review.coreboot.org/c/coreboot/+/20237/4/util/superiotool/smsc.c@10…
PS4, Line 1005:
> unneeded tab
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/20237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81f3f68690d2000a4fa8a1e703c01f54ebbce953
Gerrit-Change-Number: 20237
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 28 Sep 2019 17:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Hello Felix Held, Christoph Pomaska, Paul Menzel, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/20237
to look at the new patch set (#5).
Change subject: superiotool: add basic support for SCH5545
......................................................................
superiotool: add basic support for SCH5545
Based on the SCH5627 datasheet which is similiar
SCH5545 id 0xc4, SCH5627 id 0xc6.
Change-Id: I81f3f68690d2000a4fa8a1e703c01f54ebbce953
Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu>
---
M util/superiotool/smsc.c
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/20237/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/20237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81f3f68690d2000a4fa8a1e703c01f54ebbce953
Gerrit-Change-Number: 20237
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20237 )
Change subject: superiotool: add basic support for SCH5545
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/20237/4/util/superiotool/smsc.c
File util/superiotool/smsc.c:
https://review.coreboot.org/c/coreboot/+/20237/4/util/superiotool/smsc.c@10…
PS4, Line 1005:
unneeded tab
--
To view, visit https://review.coreboot.org/c/coreboot/+/20237
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81f3f68690d2000a4fa8a1e703c01f54ebbce953
Gerrit-Change-Number: 20237
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Christoph Pomaska <github(a)aufmachen.jetzt>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 28 Sep 2019 16:09:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment