coreboot-gerrit June 2019

coreboot-gerrit@coreboot.org

1 participants
1454 discussions

Change in ...coreboot[master]: mb/lenovo/x201: Remove unneeded includes
by Nico Huber (Code Review) 19 Jun '19

19 Jun '19

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30217 ) Change subject: mb/lenovo/x201: Remove unneeded includes ...................................................................... mb/lenovo/x201: Remove unneeded includes Tested: still builds fine. Change-Id: I1ca4e42bd75a3e84afe8b30a60f02058b590416f Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/30217 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/lenovo/x201/acpi_tables.c M src/mainboard/lenovo/x201/mainboard.c 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Arthur Heymans: Looks good to me, approved diff --git a/src/mainboard/lenovo/x201/acpi_tables.c b/src/mainboard/lenovo/x201/acpi_tables.c index 82991b2..6fd47d7 100644 --- a/src/mainboard/lenovo/x201/acpi_tables.c +++ b/src/mainboard/lenovo/x201/acpi_tables.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */ -#include <stdint.h> #include <southbridge/intel/ibexpeak/nvs.h> #include "thermal.h" diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c index b8129ad..0e20afe 100644 --- a/src/mainboard/lenovo/x201/mainboard.c +++ b/src/mainboard/lenovo/x201/mainboard.c @@ -23,11 +23,10 @@ #include <ec/acpi/ec.h> #include <northbridge/intel/nehalem/nehalem.h> #include <southbridge/intel/bd82x6x/pch.h> - #include "dock.h" #include <drivers/intel/gma/int15.h> #include <cpu/x86/lapic.h> -#include <device/pci.h> +#include <device/pci_ops.h> #include <drivers/lenovo/lenovo.h> #include <arch/acpigen.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/30217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ca4e42bd75a3e84afe8b30a60f02058b590416f Gerrit-Change-Number: 30217 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: mb/lenovo/x201: Remove unneeded includes
by HAOUAS Elyes (Code Review) 19 Jun '19

19 Jun '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30217 ) Change subject: mb/lenovo/x201: Remove unneeded includes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ca4e42bd75a3e84afe8b30a60f02058b590416f Gerrit-Change-Number: 30217 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 12:06:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: xcompile: Fix harmless typo
by Nico Huber (Code Review) 19 Jun '19

19 Jun '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33580 Change subject: xcompile: Fix harmless typo ...................................................................... xcompile: Fix harmless typo As CFLAGS_GCC and CFLAGS_CLANG are still the same at this point, this just removes some duplicate flags. Change-Id: I532e5fa146891b70e4c1949c614b280055524593 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/33580/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 052b88f..91b0c2b 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -162,7 +162,7 @@ "elf32-i386" ) LDFLAGS="$LDFLAGS -melf_i386" CFLAGS_GCC="$CFLAGS_GCC -Wl,-b,elf32-i386 -Wl,-melf_i386" - CFLAGS_CLANG="$CFLAGS_GCC -Wl,-b,elf32-i386 -Wl,-melf_i386" + CFLAGS_CLANG="$CFLAGS_CLANG -Wl,-b,elf32-i386 -Wl,-melf_i386" ;; esac -- To view, visit https://review.coreboot.org/c/coreboot/+/33580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I532e5fa146891b70e4c1949c614b280055524593 Gerrit-Change-Number: 33580 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

5 6

Change in ...coreboot[master]: src/arch/x86/smbios: Change SMBIOS Version to 2.8
by Christian Walter (Code Review) 19 Jun '19

19 Jun '19

Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33564 Change subject: src/arch/x86/smbios: Change SMBIOS Version to 2.8 ...................................................................... src/arch/x86/smbios: Change SMBIOS Version to 2.8 Change the SMBIOS Version from 2.7 to 2.8. Necessary changes were already pushed in https://review.coreboot.org/c/coreboot/+/33031 Change-Id: I237cdee7d43e814397b958e4cf941bf58949088d Signed-off-by: Christian Walter <christian.walter(a)9elements.com> --- M src/arch/x86/smbios.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/33564/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 54c2b09..7865c7e 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -1193,7 +1193,7 @@ memcpy(se->anchor, "_SM_", 4); se->length = sizeof(struct smbios_entry); se->major_version = 2; - se->minor_version = 7; + se->minor_version = 8; se->max_struct_size = max_struct_size; se->struct_count = handle; memcpy(se->intermediate_anchor_string, "_DMI_", 5); -- To view, visit https://review.coreboot.org/c/coreboot/+/33564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I237cdee7d43e814397b958e4cf941bf58949088d Gerrit-Change-Number: 33564 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newchange

3 3

Change in ...coreboot[master]: acpi: Add SPMI table
by Patrick Rudolph (Code Review) 19 Jun '19

19 Jun '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33487 Change subject: acpi: Add SPMI table ...................................................................... acpi: Add SPMI table Add the SPMI table as defined in the IPMI spec v2. Change-Id: Idff5134ce4c124f7e76acb0080da404b0c0dfffe Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/arch/x86/acpi.c M src/arch/x86/include/arch/acpi.h 2 files changed, 93 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/33487/1 diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index bf9813c..e9ba1ec 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -772,6 +772,55 @@ header->checksum = acpi_checksum((void *)vfct, header->length); } +void acpi_create_ipmi(struct device *device, + struct acpi_spmi *spmi, + const u16 ipmi_revision, + const acpi_addr_t *addr, + const enum acpi_ipmi_interface_type type, + const s8 gpe_interrupt, + const u32 apic_interrupt) +{ + acpi_header_t *header = &(spmi->header); + memset((void *)spmi, 0, sizeof(struct acpi_spmi)); + + /* Fill out header fields. */ + memcpy(header->signature, "SPMI", 4); + memcpy(header->oem_id, OEM_ID, 6); + memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); + memcpy(header->asl_compiler_id, ASLC, 4); + + header->asl_compiler_revision = asl_revision; + header->length = sizeof(struct acpi_spmi); + header->revision = get_acpi_table_revision(SPMI); + + spmi->reserved = 1; + + if (device->path.type == DEVICE_PATH_PCI) { + spmi->pci_device_flag = 1; + spmi->pci_bus = device->bus->secondary; + spmi->pci_device = device->path.pci.devfn >> 3; + spmi->pci_function = device->path.pci.devfn & 0x7; + } + + spmi->base_address = *addr; + spmi->specification_revision = ipmi_revision; + + spmi->interface_type = type; + + if (gpe_interrupt >= 0 && gpe_interrupt < 32) { + spmi->gpe = gpe_interrupt; + spmi->interrupt_type |= 1; + } + if (apic_interrupt > 0) { + spmi->global_system_interrupt = apic_interrupt; + spmi->interrupt_type |= 2; + } + + /* (Re)calculate length and checksum. */ + header->length = sizeof(struct acpi_spmi); + header->checksum = acpi_checksum((void *)spmi, header->length); +} + void acpi_create_ivrs(acpi_ivrs_t *ivrs, unsigned long (*acpi_fill_ivrs)(acpi_ivrs_t *ivrs_struct, unsigned long current)) @@ -1490,6 +1539,8 @@ return 1; case SLIT: /* ACPI 2.0 upto 6.3: 1 */ return 1; + case SPMI: /* IMPI 2.0 */ + return 5; case HPET: /* Currently 1. Table added in ACPI 2.0. */ return 1; case VFCT: /* ACPI 2.0/3.0/4.0: 1 */ diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index dbf46a9..a864071 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -82,7 +82,7 @@ BERT, DBG2, DMAR, DSDT, FACS, FADT, HEST, HPET, IVRS, MADT, MCFG, RSDP, RSDT, SLIT, SRAT, SSDT, TCPA, TPM2, XSDT, ECDT, /* Additional proprietary tables used by coreboot */ - VFCT, NHLT + VFCT, NHLT, SPMI }; /* RSDP (Root System Description Pointer) */ @@ -782,6 +782,39 @@ UPC_TYPE_HUB }; +enum acpi_ipmi_interface_type { + IPMI_INTERFACE_RESERVED, + IPMI_INTERFACE_KCS, + IPMI_INTERFACE_SMIC, + IPMI_INTERFACE_BT, + IPMI_INTERFACE_SSIF, +}; + +/* ACPI IPMI 2.0 */ +struct acpi_spmi { + struct acpi_table_header header; + u8 interface_type; + u8 reserved; + u16 specification_revision; + u8 interrupt_type; + u8 gpe; + u8 reserved2; + u8 pci_device_flag; + + u32 global_system_interrupt; + acpi_addr_t base_address; + union { + struct { + u8 pci_segment_group; + u8 pci_bus; + u8 pci_device; + u8 pci_function; + }; + u8 uid[4]; + }; + u8 reserved3; +} __packed ; + unsigned long fw_cfg_acpi_tables(unsigned long start); /* These are implemented by the target port or north/southbridge. */ @@ -834,6 +867,14 @@ struct acpi_vfct *vfct_struct, unsigned long current)); +void acpi_create_ipmi(struct device *device, + struct acpi_spmi *spmi, + const u16 ipmi_revision, + const acpi_addr_t *addr, + const enum acpi_ipmi_interface_type type, + const s8 gpe_interrupt, + const u32 apic_interrupt); + void acpi_create_ivrs(acpi_ivrs_t *ivrs, unsigned long (*acpi_fill_ivrs)(acpi_ivrs_t *ivrs_struct, unsigned long current)); -- To view, visit https://review.coreboot.org/c/coreboot/+/33487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idff5134ce4c124f7e76acb0080da404b0c0dfffe Gerrit-Change-Number: 33487 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

5 13

Change in ...coreboot[master]: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec
by John Su (Code Review) 19 Jun '19

19 Jun '19

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33384 Change subject: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec ...................................................................... mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec After adjustment on Hatch Touch Pad CLK: 383.4 KHz BUG=b:134911522 BRANCH=master TEST=emerge-hatch coreboot chromeos-bootimage measure by scope with hatch. Change-Id: Iee2b692c268381af267b70e92a577ac89ce41cbb Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33384/1 diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 562bb8b..0d434f3 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -35,6 +35,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, -- To view, visit https://review.coreboot.org/c/coreboot/+/33384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee2b692c268381af267b70e92a577ac89ce41cbb Gerrit-Change-Number: 33384 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

4 8

Change in ...coreboot[master]: drivers/i2c: Add device info to cbmem log
by EricR Lai (Code Review) 18 Jun '19

18 Jun '19

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33432 Change subject: drivers/i2c: Add device info to cbmem log ...................................................................... drivers/i2c: Add device info to cbmem log Add some device I2C info to cbmem log BUG=none BRANCH=none TEST=Boot up and check cbmem -c can find the SAR i2c info Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4 --- M src/drivers/i2c/sx9310/sx9310.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33432/1 diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index aafd7c7..8157874 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -15,6 +15,7 @@ #include <arch/acpi_device.h> #include <arch/acpigen.h> +#include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> #include <device/path.h> @@ -74,6 +75,9 @@ acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ + + printk(BIOS_INFO, "%s: %s at %s\n", acpi_device_path(dev), + config->desc ? : dev->chip_ops->name, dev_path(dev)); } #undef REGISTER -- To view, visit https://review.coreboot.org/c/coreboot/+/33432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia143932bb660ed2c2cea76310f11ede2b727adf4 Gerrit-Change-Number: 33432 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

2 11

Change in ...coreboot[master]: reading
by Thomas Heijligen (Code Review) 18 Jun '19

18 Jun '19

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32819 ) Change subject: reading ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/32819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23a1c6864ed2b1bf7d239202eea354229a0d98ab Gerrit-Change-Number: 32819 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: working
by Thomas Heijligen (Code Review) 18 Jun '19

18 Jun '19

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32818 ) Change subject: working ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/32818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id440ccf1e280f855bf63de9c612a1566a6d5d52c Gerrit-Change-Number: 32818 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: not_working
by Thomas Heijligen (Code Review) 18 Jun '19

18 Jun '19

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32817 ) Change subject: not_working ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/32817 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If51465f3f74b249b8440011c7c2955c51b1771f5 Gerrit-Change-Number: 32817 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2019