HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31314 )
Change subject: arch/ppc64: Make PPC64 specific options depend on ARCH_PPC64
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/31314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70b64e49e1ce07b8f30d9bbc493272bdfb3bb0bf
Gerrit-Change-Number: 31314
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 24 Jun 2019 06:55:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33701
Change subject: mb/google/rambi: Remove #include <stdlib.h> when not used
......................................................................
mb/google/rambi: Remove #include <stdlib.h> when not used
Change-Id: I5792b251fa60f37184eddbf6908910ea56896319
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/google/rambi/variants/banjo/gpio.c
M src/mainboard/google/rambi/variants/candy/gpio.c
M src/mainboard/google/rambi/variants/clapper/gpio.c
M src/mainboard/google/rambi/variants/enguarde/gpio.c
M src/mainboard/google/rambi/variants/glimmer/gpio.c
M src/mainboard/google/rambi/variants/gnawty/gpio.c
M src/mainboard/google/rambi/variants/heli/gpio.c
M src/mainboard/google/rambi/variants/kip/gpio.c
M src/mainboard/google/rambi/variants/ninja/gpio.c
M src/mainboard/google/rambi/variants/orco/gpio.c
M src/mainboard/google/rambi/variants/quawks/gpio.c
M src/mainboard/google/rambi/variants/rambi/gpio.c
M src/mainboard/google/rambi/variants/squawks/gpio.c
M src/mainboard/google/rambi/variants/sumo/gpio.c
M src/mainboard/google/rambi/variants/swanky/gpio.c
M src/mainboard/google/rambi/variants/winky/gpio.c
16 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33701/1
diff --git a/src/mainboard/google/rambi/variants/banjo/gpio.c b/src/mainboard/google/rambi/variants/banjo/gpio.c
index bfb2c9a..e22c8db 100644
--- a/src/mainboard/google/rambi/variants/banjo/gpio.c
+++ b/src/mainboard/google/rambi/variants/banjo/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/candy/gpio.c b/src/mainboard/google/rambi/variants/candy/gpio.c
index 3cbfbaf..61050e5 100644
--- a/src/mainboard/google/rambi/variants/candy/gpio.c
+++ b/src/mainboard/google/rambi/variants/candy/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/clapper/gpio.c b/src/mainboard/google/rambi/variants/clapper/gpio.c
index 385b406..17303c3 100644
--- a/src/mainboard/google/rambi/variants/clapper/gpio.c
+++ b/src/mainboard/google/rambi/variants/clapper/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/enguarde/gpio.c b/src/mainboard/google/rambi/variants/enguarde/gpio.c
index 2802aa6..784ed23 100644
--- a/src/mainboard/google/rambi/variants/enguarde/gpio.c
+++ b/src/mainboard/google/rambi/variants/enguarde/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/glimmer/gpio.c b/src/mainboard/google/rambi/variants/glimmer/gpio.c
index 8cfe90e..504d64a 100644
--- a/src/mainboard/google/rambi/variants/glimmer/gpio.c
+++ b/src/mainboard/google/rambi/variants/glimmer/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/gnawty/gpio.c b/src/mainboard/google/rambi/variants/gnawty/gpio.c
index e79dc5a..7e2361c 100644
--- a/src/mainboard/google/rambi/variants/gnawty/gpio.c
+++ b/src/mainboard/google/rambi/variants/gnawty/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/heli/gpio.c b/src/mainboard/google/rambi/variants/heli/gpio.c
index 2a61c55..bcb1430 100644
--- a/src/mainboard/google/rambi/variants/heli/gpio.c
+++ b/src/mainboard/google/rambi/variants/heli/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/kip/gpio.c b/src/mainboard/google/rambi/variants/kip/gpio.c
index 3d79d37..56942bd 100644
--- a/src/mainboard/google/rambi/variants/kip/gpio.c
+++ b/src/mainboard/google/rambi/variants/kip/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/ninja/gpio.c b/src/mainboard/google/rambi/variants/ninja/gpio.c
index 85d565e..2d8285c 100644
--- a/src/mainboard/google/rambi/variants/ninja/gpio.c
+++ b/src/mainboard/google/rambi/variants/ninja/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/orco/gpio.c b/src/mainboard/google/rambi/variants/orco/gpio.c
index f2bbe8a..afa50cf 100644
--- a/src/mainboard/google/rambi/variants/orco/gpio.c
+++ b/src/mainboard/google/rambi/variants/orco/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/quawks/gpio.c b/src/mainboard/google/rambi/variants/quawks/gpio.c
index 3d79d37..56942bd 100644
--- a/src/mainboard/google/rambi/variants/quawks/gpio.c
+++ b/src/mainboard/google/rambi/variants/quawks/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/rambi/gpio.c b/src/mainboard/google/rambi/variants/rambi/gpio.c
index 3d79d37..56942bd 100644
--- a/src/mainboard/google/rambi/variants/rambi/gpio.c
+++ b/src/mainboard/google/rambi/variants/rambi/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/squawks/gpio.c b/src/mainboard/google/rambi/variants/squawks/gpio.c
index 3d79d37..56942bd 100644
--- a/src/mainboard/google/rambi/variants/squawks/gpio.c
+++ b/src/mainboard/google/rambi/variants/squawks/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/sumo/gpio.c b/src/mainboard/google/rambi/variants/sumo/gpio.c
index 0856c29..c4cc40a 100644
--- a/src/mainboard/google/rambi/variants/sumo/gpio.c
+++ b/src/mainboard/google/rambi/variants/sumo/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/swanky/gpio.c b/src/mainboard/google/rambi/variants/swanky/gpio.c
index a713549..3b62880 100644
--- a/src/mainboard/google/rambi/variants/swanky/gpio.c
+++ b/src/mainboard/google/rambi/variants/swanky/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
diff --git a/src/mainboard/google/rambi/variants/winky/gpio.c b/src/mainboard/google/rambi/variants/winky/gpio.c
index dcdf6f5..9c3a338 100644
--- a/src/mainboard/google/rambi/variants/winky/gpio.c
+++ b/src/mainboard/google/rambi/variants/winky/gpio.c
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <stdlib.h>
#include <soc/gpio.h>
#include <mainboard/google/rambi/irqroute.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/33701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5792b251fa60f37184eddbf6908910ea56896319
Gerrit-Change-Number: 33701
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange