coreboot-gerrit May 2019

coreboot-gerrit@coreboot.org

1 participants
1485 discussions

Change in ...coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by Mike Banon (Code Review) 19 May '19

19 May '19

Hello Paul Menzel, Mike Banon, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/28425 to look at the new patch set (#12). Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates These scripts will help you to securely and conveniently apply the two changes 28273 and 28370 to update AMD microcodes for f15tn and f16kb family processors. Save to ./coreboot/ then run ./get_ucode_patches.sh , ./check... and ./apply... https://review.coreboot.org/c/coreboot/+/28273 src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 https://review.coreboot.org/c/coreboot/+/28370 src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- A apply_ucode_patches.sh A check_ucode_patches.sh A get_ucode_patches.sh A sha256sums_ucode_correct.txt 4 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/28425/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 12 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: AMD microcodes: scripts for applying the unofficial (not-merged-yet) ...
by build bot (Jenkins) (Code Review) 19 May '19

19 May '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28425 ) Change subject: AMD microcodes: scripts for applying the unofficial (not-merged-yet) updates ...................................................................... Patch Set 11: (5 comments) https://review.coreboot.org/#/c/28425/11/apply_ucode_patches.sh File apply_ucode_patches.sh: https://review.coreboot.org/#/c/28425/11/apply_ucode_patches.sh@4 PS11, Line 4: ### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 line over 80 characters https://review.coreboot.org/#/c/28425/11/apply_ucode_patches.sh@9 PS11, Line 9: ### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 line over 80 characters https://review.coreboot.org/#/c/28425/11/check_ucode_patches.sh File check_ucode_patches.sh: https://review.coreboot.org/#/c/28425/11/check_ucode_patches.sh@10 PS11, Line 10: echo "! MISMATCH ! See ./sha256sums_ucode_my.txt and ./sha256sums_ucode_correct.txt" line over 80 characters https://review.coreboot.org/#/c/28425/11/get_ucode_patches.sh File get_ucode_patches.sh: https://review.coreboot.org/#/c/28425/11/get_ucode_patches.sh@5 PS11, Line 5: ### src/vendorcode/amd/agesa/f15tn: Update microcode to version 0x600111F 2018-03-05 line over 80 characters https://review.coreboot.org/#/c/28425/11/get_ucode_patches.sh@11 PS11, Line 11: ### src/vendorcode/amd/agesa/f16kb: Update microcode to version 0x7000110 2018-02-09 line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/28425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic16c1c4b86576ee7505cceed871b47a2b82f3c56 Gerrit-Change-Number: 28425 Gerrit-PatchSet: 11 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 19 May 2019 11:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/asus/kgpe-d16: Add DIMM_MAX to Kconfig
by HAOUAS Elyes (Code Review) 19 May '19

19 May '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32883 Change subject: mb/asus/kgpe-d16: Add DIMM_MAX to Kconfig ...................................................................... mb/asus/kgpe-d16: Add DIMM_MAX to Kconfig Default DIMM_MAX is 4 however kgpe-d16 has 16 DIMM slots and high expandability with 6 expansion slots. Change-Id: Id7150f85138b9a22b07f6abdbb0acedccfbf6fde Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/asus/kgpe-d16/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32883/1 diff --git a/src/mainboard/asus/kgpe-d16/Kconfig b/src/mainboard/asus/kgpe-d16/Kconfig index 32c4dbc..03917c1 100644 --- a/src/mainboard/asus/kgpe-d16/Kconfig +++ b/src/mainboard/asus/kgpe-d16/Kconfig @@ -95,6 +95,10 @@ string default "1a03,2000" +config DIMM_MAX + int + default 22 + config MAX_REBOOT_CNT int default 10 -- To view, visit https://review.coreboot.org/c/coreboot/+/32883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7150f85138b9a22b07f6abdbb0acedccfbf6fde Gerrit-Change-Number: 32883 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 5

Change in ...coreboot[master]: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN
by Julius Werner (Code Review) 19 May '19

19 May '19

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32548 Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN ...................................................................... spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN I can't claim that I really understand what this code does, but it looks like there are platforms that use code from lib/spd_bin.c without enabling CONFIG_GENERIC_SPD_BIN. Some functions in that file contain references to CONFIG_DIMM_MAX, so that option probably shouldn't depend on CONFIG_GENERIC_SPD_BIN. Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/32548/1 diff --git a/src/Kconfig b/src/Kconfig index 90c724e..e2088e8d 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1155,7 +1155,6 @@ config DIMM_MAX int default 4 - depends on GENERIC_SPD_BIN help Total number of memory DIMM slots available on motherboard. It is multiplication of number of channel to number of DIMMs per -- To view, visit https://review.coreboot.org/c/coreboot/+/32548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

6 6

Change in ...coreboot[master]: cpu/intel/sandybridge: Add `hyper_threading` option
by Nico Huber (Code Review) 19 May '19

19 May '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 ) Change subject: cpu/intel/sandybridge: Add `hyper_threading` option ...................................................................... Patch Set 2: > Can we make this a common intel cpu change with an interface for multiple cpu implementations. You mean if this code works for other platforms? -- To view, visit https://review.coreboot.org/c/coreboot/+/29669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b73e32ff5af8ea64a47e8aa706e27648aaf0993 Gerrit-Change-Number: 29669 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-CC: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Comment-Date: Sun, 19 May 2019 09:55:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/i82801ix: Fix flashconsole on platform
by Kyösti Mälkki (Code Review) 19 May '19

19 May '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21107 ) Change subject: sb/i82801ix: Fix flashconsole on platform ...................................................................... Patch Set 17: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/21107/17/src/mainboard/emulation/qemu-q35/K… File src/mainboard/emulation/qemu-q35/Kconfig: https://review.coreboot.org/#/c/21107/17/src/mainboard/emulation/qemu-q35/K… PS17, Line 16: select TSC_MONOTONIC_TIMER Did you check this does not have ill side-effects. Personally I don't mind if it is done here, just seems kind of unrelated change. -- To view, visit https://review.coreboot.org/c/coreboot/+/21107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55 Gerrit-Change-Number: 21107 Gerrit-PatchSet: 17 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 19 May 2019 03:11:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/facebook/fbg1701: Do initial mainboard commit
by Alex Thiessen (Code Review) 18 May '19

18 May '19

Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 ) Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ...................................................................... Patch Set 23: (4 comments) https://review.coreboot.org/#/c/30414/23//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30414/23//COMMIT_MSG@12 PS23, Line 12: manufacture manufacturer https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmo… File src/mainboard/facebook/fbg1701/cmos.layout: https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmo… PS23, Line 69: 4 Overflows quickly, please state in a comment when it's OK. https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmo… PS23, Line 91: 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 Not check-summed, state in a comment when it's by design or adjust the range. https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/rom… File src/mainboard/facebook/fbg1701/romstage.c: https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/rom… PS23, Line 45: uintptr_t possibly missing direct include -- To view, visit https://review.coreboot.org/c/coreboot/+/30414 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 23 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Comment-Date: Sat, 18 May 2019 21:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/i82801ix: Fix flashconsole on platform
by Matt DeVillier (Code Review) 18 May '19

18 May '19

Matt DeVillier has uploaded a new patch set (#17) to the change originally created by Nicola Corna. ( https://review.coreboot.org/c/coreboot/+/21107 ) Change subject: sb/i82801ix: Fix flashconsole on platform ...................................................................... sb/i82801ix: Fix flashconsole on platform select SOUTHBRIDGE_INTEL_COMMON_SPI to enable flashconsole support for sb/i82801ix. select TSC_MONOTONIC_TIMER for mb/qemu-q35 to fix building as a result of adding SOUTHBRIDGE_INTEL_COMMON_SPI. Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/emulation/qemu-q35/Kconfig M src/southbridge/intel/i82801ix/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/21107/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/21107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd3e8621fa4cb349b7e0e07118cab0380f24ff55 Gerrit-Change-Number: 21107 Gerrit-PatchSet: 17 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: vendorcode/google/chromeos: Correct VPD field for MAC passthrough
by Simon Glass (Code Review) 18 May '19

18 May '19

Simon Glass has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32839 Change subject: vendorcode/google/chromeos: Correct VPD field for MAC passthrough ...................................................................... vendorcode/google/chromeos: Correct VPD field for MAC passthrough The VPD field name is dock_passthrough, not dock_passthru. Fix it. (I assume there is no length limit) BUG=132689337 TEST=check that the feature can now be controlled by the associated enterprise policy Change-Id: Icc2b070313fde74447279cd6ccaa4e3eb6d119ee Signed-off-by: Simon Glass <sjg(a)chromium.org> --- M src/vendorcode/google/chromeos/acpi/amac.asl 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/32839/1 diff --git a/src/vendorcode/google/chromeos/acpi/amac.asl b/src/vendorcode/google/chromeos/acpi/amac.asl index c87862f..924482d 100644 --- a/src/vendorcode/google/chromeos/acpi/amac.asl +++ b/src/vendorcode/google/chromeos/acpi/amac.asl @@ -16,16 +16,17 @@ /* * The Realtek r8152 driver in the Linux kernel supports a MAC address - * passthru feature which can result in the dock ethernet port using the - * same MAC address that is assigned to the internal NIC. This is done - * by calling an ACPI method at \_SB.AMAC() which returns a formatted - * string (as a buffer) containing the MAC address for the dock to use. + * dock_pass-through feature which can result in the dock ethernet port + * using the same MAC address that is assigned to the internal NIC. This + * is done by calling an ACPI method at \_SB.AMAC() which returns a + * formatted * string (as a buffer) containing the MAC address for the + * dock to use. * * The Linux kernel implementation can be found at * drivers/net/usb/r8152.c:vendor_mac_passthru_addr_read() * * For Chrome OS, the policy which controls where the dock MAC address - * comes from is written into RW_VPD property "dock_passthru": + * comes from is written into RW_VPD property "dock_passthrough": * * "dock_mac" or empty: Use MAC address from RO_VPD value "dock_mac" * "ethernet_mac0": Use MAC address from RO_VPD value "ethernet_mac0" @@ -39,8 +40,8 @@ /* Format expected by the Linux kernel r8152 driver */ Name (MACA, "_AUXMAC_#XXXXXXXXXXXX#") - /* Get "dock_passthru" value from RW_VPD */ - Local0 = \VPD.VPDF ("RW", "dock_passthru") + /* Get "dock_passthrough" value from RW_VPD */ + Local0 = \VPD.VPDF ("RW", "dock_passthrough") Local1 = Zero Switch (ToString (Local0)) -- To view, visit https://review.coreboot.org/c/coreboot/+/32839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc2b070313fde74447279cd6ccaa4e3eb6d119ee Gerrit-Change-Number: 32839 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-MessageType: newchange

3 6

Change in ...coreboot[master]: SMBIOS: Fix SPD manufacture ID decoder
by Lijian Zhao (Code Review) 18 May '19

18 May '19

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32837 Change subject: SMBIOS: Fix SPD manufacture ID decoder ...................................................................... SMBIOS: Fix SPD manufacture ID decoder According to latest JEP106 from JEDEC, modify manufacture ID accordingly. Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed --- M src/arch/x86/smbios.c 1 file changed, 6 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32837/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 589f4f0..f411bc7 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -140,7 +140,7 @@ struct smbios_type17 *t) { switch (mod_id) { - case 0x2c80: + case 0x9b05: t->manufacturer = smbios_add_string(t->eos, "Crucial"); break; @@ -148,7 +148,7 @@ t->manufacturer = smbios_add_string(t->eos, "Ramaxel"); break; - case 0x4f01: + case 0x4f80: t->manufacturer = smbios_add_string(t->eos, "Transcend"); break; @@ -156,10 +156,6 @@ t->manufacturer = smbios_add_string(t->eos, "Kingston"); break; - case 0x987f: - t->manufacturer = smbios_add_string(t->eos, - "Hynix"); - break; case 0x9e02: t->manufacturer = smbios_add_string(t->eos, "Corsair"); @@ -170,11 +166,11 @@ break; case 0xad80: t->manufacturer = smbios_add_string(t->eos, - "Hynix/Hyundai"); + "SK Hynix"); break; - case 0xb502: + case 0x3486: t->manufacturer = smbios_add_string(t->eos, - "SuperTalent"); + "Super Talent"); break; case 0xcd04: t->manufacturer = smbios_add_string(t->eos, @@ -188,7 +184,7 @@ t->manufacturer = smbios_add_string(t->eos, "Elpida"); break; - case 0xff2c: + case 0x2c80: t->manufacturer = smbios_add_string(t->eos, "Micron"); break; -- To view, visit https://review.coreboot.org/c/coreboot/+/32837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed Gerrit-Change-Number: 32837 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-MessageType: newchange

5 15

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2019