Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31992 )
Change subject: soc/intel/broadwell: Fix use of CONFIG_USBDEBUG
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/31992
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52c852fb449de5a6512aa2556592e6dfe7b0c573
Gerrit-Change-Number: 31992
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:09:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27056 )
Change subject: gma registers: Separate 32- and 64-bit GTT access
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/27056/4/common/hw-gfx-gma-registers.adb
File common/hw-gfx-gma-registers.adb:
https://review.coreboot.org/#/c/27056/4/common/hw-gfx-gma-registers.adb@49
PS4, Line 49:
Comment why we have two instances.
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/27056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Ib6f21b71c434a9cbdd5cdfa3697da2b2e86750f4
Gerrit-Change-Number: 27056
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 22 Mar 2019 15:28:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29329
to look at the new patch set (#7).
Change subject: drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure
......................................................................
drivers/pc80/rtc/mc146818rtc.c: Reset RTC time on RTC power failure
RTC time contains invalid values on system without RTC battery.
Handle 'invalid' the same way as 'cmos_invalid'. This will reset CMOS date
when calling function enables 'invalid'.
BUG=N/A
TEST=Portwell PQ-M107 booting Linux Embedded
Change-Id: I5eae57d00f328400a8b03c28b7ecdbbc71522206
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M src/drivers/pc80/rtc/mc146818rtc.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/29329/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/29329
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eae57d00f328400a8b03c28b7ecdbbc71522206
Gerrit-Change-Number: 29329
Gerrit-PatchSet: 7
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), Hannah Williams, Michał Żygowski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29398
to look at the new patch set (#10).
Change subject: soc/intel/braswell/southcluster.c: Correct serial IRQ support
......................................................................
soc/intel/braswell/southcluster.c: Correct serial IRQ support
Serial IRQ was configured in quiet mode, but not enabled.
Enable serial IRQ and use 'enum seriirq_mode' as a devicetree
option.
enable_serirq_quiet_mode() is renamed to
sc_set_serial_irqs_mode(). This function use the 'serirq_mode' to
set the mode.
BUG=N/A
TEST=Portwell PQ7-M107
Change-Id: I7844cad69dc0563fa6109d779d0afb7c2edd7245
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M src/mainboard/google/cyan/variants/banon/devicetree.cb
M src/mainboard/google/cyan/variants/celes/devicetree.cb
M src/mainboard/google/cyan/variants/cyan/devicetree.cb
M src/mainboard/google/cyan/variants/edgar/devicetree.cb
M src/mainboard/google/cyan/variants/kefka/devicetree.cb
M src/mainboard/google/cyan/variants/reks/devicetree.cb
M src/mainboard/google/cyan/variants/relm/devicetree.cb
M src/mainboard/google/cyan/variants/setzer/devicetree.cb
M src/mainboard/google/cyan/variants/terra/devicetree.cb
M src/mainboard/google/cyan/variants/ultima/devicetree.cb
M src/mainboard/google/cyan/variants/wizpig/devicetree.cb
M src/mainboard/intel/strago/devicetree.cb
M src/soc/intel/braswell/chip.h
M src/soc/intel/braswell/include/soc/lpc.h
M src/soc/intel/braswell/southcluster.c
15 files changed, 62 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/29398/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/29398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7844cad69dc0563fa6109d779d0afb7c2edd7245
Gerrit-Change-Number: 29398
Gerrit-PatchSet: 10
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Hello Aaron Durbin, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31777
to review the following change.
Change subject: lint/kconfig: More checks, more errors
......................................................................
lint/kconfig: More checks, more errors
This patch changes a few more Kconfig linter warnings to errors that
currently do not show up in the tree and that seem unlikely to become
false positive in the future. One instance of duplicated code that
essentially checks for the same thing was consolidated.
It also adds a new test for references to boolean Kconfig options that
do not use the CONFIG() wrapper macro. It's a little flaky (e.g. hard to
handle multi-line comments), but it should be helpful the majority of
the time as a warning in a Jenkins comment.
Change-Id: I975ee77d392ed426f76f7671d9b6ef9441656e6a
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
---
M util/lint/kconfig_lint
1 file changed, 27 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/31777/1
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index 6cf05a4..4d0a755 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -199,35 +199,16 @@
my $symbol = $3;
if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) {
- show_warning( "#ifdef 'CONFIG_$symbol' used at $file:$lineno."
+ show_error( "#ifdef 'CONFIG_$symbol' used at $file:$lineno."
. " Symbols of type '$symbols{$symbol}{type}' are always defined." );
}
- } elsif ( $line =~ /^([^:]+):(\d+):\s*#\s*if\s+!?\s*defined\s*\(?\s*CONFIG(?:_|\()(\w+)/ ) {
+ } elsif ( $line =~ /^([^:]+):(\d+):.+defined\s*\(?\s*CONFIG(?:_|\()(\w+)/ ) {
my $file = $1;
my $lineno = $2;
my $symbol = $3;
if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) {
- show_warning( "#ifdef 'CONFIG_$symbol' used at $file:$lineno."
- . " Symbols of type '$symbols{$symbol}{type}' are always defined." );
- }
- }
- }
-
- # look for (#if) defined SYMBOL
- @ifdef_symbols = @collected_symbols;
- while ( my $line = shift @ifdef_symbols ) {
- if ( $line =~ /^([^:]+):(\d+):.+defined\s*\(\s*CONFIG(?:_|\()(\w+)/ ) {
- my $file = $1;
- my $lineno = $2;
- my $symbol = $3;
-
- #ignore '#if defined(symbol) && symbol' type statements
- next
- if ( $line =~ /^([^:]+):(\d+):.+defined\s*\(\s*CONFIG_$symbol.*(&&|\|\|)\s*!?\s*\(?\s*CONFIG_$symbol/ );
-
- if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) {
- show_warning( "defined 'CONFIG_$symbol' used at $file:$lineno."
+ show_error( "defined(CONFIG_$symbol) used at $file:$lineno."
. " Symbols of type '$symbols{$symbol}{type}' are always defined." );
}
}
@@ -272,10 +253,10 @@
my $symbol = $3;
if ( ( exists $symbols{$symbol} ) ) {
- show_warning("#define of symbol 'CONFIG_$symbol' used at $file:$lineno.");
+ show_error("#define of symbol 'CONFIG_$symbol' used at $file:$lineno.");
}
else {
- show_warning( "#define 'CONFIG_$symbol' used at $file:$lineno."
+ show_error( "#define 'CONFIG_$symbol' used at $file:$lineno."
. " Other #defines should not look like Kconfig symbols." );
}
}
@@ -383,6 +364,24 @@
. " CONFIG($symbol) should be used for type 'bool'" );
}
}
+ } elsif ( $line =~ /^([^:]+):(\d+):(.+\bCONFIG_.+)/ ) {
+ my $file = $1;
+ my $lineno = $2;
+ $line = $3;
+ if ( $file =~ /.*\.(c|h|asl|ld)/ ) {
+ while ( $line =~ /(.*)\bCONFIG_(\w+)(.*)/ && $1 !~ /\/\/|\/\*/ ) {
+ my $symbol = $2;
+ $line = $1 . $3;
+ if ( exists $symbols{$symbol} ) {
+ if ( $symbols{$symbol}{type} eq "bool" ) {
+ show_warning( "Naked reference to CONFIG_$symbol used at $file:$lineno."
+ . " A 'bool' Kconfig should always be accessed through CONFIG($symbol)." );
+ }
+ } else {
+ show_warning( "Unknown config option CONFIG_$symbol used at $file:$lineno." );
+ }
+ }
+ }
}
}
}
@@ -437,7 +436,7 @@
}
} elsif ($symbols{$sym}{type} eq "bool") {
if ($symbols{$sym}{$sym_num}{default}{$def_num}{default} =~ /[01YN]/) {
- show_warning("default value ($symbols{$sym}{$sym_num}{default}{$def_num}{default}) for bool symbol $sym uses value other than y/n at $filename:$line_no.");
+ show_error("default value ($symbols{$sym}{$sym_num}{default}{$def_num}{default}) for bool symbol $sym uses value other than y/n at $filename:$line_no.");
} else {
show_error("non bool default value ($symbols{$sym}{$sym_num}{default}{$def_num}{default}) used for bool symbol $sym at $filename:$line_no.");
}
@@ -447,7 +446,7 @@
#if a default is already set, display an error
if ($default_set) {
- show_warning( "Default for '$sym' referenced at $filename:$line_no will never be set"
+ show_error( "Default for '$sym' referenced at $filename:$line_no will never be set"
. " - overridden by default set at $default_filename:$default_line_no" );
}
else {
@@ -1140,7 +1139,7 @@
( $type, $expression ) = handle_if_line( $type, $inside_config, $filename, $line_no );
if ( $type =~ /tristate/ ) {
- show_warning("$filename:$line_no - tristate types are not used.");
+ show_error("$filename:$line_no - tristate types are not used.");
}
if ($inside_config) {
@@ -1265,7 +1264,7 @@
#the directory should exist when using a glob
else {
- show_warning("Could not find dir '$dir_prefix'");
+ show_error("Could not find dir '$dir_prefix'");
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/31777
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I975ee77d392ed426f76f7671d9b6ef9441656e6a
Gerrit-Change-Number: 31777
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31928 )
Change subject: soc/intel/cannonlake: enable VMX support
......................................................................
Patch Set 4:
Why can’t the generic code be used?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33dbffa6301afabd688080751ba3b85a43e00156
Gerrit-Change-Number: 31928
Gerrit-PatchSet: 4
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Fri, 22 Mar 2019 13:03:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Krzysztof M Sywula has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31894
Change subject: soc/intel/cannonlake: Enable shutdown before OS
......................................................................
soc/intel/cannonlake: Enable shutdown before OS
This change enables user to shutdown the system
by shortly pressing shutdown button (<10sec) before OS is loaded.
Main use case is shutdown from recovery/broken screen.
Tested on Fircrest SKU2-3 (Whisky Lake EVT board)
Change-Id: I7655daf65ff058df7d9bad4567f74b4f4007acb4
Signed-off-by: Krzysztof Sywula <krzysztof.m.sywula(a)intel.com>
---
M src/soc/intel/cannonlake/pmc.c
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31894/1
diff --git a/src/soc/intel/cannonlake/pmc.c b/src/soc/intel/cannonlake/pmc.c
index 931c4af..5cd31f9 100644
--- a/src/soc/intel/cannonlake/pmc.c
+++ b/src/soc/intel/cannonlake/pmc.c
@@ -62,6 +62,21 @@
pmc_set_afterg3(PCH_DEV_PMC, CONFIG_MAINBOARD_POWER_FAILURE_STATE);
}
+static void pm1_enable_pwrbtn_smi(void *unused)
+{
+ /*
+ * Enable power button SMI only before jumping to payload. This ensures
+ * that:
+ * 1. Power button SMI is enabled only after coreboot is done.
+ * 2. On resume path, power button SMI is not enabled and thus avoids
+ * any shutdowns because of power button presses due to power button
+ * press in resume path.
+ */
+ pmc_update_pm1_enable(PWRBTN_EN);
+}
+
+BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_EXIT, pm1_enable_pwrbtn_smi, NULL);
+
static void config_deep_sX(uint32_t offset, uint32_t mask, int sx, int enable)
{
uint32_t reg;
--
To view, visit https://review.coreboot.org/c/coreboot/+/31894
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7655daf65ff058df7d9bad4567f74b4f4007acb4
Gerrit-Change-Number: 31894
Gerrit-PatchSet: 1
Gerrit-Owner: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com>
Gerrit-MessageType: newchange
Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31981
Change subject: mb/google/octopus: Add keyboard backlight support for bloog
......................................................................
mb/google/octopus: Add keyboard backlight support for bloog
Bloog supports keyboard backlight feature, so enable the ASL code.
BUG=b:127736039
BRANCH=octopus
TEST=Build and boot bloog, verify that the string 'KBLT' is in the DSDT.
Change-Id: Iba66aade090816ea2376cae4baf4aae019cc97f4
Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/bloog/include/variant/ec.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/31981/1
diff --git a/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h b/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h
index 260d7d4..368413a 100644
--- a/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h
+++ b/src/mainboard/google/octopus/variants/bloog/include/variant/ec.h
@@ -18,4 +18,6 @@
#include <baseboard/ec.h>
+#define EC_ENABLE_KEYBOARD_BACKLIGHT
+
#endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/31981
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba66aade090816ea2376cae4baf4aae019cc97f4
Gerrit-Change-Number: 31981
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newchange