coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[master]: lib/cbmem_console: Rename cbmem_console_p to current_console
by Patrick Georgi (Code Review) 01 Dec '19

01 Dec '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37374 ) Change subject: lib/cbmem_console: Rename cbmem_console_p to current_console ...................................................................... lib/cbmem_console: Rename cbmem_console_p to current_console That way, current_console_set() also isn't necessary anymore and symmetry is re-established. Change-Id: I392ed509f490d63b0c016a80fd7ab3ef98ba8019 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/lib/cbmem_console.c 1 file changed, 17 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/37374/1 diff --git a/src/lib/cbmem_console.c b/src/lib/cbmem_console.c index 7bd247d..f6a055e 100644 --- a/src/lib/cbmem_console.c +++ b/src/lib/cbmem_console.c @@ -48,7 +48,7 @@ _Static_assert(CONFIG_CONSOLE_CBMEM_BUFFER_SIZE <= MAX_SIZE, "cbmem_console format cannot support buffers larger than 256MB!"); -static struct cbmem_console *cbmem_console_p; +static struct cbmem_console *current_console; /* * While running from ROM, before DRAM is initialized, some area in cache as @@ -64,11 +64,6 @@ #define STATIC_CONSOLE_SIZE 1024 static u8 static_console[STATIC_CONSOLE_SIZE]; -static void current_console_set(struct cbmem_console *new_console_p) -{ - cbmem_console_p = new_console_p; -} - static int buffer_valid(struct cbmem_console *cbm_cons_p, u32 total_space) { return (cbm_cons_p->cursor & CURSOR_MASK) < cbm_cons_p->size && @@ -81,7 +76,7 @@ struct cbmem_console *cbm_cons_p = storage; if (!cbm_cons_p || total_space <= sizeof(struct cbmem_console)) { - current_console_set(NULL); + current_console = NULL; return; } @@ -90,7 +85,7 @@ cbm_cons_p->cursor = 0; } - current_console_set(cbm_cons_p); + current_console = cbm_cons_p; } void cbmemc_init(void) @@ -106,19 +101,19 @@ void cbmemc_tx_byte(unsigned char data) { - if (!cbmem_console_p || !cbmem_console_p->size) + if (!current_console || !current_console->size) return; - u32 flags = cbmem_console_p->cursor & ~CURSOR_MASK; - u32 cursor = cbmem_console_p->cursor & CURSOR_MASK; + u32 flags = current_console->cursor & ~CURSOR_MASK; + u32 cursor = current_console->cursor & CURSOR_MASK; - cbmem_console_p->body[cursor++] = data; - if (cursor >= cbmem_console_p->size) { + current_console->body[cursor++] = data; + if (cursor >= current_console->size) { cursor = 0; flags |= OVERFLOW; } - cbmem_console_p->cursor = flags | cursor; + current_console->cursor = flags | cursor; } /* @@ -158,7 +153,7 @@ const size_t size = CONFIG_CONSOLE_CBMEM_BUFFER_SIZE; /* If CBMEM entry already existed, old contents are not altered. */ struct cbmem_console *cbmem_cons_p = cbmem_add(CBMEM_ID_CONSOLE, size); - struct cbmem_console *previous_cons_p = cbmem_console_p; + struct cbmem_console *previous_cons_p = current_console; init_console_ptr(cbmem_cons_p, size); copy_console_buffer(previous_cons_p); @@ -171,15 +166,15 @@ void cbmem_dump_console(void) { u32 cursor; - if (!cbmem_console_p) + if (!current_console) return; uart_init(0); - if (cbmem_console_p->cursor & OVERFLOW) - for (cursor = cbmem_console_p->cursor & CURSOR_MASK; - cursor < cbmem_console_p->size; cursor++) - uart_tx_byte(0, cbmem_console_p->body[cursor]); - for (cursor = 0; cursor < (cbmem_console_p->cursor & CURSOR_MASK); cursor++) - uart_tx_byte(0, cbmem_console_p->body[cursor]); + if (current_console->cursor & OVERFLOW) + for (cursor = current_console->cursor & CURSOR_MASK; + cursor < current_console->size; cursor++) + uart_tx_byte(0, current_console->body[cursor]); + for (cursor = 0; cursor < (current_console->cursor & CURSOR_MASK); cursor++) + uart_tx_byte(0, current_console->body[cursor]); } #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/37374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I392ed509f490d63b0c016a80fd7ab3ef98ba8019 Gerrit-Change-Number: 37374 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: src/superio: Remove unused include <stdlib.h>
by HAOUAS Elyes (Code Review) 01 Dec '19

01 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37379 ) Change subject: src/superio: Remove unused include <stdlib.h> ...................................................................... src/superio: Remove unused include <stdlib.h> Change-Id: I941c3d80d6b822b12a2d0c279415ab0c6b7f375b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/fintek/f81803a/superio.c M src/superio/nuvoton/nct5539d/superio.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/37379/1 diff --git a/src/superio/fintek/f81803a/superio.c b/src/superio/fintek/f81803a/superio.c index 1cb31bf..5a54f54 100644 --- a/src/superio/fintek/f81803a/superio.c +++ b/src/superio/fintek/f81803a/superio.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <stdlib.h> #include <pc80/keyboard.h> #include "f81803a.h" diff --git a/src/superio/nuvoton/nct5539d/superio.c b/src/superio/nuvoton/nct5539d/superio.c index 4f2a4a5..9e35ec1 100644 --- a/src/superio/nuvoton/nct5539d/superio.c +++ b/src/superio/nuvoton/nct5539d/superio.c @@ -22,7 +22,6 @@ #include <device/device.h> #include <device/pnp.h> #include <pc80/keyboard.h> -#include <stdlib.h> #include <superio/conf_mode.h> #include "nct5539d.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/37379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I941c3d80d6b822b12a2d0c279415ab0c6b7f375b Gerrit-Change-Number: 37379 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: superio/nct5539d: include the missing acpi.h and ssdt.h
by Maxim Polyakov (Code Review) 01 Dec '19

01 Dec '19

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37274 ) Change subject: superio/nct5539d: include the missing acpi.h and ssdt.h ...................................................................... superio/nct5539d: include the missing acpi.h and ssdt.h Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M src/superio/nuvoton/nct5539d/superio.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/37274/1 diff --git a/src/superio/nuvoton/nct5539d/superio.c b/src/superio/nuvoton/nct5539d/superio.c index 4f2a4a5..bdb50c7 100644 --- a/src/superio/nuvoton/nct5539d/superio.c +++ b/src/superio/nuvoton/nct5539d/superio.c @@ -24,7 +24,8 @@ #include <pc80/keyboard.h> #include <stdlib.h> #include <superio/conf_mode.h> - +#include <superio/common/ssdt.h> +#include <arch/acpi.h> #include "nct5539d.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/37274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd80fae1c39f3c7c4bc66a42e9023fb7a727b024 Gerrit-Change-Number: 37274 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: nb/intel/x4x: Factor out hiding PCI devs in pure fn
by Arthur Heymans (Code Review) 01 Dec '19

01 Dec '19

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37291 ) Change subject: nb/intel/x4x: Factor out hiding PCI devs in pure fn ...................................................................... nb/intel/x4x: Factor out hiding PCI devs in pure fn This increases readability. Also change the update expression. '--variable' does not make much sense there. Change-Id: I64db2460115f5fb35ca197b83440f8ee47470761 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/northbridge.c 1 file changed, 21 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/37291/1 diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c index 39f24d3..efdaeef 100644 --- a/src/northbridge/intel/x4x/northbridge.c +++ b/src/northbridge/intel/x4x/northbridge.c @@ -206,44 +206,45 @@ dev->ops = &cpu_bus_ops; } +static void hide_pci_fn(const int dev_bit_base, const struct device *dev) +{ + if (!dev || dev->enabled) + return; + const unsigned int fn = PCI_FUNC(dev->path.pci.devfn); + const struct device *const d0f0 = pcidev_on_root(0, 0); + pci_update_config32(d0f0, D0F0_DEVEN, ~(1 << (dev_bit_base + fn)), 0); +} + +static void hide_pci_dev(const int dev, int functions, const int dev_bit_base) +{ + for (; functions >= 0; functions--) + hide_pci_fn(dev_bit_base, pcidev_on_root(dev, functions)); +} + static void x4x_init(void *const chip_info) { - int dev, fn, bit_base; - + int dev; struct device *const d0f0 = pcidev_on_root(0x0, 0); /* Hide internal functions based on devicetree info. */ - for (dev = 6; dev > 0; --dev) { + for (dev = 6; dev > 0; dev--) { switch (dev) { case 6: /* PEG1: only on P45 */ - fn = 0; - bit_base = 13; + hide_pci_dev(dev, 0, 13); break; case 3: /* ME */ - fn = 3; - bit_base = 6; + hide_pci_dev(dev, 3, 6); break; case 2: /* IGD */ - fn = 1; - bit_base = 3; + hide_pci_dev(dev, 1, 3); break; case 1: /* PEG0 */ - fn = 0; - bit_base = 1; + hide_pci_dev(dev, 0, 1); break; case 4: /* Nothing to do */ case 5: continue; } - for (; fn >= 0; --fn) { - const struct device *const d = - pcidev_on_root(dev, fn); - if (!d || d->enabled) - continue; - const u32 deven = pci_read_config32(d0f0, D0F0_DEVEN); - pci_write_config32(d0f0, D0F0_DEVEN, - deven & ~(1 << (bit_base + fn))); - } } const u32 deven = pci_read_config32(d0f0, D0F0_DEVEN); -- To view, visit https://review.coreboot.org/c/coreboot/+/37291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64db2460115f5fb35ca197b83440f8ee47470761 Gerrit-Change-Number: 37291 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

4 10

Change in em100[master]: Add support for older EM100Pro
by Stefan Reinauer (Code Review) 01 Dec '19

01 Dec '19

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37344 ) Change subject: Add support for older EM100Pro ...................................................................... Add support for older EM100Pro These have hardware version 0xff but are otherwise version 4. Their serial numbers start with DP instead of EM. Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I18f19d83b515c4e740f1efec07d49c1ceb2373ec --- M em100.c M em100.h M firmware.c 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/44/37344/1 diff --git a/em100.c b/em100.c index 492af4b..578707d 100644 --- a/em100.c +++ b/em100.c @@ -256,7 +256,9 @@ /* Re-read serial number */ get_device_info(em100); if (em100->serialno != 0xffffffff) - printf("New serial number: EM%06d\n", em100->serialno); + printf("New serial number: %s%06d\n", + em100->hwversion == 0xff ? "DP" : "EM", + em100->serialno); else printf("New serial number: N.A.\n"); @@ -494,9 +496,10 @@ libusb_get_device_address(dev)); continue; } - printf(" Bus %03d Device %03d: EM100pro EM%06d\n", + printf(" Bus %03d Device %03d: EM100pro %s%06d\n", libusb_get_bus_number(dev), libusb_get_device_address(dev), + em100.hwversion == 0xff ? "DP" : "EM", em100.serialno); em100_detach(&em100); count++; @@ -924,7 +927,8 @@ printf("Hardware version: %u\n", em100.hwversion); if (em100.serialno != 0xffffffff) - printf("Serial number: EM%06d\n", em100.serialno); + printf("Serial number: %s%06d\n", + em100.hwversion == 0xff ? "DP" : "EM", em100.serialno); else printf("Serial number: N.A.\n"); printf("SPI flash database: %s\n", database_version); diff --git a/em100.h b/em100.h index 3d9cdc8..d48e52b 100644 --- a/em100.h +++ b/em100.h @@ -39,8 +39,9 @@ } chipdesc; /* Hardware versions */ -#define HWVERSION_EM100PRO 4 -#define HWVERSION_EM100PRO_G2 6 +#define HWVERSION_EM100PRO_EARLY 0xff +#define HWVERSION_EM100PRO 0x04 +#define HWVERSION_EM100PRO_G2 0x06 #define BULK_SEND_TIMEOUT 5000 /* sentinel value */ diff --git a/firmware.c b/firmware.c index 96e2565..384e3f3 100644 --- a/firmware.c +++ b/firmware.c @@ -37,7 +37,7 @@ * 0x0100100: mcu firmware * 0x01f0000: 4 bytes secret key, 00 padded * 0x01fff00: ff xx yy yy yy yy ff ff - * xx: HW version + * xx: HW version (0xff, 0x04, 0x06) * yy: 4 bytes serial number * * Notes @@ -133,6 +133,7 @@ unsigned char header[0x100]; switch (em100->hwversion) { + case HWVERSION_EM100PRO_EARLY: case HWVERSION_EM100PRO: hdrversion=1; break; @@ -220,6 +221,7 @@ mcu_version[MAX_VERSION_LENGTH + 1]; switch (em100->hwversion) { + case HWVERSION_EM100PRO_EARLY: case HWVERSION_EM100PRO: printf("Detected EM100Pro (original).\n"); break; @@ -263,6 +265,13 @@ } fclose(f); + if (em100->hwversion == HWVERSION_EM100PRO_EARLY && (memcmp(fw, "em100pro", 8) != 0 || + memcmp(fw + 0x28, "WFPD", 4) != 0)) { + printf("ERROR: Not an EM100Pro (original) firmware file.\n"); + free(fw); + return 0; + } + if (em100->hwversion == HWVERSION_EM100PRO && (memcmp(fw, "em100pro", 8) != 0 || memcmp(fw + 0x28, "WFPD", 4) != 0)) { printf("ERROR: Not an EM100Pro (original) firmware file.\n"); -- To view, visit https://review.coreboot.org/c/em100/+/37344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I18f19d83b515c4e740f1efec07d49c1ceb2373ec Gerrit-Change-Number: 37344 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

3 8

Change in coreboot[master]: arch/x86: Support x86_64 exceptions
by build bot (Jenkins) (Code Review) 01 Dec '19

01 Dec '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 ) Change subject: arch/x86: Support x86_64 exceptions ...................................................................... Patch Set 27: (2 comments) https://review.coreboot.org/c/coreboot/+/30117/27/src/arch/x86/include/arch… File src/arch/x86/include/arch/registers.h: https://review.coreboot.org/c/coreboot/+/30117/27/src/arch/x86/include/arch… PS27, Line 44: #define QUAD_DOWNTO8(A) \ macros should not use a trailing semicolon https://review.coreboot.org/c/coreboot/+/30117/27/src/arch/x86/include/arch… PS27, Line 50: #define QUAD_DOWNTO16(A) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/30117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 Gerrit-Change-Number: 30117 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 01 Dec 2019 06:56:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/boot: Jump to payload in protected mode
by Patrick Rudolph (Code Review) 01 Dec '19

01 Dec '19

Patrick Rudolph has uploaded a new patch set (#28) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30118 ) Change subject: arch/x86/boot: Jump to payload in protected mode ...................................................................... arch/x86/boot: Jump to payload in protected mode * On ARCH_RAMSTAGE_X86_64 jump to the payload in protected mode. * Add a helper function to jump to arbitrary code in protected mode, similar to the real mode call handler. * Doesn't affect existing x86_32 code. Tested on QEMU Q35 using SeaBIOS as payload. Tested on Lenovo T410 with additional x86_64 patches. Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M Documentation/arch/x86/index.md M src/arch/x86/Makefile.inc M src/arch/x86/boot.c A src/arch/x86/c_exit.S M src/include/program_loading.h 5 files changed, 133 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/30118/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/30118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14 Gerrit-Change-Number: 30118 Gerrit-PatchSet: 28 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: Support x86_64 exceptions
by Patrick Rudolph (Code Review) 01 Dec '19

01 Dec '19

Patrick Rudolph has uploaded a new patch set (#27) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30117 ) Change subject: arch/x86: Support x86_64 exceptions ...................................................................... arch/x86: Support x86_64 exceptions * Doesn't affect existing x86_32 code. Tested on qemu using division by zero. Tested on Lenovo T410 with additional x86_64 patches. Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M Documentation/arch/x86/index.md M src/arch/x86/exception.c M src/arch/x86/idt.S M src/arch/x86/include/arch/registers.h 4 files changed, 141 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/30117/27 -- To view, visit https://review.coreboot.org/c/coreboot/+/30117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48 Gerrit-Change-Number: 30117 Gerrit-PatchSet: 27 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86/postcar: Add x86_64 support
by Patrick Rudolph (Code Review) 01 Dec '19

01 Dec '19

Patrick Rudolph has uploaded a new patch set (#23) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30500 ) Change subject: arch/x86/postcar: Add x86_64 support ...................................................................... arch/x86/postcar: Add x86_64 support * Add support for loading GDT on x86_64. * Add x86_64 assembly code to do the same as the x86_32 code. * Separate x86_32 and x86_64 code. Tested on qemu x86_32 and x86_64 using additional MTRRs. Tested on Lenovo T410 with additional x86_64 patches. Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M Documentation/arch/x86/index.md M src/arch/x86/Makefile.inc M src/arch/x86/exit_car.S M src/arch/x86/gdt_init.S 4 files changed, 65 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/30500/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/30500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b Gerrit-Change-Number: 30500 Gerrit-PatchSet: 23 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in em100[master]: Clean up license headers
by Stefan Reinauer (Code Review) 01 Dec '19

01 Dec '19

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37259 ) Change subject: Clean up license headers ...................................................................... Clean up license headers - Google Inc. became Google LLC in 2017 - Drop last paragraph of GPLv2 - Fix GPLv2 header in hexdump.c Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Change-Id: I81375366181d59d835db43b413ec51f041e25488 --- M Makefile M chips.c M curl.c M em100.c M em100.h M firmware.c M fpga.c M hexdump.c M makechips.sh M makedpfw.c M sdram.c M spi.c M system.c M tar.c M trace.c M usb.c 16 files changed, 5 insertions(+), 70 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/59/37259/1 diff --git a/Makefile b/Makefile index 3bdb103..93a2474 100644 --- a/Makefile +++ b/Makefile @@ -10,10 +10,6 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA -# # Make is silent per default, but 'make V=1' will show all compiler calls. Q:=@ diff --git a/chips.c b/chips.c index 7a776cc..52b01c9 100644 --- a/chips.c +++ b/chips.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <unistd.h> diff --git a/curl.c b/curl.c index 8a4f482..a4ee371 100644 --- a/curl.c +++ b/curl.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/em100.c b/em100.c index abd8415..fd6d002 100644 --- a/em100.c +++ b/em100.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/em100.h b/em100.h index 448e6bb..3d9cdc8 100644 --- a/em100.h +++ b/em100.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #ifndef __EM100_H__ diff --git a/firmware.c b/firmware.c index 0f1c1d0..8cf6091 100644 --- a/firmware.c +++ b/firmware.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/fpga.c b/fpga.c index 2fecc3b..301427c 100644 --- a/fpga.c +++ b/fpga.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/hexdump.c b/hexdump.c index b217123..1653a2b 100644 --- a/hexdump.c +++ b/hexdump.c @@ -1,19 +1,14 @@ /* * Copyright 2013-2015 Google Inc. * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. + ** This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. * * This program is distributed in the hope that it will be useful, - * but without any warranty; without even the implied warranty of + * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/makechips.sh b/makechips.sh index d216442..8c16ded 100755 --- a/makechips.sh +++ b/makechips.sh @@ -11,10 +11,6 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA -# URL="https://www.dediprog.com/download/save/78.msi" VURL="https://www.dediprog.com/download?productCategory=SPI+Flash+Solution&produc…" diff --git a/makedpfw.c b/makedpfw.c index 2b03138..5b3f1a2 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -1,5 +1,5 @@ /* - * Copyright 2017 Google Inc. + * Copyright 2017 Google LLC * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/sdram.c b/sdram.c index 6da1f14..408afd8 100644 --- a/sdram.c +++ b/sdram.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/spi.c b/spi.c index d24273f..a775ff8 100644 --- a/spi.c +++ b/spi.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/system.c b/system.c index a738144..9286118 100644 --- a/system.c +++ b/system.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/tar.c b/tar.c index 219efd4..ff103ce 100644 --- a/tar.c +++ b/tar.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #define _GNU_SOURCE diff --git a/trace.c b/trace.c index d7616b3..31b6e06 100644 --- a/trace.c +++ b/trace.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> diff --git a/usb.c b/usb.c index 77828bd..c7d52d8 100644 --- a/usb.c +++ b/usb.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc. */ #include <stdio.h> -- To view, visit https://review.coreboot.org/c/em100/+/37259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I81375366181d59d835db43b413ec51f041e25488 Gerrit-Change-Number: 37259 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

2 5

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019