coreboot-gerrit November 2019

coreboot-gerrit@coreboot.org

1 participants
2418 discussions

Change in coreboot[master]: soc/intel/denverton_ns: make use of common cbmem_top_chipset
by Michael Niewöhner (Code Review) 04 Nov '19

04 Nov '19

Hello Patrick Rudolph, Vanny E, build bot (Jenkins), David Guckian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36619 to look at the new patch set (#2). Change subject: soc/intel/denverton_ns: make use of common cbmem_top_chipset ...................................................................... soc/intel/denverton_ns: make use of common cbmem_top_chipset This replaces denverton_ns's own implementation of cbmem_top_chipset and selects the common code one. Change-Id: Idae96aabe2807e465bb7ab0f29910757d0346ce9 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/denverton_ns/memmap.c 2 files changed, 1 insertion(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/36619/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/36619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idae96aabe2807e465bb7ab0f29910757d0346ce9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/apollolake: make use of common cbmem_top_chipset
by Michael Niewöhner (Code Review) 04 Nov '19

04 Nov '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36618 ) Change subject: soc/intel/apollolake: make use of common cbmem_top_chipset ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/36618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11d12a6c8414a98d38be8b0dbf6dc57cd2efc5d6 Gerrit-Change-Number: 36618 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Nov 2019 21:38:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns: make use of common cbmem_top_chipset
by Michael Niewöhner (Code Review) 04 Nov '19

04 Nov '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36619 ) Change subject: soc/intel/denverton_ns: make use of common cbmem_top_chipset ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/36619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idae96aabe2807e465bb7ab0f29910757d0346ce9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Comment-Date: Mon, 04 Nov 2019 21:38:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/quark: make use of common cbmem_top_chipset
by Michael Niewöhner (Code Review) 04 Nov '19

04 Nov '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36621 ) Change subject: soc/intel/quark: make use of common cbmem_top_chipset ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/36621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I445c471b654abfa922b20215e52a2794529be120 Gerrit-Change-Number: 36621 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Michael Niewöhner Gerrit-Comment-Date: Mon, 04 Nov 2019 21:38:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move cbmem_top_chipset from soc to fsp code
by Michael Niewöhner (Code Review) 04 Nov '19

04 Nov '19

Michael Niewöhner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36615 ) Change subject: drivers/intel/fsp2_0: move cbmem_top_chipset from soc to fsp code ...................................................................... Abandoned ... wrong -- To view, visit https://review.coreboot.org/c/coreboot/+/36615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6200badaab64285156ab78b48ba405b9b94d934 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Hide the Kconfig option to run FSP-M XIP
by Arthur Heymans (Code Review) 04 Nov '19

04 Nov '19

Hello Patrick Rudolph, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36170 to look at the new patch set (#5). Change subject: drivers/intel/fsp2_0: Hide the Kconfig option to run FSP-M XIP ...................................................................... drivers/intel/fsp2_0: Hide the Kconfig option to run FSP-M XIP This is a property of the FSP, not something the user can decide. Change-Id: I2086e67d39e88215ee0f124583b810f7df072f80 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/36170/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/36170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2086e67d39e88215ee0f124583b810f7df072f80 Gerrit-Change-Number: 36170 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Hide CONFIG_FSP_CAR
by Arthur Heymans (Code Review) 04 Nov '19

04 Nov '19

Hello Patrick Rudolph, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36169 to look at the new patch set (#5). Change subject: drivers/intel/fsp2_0: Hide CONFIG_FSP_CAR ...................................................................... drivers/intel/fsp2_0: Hide CONFIG_FSP_CAR CONFIG_FSP_CAR should not be a user visible option, but depends on the choice presented in the soc Kconfig. This also removes the dependencies on ADD_FSP_BINARIES. You need to included those for other stages too so there is no need to make this requirement explicit for FSP-T. Change-Id: Ida32e9c4f5839aef4d4deb7a1c7fabe6335a5d2a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/36169/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/36169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida32e9c4f5839aef4d4deb7a1c7fabe6335a5d2a Gerrit-Change-Number: 36169 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: move cbmem_top_chipset from soc to fsp code
by Michael Niewöhner (Code Review) 04 Nov '19

04 Nov '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36615 ) Change subject: drivers/intel/fsp2_0: move cbmem_top_chipset from soc to fsp code ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/36615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6200badaab64285156ab78b48ba405b9b94d934 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 04 Nov 2019 20:55:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/ebda: Drop code
by Arthur Heymans (Code Review) 04 Nov '19

04 Nov '19

Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36362 to look at the new patch set (#23). Change subject: soc/intel/common/ebda: Drop code ...................................................................... soc/intel/common/ebda: Drop code There is no need to use EBDA to pass cbmem_top from romstage to later stages. Change-Id: I46e2459ff3c785f530cabc5930004ef920ffc89a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- D src/soc/intel/cannonlake/include/soc/ebda.h D src/soc/intel/common/block/ebda/Kconfig D src/soc/intel/common/block/ebda/Makefile.inc D src/soc/intel/common/block/ebda/ebda.c D src/soc/intel/common/block/include/intelblocks/ebda.h D src/soc/intel/icelake/include/soc/ebda.h D src/soc/intel/skylake/include/soc/ebda.h 7 files changed, 0 insertions(+), 161 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36362/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/36362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46e2459ff3c785f530cabc5930004ef920ffc89a Gerrit-Change-Number: 36362 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/ebda: Drop code
by Arthur Heymans (Code Review) 04 Nov '19

04 Nov '19

Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/36362 to look at the new patch set (#22). Change subject: soc/intel/common/ebda: Drop code ...................................................................... soc/intel/common/ebda: Drop code There is no need to use EBDA to pass cbmem_top from romstage to later stages. Change-Id: I46e2459ff3c785f530cabc5930004ef920ffc89a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/cannonlake/Kconfig D src/soc/intel/cannonlake/include/soc/ebda.h D src/soc/intel/common/block/ebda/Kconfig D src/soc/intel/common/block/ebda/Makefile.inc D src/soc/intel/common/block/ebda/ebda.c D src/soc/intel/common/block/include/intelblocks/ebda.h M src/soc/intel/common/block/systemagent/memmap.c M src/soc/intel/icelake/Kconfig D src/soc/intel/icelake/include/soc/ebda.h M src/soc/intel/skylake/Kconfig D src/soc/intel/skylake/include/soc/ebda.h 11 files changed, 2 insertions(+), 184 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36362/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/36362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46e2459ff3c785f530cabc5930004ef920ffc89a Gerrit-Change-Number: 36362 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2019