coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 11: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75322/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29374/ : SUCCESS -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing … [View More]

1 0

Change in coreboot[master]: soc/intel/apollolake: Enable logging for wake sources in S0ix
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27234 ) Change subject: soc/intel/apollolake: Enable logging for wake sources in S0ix ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29372/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75320/ : SUCCESS -- To view, visit https://review.coreboot.org/27234 To unsubscribe, or for … [View More]

1 0

Change in coreboot[master]: mb/google/octopus: Enable logging of EC wake sources in S0ix
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27235 ) Change subject: mb/google/octopus: Enable logging of EC wake sources in S0ix ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29373/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75321/ : SUCCESS -- To view, visit https://review.coreboot.org/27235 To unsubscribe, or for help writing … [View More]

1 0

Change in coreboot[master]: mb/google/octopus: Enable logging of EC wake sources in S0ix
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27235 ) Change subject: mb/google/octopus: Enable logging of EC wake sources in S0ix ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29371/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75319/ : SUCCESS -- To view, visit https://review.coreboot.org/27235 To unsubscribe, or for help … [View More]

1 0

Change in coreboot[master]: soc/intel/apollolake: Enable logging for wake sources in S0ix
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27234 ) Change subject: soc/intel/apollolake: Enable logging for wake sources in S0ix ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29370/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75318/ : SUCCESS -- To view, visit https://review.coreboot.org/27234 To unsubscribe, or for … [View More]

1 0

Change in coreboot[master]: mb/google/octopus: Enable logging of EC wake sources in S0ix
by Furquan Shaikh (Code Review) 25 Jun '18

25 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27235 Change subject: mb/google/octopus: Enable logging of EC wake sources in S0ix ...................................................................... mb/google/octopus: Enable logging of EC wake sources in S0ix This change adds GSMI callback elog_gsmi_cb_mainboard_log_wake_source to enable logging of EC wake events in S0ix. BUG=b:79449585 TEST=Verified that S0ix entry/exit events are added to eventlog: ==… [View More]

1 0

Change in coreboot[master]: soc/intel/apollolake: Enable logging for wake sources in S0ix
by Furquan Shaikh (Code Review) 25 Jun '18

25 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27234 Change subject: soc/intel/apollolake: Enable logging for wake sources in S0ix ...................................................................... soc/intel/apollolake: Enable logging for wake sources in S0ix This change adds GSMI callback elog_gsmi_cb_platform_log_wake_source to enable wake source logging from S0ix on APL/GLK. Additionally, elog.c is added to smm stage. BUG=b:79449585 TEST=Verified … [View More]that S0ix entry/exit events are added to eventlog: =========== Power button ============ 59 | 2018-06-25 14:01:11 | S0ix Enter 60 | 2018-06-25 14:01:30 | S0ix Exit 61 | 2018-06-25 14:02:00 | Wake Source | Power Button | 0 =========== Lid open ================ 62 | 2018-06-25 14:02:36 | S0ix Enter 63 | 2018-06-25 14:02:56 | S0ix Exit 64 | 2018-06-25 14:03:26 | Wake Source | GPE # | 15 65 | 2018-06-25 14:03:32 | Wake Source | GPE # | 65 66 | 2018-06-25 14:03:37 | EC Event | Lid Open =========== Trackpad ================ 67 | 2018-06-25 14:04:20 | S0ix Enter 68 | 2018-06-25 14:04:33 | S0ix Exit 69 | 2018-06-25 14:05:03 | Wake Source | GPE # | 15 70 | 2018-06-25 14:05:08 | Wake Source | GPE # | 66 Change-Id: I005de58c73d00dc9d7e64f1459f6d786792b94db Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/apollolake/Makefile.inc M src/soc/intel/apollolake/elog.c 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27234/1 diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.inc index 9b09b09..cb66365 100644 --- a/src/soc/intel/apollolake/Makefile.inc +++ b/src/soc/intel/apollolake/Makefile.inc @@ -43,6 +43,7 @@ smm-y += smihandler.c smm-y += spi.c smm-$(CONFIG_SOC_UART_DEBUG) += uart.c +smm-y += elog.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c ramstage-y += cpu.c diff --git a/src/soc/intel/apollolake/elog.c b/src/soc/intel/apollolake/elog.c index 1e9b7d8..cbd13a8 100644 --- a/src/soc/intel/apollolake/elog.c +++ b/src/soc/intel/apollolake/elog.c @@ -18,6 +18,7 @@ #include <cbmem.h> #include <console/console.h> #include <elog.h> +#include <intelblocks/pmclib.h> #include <soc/pm.h> #include <soc/pci_devs.h> #include <stdint.h> @@ -57,7 +58,8 @@ elog_add_event_wake(ELOG_WAKE_SOURCE_SMBUS, 0); /* ACPI Wake Event - Always Log prev_sleep_state*/ - elog_add_event_byte(ELOG_TYPE_ACPI_WAKE, ps->prev_sleep_state); + if (ps->prev_sleep_state != ACPI_S0) + elog_add_event_byte(ELOG_TYPE_ACPI_WAKE, ps->prev_sleep_state); /* Log GPIO events in set A-D */ pch_log_gpio_gpe(ps->gpe0_sts[GPE0_A], ps->gpe0_en[GPE0_A], 0); @@ -105,3 +107,11 @@ if (ps->prev_sleep_state > ACPI_S0) pch_log_wake_source(ps); } + +void elog_gsmi_cb_platform_log_wake_source(void) +{ + struct chipset_power_state ps; + + pmc_fill_pm_reg_info(&ps); + pch_log_wake_source(&ps); +} -- To view, visit https://review.coreboot.org/27234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I005de58c73d00dc9d7e64f1459f6d786792b94db Gerrit-Change-Number: 27234 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> [View Less]

1 0

Change in coreboot[master]: smm: Add canary to end of stack and die() if a stack overflow occurs
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27229 ) Change subject: smm: Add canary to end of stack and die() if a stack overflow occurs ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29369/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75317/ : SUCCESS -- To view, visit https://review.coreboot.org/27229 To unsubscribe, or … [View More]

1 0

Change in coreboot[master]: smm: Switch from %edx to %ebx
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27228 ) Change subject: smm: Switch from %edx to %ebx ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29368/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75316/ : SUCCESS -- To view, visit https://review.coreboot.org/27228 To unsubscribe, or for help writing mail filters, visit … [View More]

1 0

Change in coreboot[master]: smm: Push a null stack base pointer
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27226 ) Change subject: smm: Push a null stack base pointer ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29367/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75315/ : SUCCESS -- To view, visit https://review.coreboot.org/27226 To unsubscribe, or for help writing mail filters, … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018