Nico Huber has posted comments on this change. ( https://review.coreboot.org/27222 )
Change subject: mb/google/*: Add a few VBT files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/27222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f05c913872c5d2d8c8279d89eac52fd4bf4e35e
Gerrit-Change-Number: 27222
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 25 Jun 2018 17:59:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/27223
Change subject: mb/google/octopus: Create bobba variant
......................................................................
mb/google/octopus: Create bobba variant
This creates a bobba variant for octopus. Nothing is set in the variant
files here; everything is picked up from baseboard.
BUG=b:110781720
TEST=None
Change-Id: Ic30c6b0d955ce26f4a9f40cd7fef1c429ab950fc
Signed-off-by: Justin TerAvest <teravest(a)chromium.org>
---
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/octopus/Kconfig.name
A src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl
A src/mainboard/google/octopus/variants/bobba/include/variant/ec.h
A src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h
5 files changed, 68 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/27223/1
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig
index 226e44f..06f5786 100644
--- a/src/mainboard/google/octopus/Kconfig
+++ b/src/mainboard/google/octopus/Kconfig
@@ -43,6 +43,7 @@
default "bip" if BOARD_GOOGLE_BIP
default "phaser" if BOARD_GOOGLE_PHASER
default "fleex" if BOARD_GOOGLE_FLEEX
+ default "bobba" if BOARD_GOOGLE_BOBBA
default "octopus" if BOARD_GOOGLE_OCTOPUS
config DEVICETREE
@@ -56,6 +57,7 @@
default "Bip" if BOARD_GOOGLE_BIP
default "Phaser" if BOARD_GOOGLE_PHASER
default "Fleex" if BOARD_GOOGLE_FLEEX
+ default "Bobba" if BOARD_GOOGLE_BOBBA
default "Octopus" if BOARD_GOOGLE_OCTOPUS
config MAINBOARD_FAMILY
@@ -69,6 +71,7 @@
default "BIP TEST 5732" if BOARD_GOOGLE_BIP
default "PHASER TEST 7167" if BOARD_GOOGLE_PHASER
default "FLEEX TEST 7423" if BOARD_GOOGLE_FLEEX
+ default "BOBBA TEST 4516" if BOARD_GOOGLE_BOBBA
default "OCTOPUS TEST 6859" if BOARD_GOOGLE_OCTOPUS
config MAX_CPUS
diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name
index f30b46f..cfe051c 100644
--- a/src/mainboard/google/octopus/Kconfig.name
+++ b/src/mainboard/google/octopus/Kconfig.name
@@ -30,3 +30,10 @@
select BOARD_GOOGLE_BASEBOARD_OCTOPUS
select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS
select NHLT_DA7219 if INCLUDE_NHLT_BLOBS
+
+config BOARD_GOOGLE_BOBBA
+ bool "-> Bobba"
+ select BASEBOARD_OCTOPUS_LAPTOP
+ select BOARD_GOOGLE_BASEBOARD_OCTOPUS
+ select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS
+ select NHLT_DA7219 if INCLUDE_NHLT_BLOBS
diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl b/src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl
new file mode 100644
index 0000000..cc17d56
--- /dev/null
+++ b/src/mainboard/google/octopus/variants/bobba/include/variant/acpi/dptf.asl
@@ -0,0 +1,16 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <baseboard/acpi/dptf.asl>
diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h
new file mode 100644
index 0000000..16f931b
--- /dev/null
+++ b/src/mainboard/google/octopus/variants/bobba/include/variant/ec.h
@@ -0,0 +1,21 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef MAINBOARD_EC_H
+#define MAINBOARD_EC_H
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h b/src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h
new file mode 100644
index 0000000..1fd1e11
--- /dev/null
+++ b/src/mainboard/google/octopus/variants/bobba/include/variant/gpio.h
@@ -0,0 +1,21 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 Google LLC
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef MAINBOARD_GPIO_H
+#define MAINBOARD_GPIO_H
+
+#include <baseboard/gpio.h>
+
+#endif /* MAINBOARD_GPIO_H */
--
To view, visit https://review.coreboot.org/27223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic30c6b0d955ce26f4a9f40cd7fef1c429ab950fc
Gerrit-Change-Number: 27223
Gerrit-PatchSet: 1
Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org>