coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27220 ) Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29394/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75343/ : SUCCESS -- To view, visit https://review.coreboot.org/27220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 00:42:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
by Furquan Shaikh (Code Review) 25 Jun '18

25 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27220 ) Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 00:37:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
by Seunghwan Kim (Code Review) 25 Jun '18

25 Jun '18

Hello Philip Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27220 to look at the new patch set (#3). Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU ...................................................................... mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU We would use GPP_B20 instead of board id to determine nautilus SKU. BUG=b:80052672 BRANCH=poppy TEST=Verified the new coreboot could determine SKU correctly Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> --- M src/mainboard/google/poppy/variants/nautilus/mainboard.c 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/27220/3 -- To view, visit https://review.coreboot.org/27220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27220 ) Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75342/ : SUCCESS -- To view, visit https://review.coreboot.org/27220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 00:34:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
by Furquan Shaikh (Code Review) 25 Jun '18

25 Jun '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27220 ) Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27220/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nautilus/mainboard.c: https://review.coreboot.org/#/c/27220/2/src/mainboard/google/poppy/variants… PS2, Line 16: boardid is this still needed? -- To view, visit https://review.coreboot.org/27220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 00:33:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU
by Seunghwan Kim (Code Review) 25 Jun '18

25 Jun '18

Hello Philip Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27220 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU ...................................................................... mb/google/poppy/variants/nautilus: Use GPP_B20 to determine SKU We would use GPP_B20 instead of board id to determine nautilus SKU. BUG=b:80052672 BRANCH=poppy TEST=Verified the new coreboot could determine SKU correctly Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> --- M src/mainboard/google/poppy/variants/nautilus/mainboard.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/27220/2 -- To view, visit https://review.coreboot.org/27220 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1978b544eef7a184a3da191306ee32d862fa8c36 Gerrit-Change-Number: 27220 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/common: change mca_configure API's def
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

1 0

Change in coreboot[master]: intel/common: change mca_configure API's def
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

1 0

Change in coreboot[master]: intel/common: change mca_configure API's def
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26391 ) Change subject: intel/common: change mca_configure API's def ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/cpu/cpul… File src/soc/intel/common/block/cpu/cpulib.c: https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/cpu/cpul… PS2, Line 309: printk(BIOS_DEBUG, "CPU: mca_configure num banks %d\n", num_banks); Prefer using '"%s...", __func__' to using 'mca_configure', this function's name, in a string https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/include/… File src/soc/intel/common/block/include/intelblocks/cpulib.h: https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/include/… PS2, Line 160: void mca_configure(void* unused); "foo* bar" should be "foo *bar" -- To view, visit https://review.coreboot.org/26391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2395ee7fbedc829f040959b0021967f800693eeb Gerrit-Change-Number: 26391 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 25 Jun 2018 23:36:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable camera sensors
by build bot (Jenkins) (Code Review) 25 Jun '18

25 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26283 ) Change subject: mainboard/google/nocturne: Enable camera sensors ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29375/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75323/ : SUCCESS -- To view, visit https://review.coreboot.org/26283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c877df8062d5c79e25ed27775ab58e977555db Gerrit-Change-Number: 26283 Gerrit-PatchSet: 12 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward #1002003 Gerrit-Comment-Date: Mon, 25 Jun 2018 22:14:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018