coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: [WIP]soc/intel/common: Add bootblock common stage file
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18457 ) Change subject: [WIP]soc/intel/common: Add bootblock common stage file ...................................................................... Patch Set 18: (1 comment) https://review.coreboot.org/#/c/18457/18/src/soc/intel/common/basecode/boot… File src/soc/intel/common/basecode/bootblock/bootblock.c: https://review.coreboot.org/#/c/18457/18/src/soc/intel/common/basecode/boot… PS18, Line 55: return (struct bootblock_ops*)&g_bb_ops; "(foo*)" should be "(foo *)" -- To view, visit https://review.coreboot.org/18457 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1 Gerrit-Change-Number: 18457 Gerrit-PatchSet: 18 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 26 Jun 2018 23:24:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/crossgcc: update to gcc 8.1.0 and binutils 2.30
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25997 ) Change subject: util/crossgcc: update to gcc 8.1.0 and binutils 2.30 ...................................................................... Patch Set 20: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29434/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75384/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/442/ : SUCCESS -- To view, visit https://review.coreboot.org/25997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e8074954d5d7a4eff590abb7439e9be7d3762aa Gerrit-Change-Number: 25997 Gerrit-PatchSet: 20 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:42:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/crossgcc: Allow building a new gcc against new binutils with -D
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27241 ) Change subject: util/crossgcc: Allow building a new gcc against new binutils with -D ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29435/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75385/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/443/ : SUCCESS -- To view, visit https://review.coreboot.org/27241 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a262e73f56cd486a2ae07422b598c205a03aed Gerrit-Change-Number: 27241 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:35:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/p4-netburst: skip caching rom on model_fxx
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27133 ) Change subject: cpu/intel/p4-netburst: skip caching rom on model_fxx ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29447/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75397/ : SUCCESS -- To view, visit https://review.coreboot.org/27133 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1df84ad55e2d8d6d4e8dca10125131b5f525f0d7 Gerrit-Change-Number: 27133 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:28:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cheza: Add board ID, RAM code and SKU ID
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27247 ) Change subject: cheza: Add board ID, RAM code and SKU ID ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75396/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/29446/ : SUCCESS -- To view, visit https://review.coreboot.org/27247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6437bbd03bdd9aab5ac71b8b3eda23e92a88d052 Gerrit-Change-Number: 27247 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: T Michael Turney <mturney(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:08:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arm64: Reimplement mmu_disable() in assembly
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27238 ) Change subject: arm64: Reimplement mmu_disable() in assembly ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29444/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75394/ : SUCCESS -- To view, visit https://review.coreboot.org/27238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic552960c91400dadae6f130b2521a696eeb4c0b1 Gerrit-Change-Number: 27238 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: T Michael Turney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:02:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity
by Nick Vaccaro (Code Review) 26 Jun '18

26 Jun '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 ) Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/gpio.c: https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants… PS1, Line 134: NONE I suggest a 20k internal pd, see comment below. https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants… PS1, Line 138: NONE a 20k pulldown here would help for preEVT2 devices (preEVT2 is missing a pd in hw on this line; EVT2 will have a hardware pd on this line, but I think a 20k pd here should allow this to work with both preEVT2 and EVT2 devices) -- To view, visit https://review.coreboot.org/27221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56c13c797b133dd22669a2299bcd16ef14eed335 Gerrit-Change-Number: 27221 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 26 Jun 2018 20:01:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: arm64: Switch remaining uses of __ASSEMBLY__ to __ASSEMBLER__
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27237 ) Change subject: arm64: Switch remaining uses of __ASSEMBLY__ to __ASSEMBLER__ ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29443/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75393/ : SUCCESS -- To view, visit https://review.coreboot.org/27237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1023f72dd13857b14ce060388e97c658e748928f Gerrit-Change-Number: 27237 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 19:57:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arm64: Drop dead file stage_entry.S
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27236 ) Change subject: arm64: Drop dead file stage_entry.S ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29442/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75392/ : SUCCESS -- To view, visit https://review.coreboot.org/27236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dd6666371036ecd42c1b256dbbe22a01ae959b8 Gerrit-Change-Number: 27236 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 19:52:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/skylake: add a space in printing ME FPF status
by build bot (Jenkins) (Code Review) 26 Jun '18

26 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27246 ) Change subject: soc/intel/skylake: add a space in printing ME FPF status ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29441/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75391/ : SUCCESS -- To view, visit https://review.coreboot.org/27246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15c02045d0f94fdb3f4a028585cad488d4ac9aa6 Gerrit-Change-Number: 27246 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Jun 2018 19:48:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018