coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: mainboard/google/nocturne: Enable IPU3
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27124 ) Change subject: mainboard/google/nocturne: Enable IPU3 ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29479/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75428/ : SUCCESS -- To view, visit https://review.coreboot.org/27124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2edf5ec7bde5c55ce1b13cf7b680094a9fffc6a Gerrit-Change-Number: 27124 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 20:11:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable camera sensors
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26283 ) Change subject: mainboard/google/nocturne: Enable camera sensors ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29477/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75426/ : SUCCESS -- To view, visit https://review.coreboot.org/26283 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37c877df8062d5c79e25ed27775ab58e977555db Gerrit-Change-Number: 26283 Gerrit-PatchSet: 14 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anonymous Coward #1002003 Gerrit-CC: Ricky Liang <jcliang(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Jun 2018 20:10:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29478/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75427/ : SUCCESS -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 15 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 20:08:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable p-states
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27257 ) Change subject: mb/google/poppy/variants/nocturne: enable p-states ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29476/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75425/ : SUCCESS -- To view, visit https://review.coreboot.org/27257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Puthikorn “Opal” Voravootivat <puthik(a)google.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 18:54:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable p-states
by Pratikkumar V Prajapati (Code Review) 27 Jun '18

27 Jun '18

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/27257 ) Change subject: mb/google/poppy/variants/nocturne: enable p-states ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27257/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/devicetree.cb: https://review.coreboot.org/#/c/27257/1/src/mainboard/google/poppy/variants… PS1, Line 63: # Disable P-States > Remove this comment Done -- To view, visit https://review.coreboot.org/27257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Puthikorn “Opal” Voravootivat <puthik(a)google.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 18:49:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable p-states
by Pratikkumar V Prajapati (Code Review) 27 Jun '18

27 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27257 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nocturne: enable p-states ...................................................................... mb/google/poppy/variants/nocturne: enable p-states This patch enables p-states for nocturne which was disabled by Change-Id: I71ed4c80c109b28ffa85d48338ce3a62396d272e Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/27257/2 -- To view, visit https://review.coreboot.org/27257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Puthikorn “Opal” Voravootivat <puthik(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable p-states
by Puthikorn “Opal” Voravootivat (Code Review) 27 Jun '18

27 Jun '18

Puthikorn “Opal” Voravootivat has posted comments on this change. ( https://review.coreboot.org/27257 ) Change subject: mb/google/poppy/variants/nocturne: enable p-states ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27257/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/devicetree.cb: https://review.coreboot.org/#/c/27257/1/src/mainboard/google/poppy/variants… PS1, Line 63: # Disable P-States Remove this comment -- To view, visit https://review.coreboot.org/27257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Puthikorn “Opal” Voravootivat <puthik(a)google.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 18:39:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable p-states
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27257 ) Change subject: mb/google/poppy/variants/nocturne: enable p-states ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29475/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75424/ : SUCCESS -- To view, visit https://review.coreboot.org/27257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Jun 2018 18:37:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity
by Nick Vaccaro (Code Review) 27 Jun '18

27 Jun '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 ) Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/gpio.c: https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants… PS1, Line 138: NONE > If signal is active low, why did you change this definition from "_INVERT" ? IF it's a double-mappi […] I've talked with Duncan and Aaron about this, and they have better explained to me how and where the various definitions come into play, and based on their input, your change with regard to removing "_INVERT" should be fine, please ignore my last comment. -- To view, visit https://review.coreboot.org/27221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56c13c797b133dd22669a2299bcd16ef14eed335 Gerrit-Change-Number: 27221 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Vincent Palatin <vpalatin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 18:35:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable p-states
by Pratikkumar V Prajapati (Code Review) 27 Jun '18

27 Jun '18

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/27257 Change subject: mb/google/poppy/variants/nocturne: enable p-states ...................................................................... mb/google/poppy/variants/nocturne: enable p-states This patch enables p-states for nocturne which was disabled by Change-Id: I71ed4c80c109b28ffa85d48338ce3a62396d272e Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/27257/1 diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 0797f62..3b97856 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -61,7 +61,7 @@ register "VmxEnable" = "1" # Disable P-States - register "speed_shift_enable" = "0" + register "speed_shift_enable" = "1" register "dptf_enable" = "1" register "tdp_pl2_override" = "15" register "psys_pmax" = "45" -- To view, visit https://review.coreboot.org/27257 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Gerrit-Change-Number: 27257 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018