coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: soc/intel/apollolake: Enable early mmc CMD0, CMD1 for GLK
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

1 0

Change in coreboot[master]: intel/common/block/scs: Add ability to send early CMD0, CMD1
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

1 0

Change in coreboot[master]: intel/common/block/scs: Add ability to send early CMD0, CMD1
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25068 ) Change subject: intel/common/block/scs: Add ability to send early CMD0, CMD1 ...................................................................... Patch Set 8: (13 comments) https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/include/… File src/soc/intel/common/block/include/intelblocks/early_mmc.h: https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/include/… PS8, Line 26: * emmc_rx_cmd_data_cntl1: Rx CMD Data Delay Control 1 (Rx_CMD_Data_dly_1)—Offset 82Ch line over 80 characters https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/include/… PS8, Line 27: * emmc_rx_strobe_cntl: Rx Strobe Delay Control (Rx_Strobe_Ctrl_Path)—Offset 830h line over 80 characters https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/include/… PS8, Line 28: * emmc_rx_cmd_data_cntl2: Rx CMD Data Path Delay Control 2 (Rx_CMD_Data_dly_2)—Offset 834h line over 80 characters https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… File src/soc/intel/common/block/scs/early_mmc.c: https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 56: *ctrlr) code indent should use tabs where possible https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 56: *ctrlr) please, no spaces at the start of a line https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 91: write32(ioaddr + EMMC_TX_DATA_CNTL1_OFFSET, trailing whitespace https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 93: write32(ioaddr + EMMC_TX_DATA_CNTL2_OFFSET, trailing whitespace https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 95: write32(ioaddr + EMMC_RX_CMD_DATA_CNTL1_OFFSET, trailing whitespace https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 97: write32(ioaddr + EMMC_RX_CMD_DATA_CNTL2_OFFSET, trailing whitespace https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 99: write32(ioaddr + EMMC_RX_STROBE_CNTL_OFFSET, trailing whitespace https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 145: mmc_ctrlr = new_mem_sdhci_controller((void*) ioaddr); "(foo*)" should be "(foo *)" https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 148: if (set_mmc_dll((void*) ioaddr) < 0) that open brace { should be on the previous line https://review.coreboot.org/#/c/25068/8/src/soc/intel/common/block/scs/earl… PS8, Line 148: if (set_mmc_dll((void*) ioaddr) < 0) "(foo*)" should be "(foo *)" -- To view, visit https://review.coreboot.org/25068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3488b077bf5100a1e0f2c879fb1436105607d25e Gerrit-Change-Number: 25068 Gerrit-PatchSet: 8 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:40:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: coreboot_tables: pass the early_mmc_wake_hw status to payload
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25464 ) Change subject: coreboot_tables: pass the early_mmc_wake_hw status to payload ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/75443/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/29493/ : SUCCESS -- To view, visit https://review.coreboot.org/25464 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c57d05433c3966118c3642913d7017958cce55 Gerrit-Change-Number: 25464 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:40:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Enable early mmc CMD0, CMD1 for GLK
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25514 ) Change subject: soc/intel/apollolake: Enable early mmc CMD0, CMD1 for GLK ...................................................................... Patch Set 5: (6 comments) https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.c File src/soc/intel/apollolake/early_mmc.c: https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.… PS5, Line 25: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_104, UP_20K, DEEP, NF1),/*EMMC_DNX_PWR_EN_B*/ line over 80 characters https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.… PS5, Line 37: PAD_CFG_NF_IOSSTATE(GPIO_209, DN_20K, DEEP, NF1, HIZCRx0)/*EMMC0_STROBE*/ line over 80 characters https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.… PS5, Line 61: __func__); code indent should use tabs where possible https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/early_mmc.… PS5, Line 61: __func__); please, no spaces at the start of a line https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c File src/soc/intel/apollolake/romstage.c: https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c… PS5, Line 207: printk(BIOS_DEBUG, "Early mmc initilization failed \n"); 'initilization' may be misspelled - perhaps 'initialization'? https://review.coreboot.org/#/c/25514/5/src/soc/intel/apollolake/romstage.c… PS5, Line 207: printk(BIOS_DEBUG, "Early mmc initilization failed \n"); unnecessary whitespace before a quoted newline -- To view, visit https://review.coreboot.org/25514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4e791607059d12b3f5692f6404cb9eb39d79f6d Gerrit-Change-Number: 25514 Gerrit-PatchSet: 5 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:40:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: commonlib/storage: Make sd_mmc_go_idle an api
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25066 ) Change subject: commonlib/storage: Make sd_mmc_go_idle an api ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29491/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75441/ : SUCCESS -- To view, visit https://review.coreboot.org/25066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I064a9bded347be5d500047df92d1c448c3392016 Gerrit-Change-Number: 25066 Gerrit-PatchSet: 5 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:40:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: coreboot_tables: pass the early_mmc_wake_hw status to payload
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25464 ) Change subject: coreboot_tables: pass the early_mmc_wake_hw status to payload ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/25464/6/payloads/libpayload/include/sysinfo… File payloads/libpayload/include/sysinfo.h: https://review.coreboot.org/#/c/25464/6/payloads/libpayload/include/sysinfo… PS6, Line 132: int mmc_early_wake_status; please, no space before tabs -- To view, visit https://review.coreboot.org/25464 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c57d05433c3966118c3642913d7017958cce55 Gerrit-Change-Number: 25464 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:39:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 20: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/29489/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/75439/ : ABORTED -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 20 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:37:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Enable IPU3
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27124 ) Change subject: mainboard/google/nocturne: Enable IPU3 ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75438/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29488/ : SUCCESS -- To view, visit https://review.coreboot.org/27124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2edf5ec7bde5c55ce1b13cf7b680094a9fffc6a Gerrit-Change-Number: 27124 Gerrit-PatchSet: 6 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:05:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/nocturne: Set camera power sequence
by build bot (Jenkins) (Code Review) 27 Jun '18

27 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27094 ) Change subject: mainboard/google/nocturne: Set camera power sequence ...................................................................... Patch Set 19: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/75437/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/29487/ : SUCCESS -- To view, visit https://review.coreboot.org/27094 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4833c0e303174b297c1d193495e08e55d294a717 Gerrit-Change-Number: 27094 Gerrit-PatchSet: 19 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Chiranjeevi Rapolu <chiranjeevi.rapolu(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tomasz Figa <tfiga(a)google.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:01:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018