TH Lin has posted comments on this change. ( https://review.coreboot.org/27275 )
Change subject: mb/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd: byte 145~146
......................................................................
Patch Set 1:
spd file for product name should be 18 char...
--
To view, visit https://review.coreboot.org/27275
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc820111f0aed34e5b46d7e23dff44cb5bb811d
Gerrit-Change-Number: 27275
Gerrit-PatchSet: 1
Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 06:36:45 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
TH Lin has abandoned this change. ( https://review.coreboot.org/27274 )
Change subject: mb/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd: byte 145~146
......................................................................
Abandoned
fail on merge
--
To view, visit https://review.coreboot.org/27274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I72e201399e57af19dd5b58a957af51f2071d79b3
Gerrit-Change-Number: 27274
Gerrit-PatchSet: 1
Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
TH Lin has posted comments on this change. ( https://review.coreboot.org/27274 )
Change subject: mb/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd: byte 145~146
......................................................................
Patch Set 1:
Yes, under retry
--
To view, visit https://review.coreboot.org/27274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e201399e57af19dd5b58a957af51f2071d79b3
Gerrit-Change-Number: 27274
Gerrit-PatchSet: 1
Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 06:30:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27274 )
Change subject: mb/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd: byte 145~146
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27274/1/src/mainboard/google/poppy/spd/nayn…
File src/mainboard/google/poppy/spd/nayna_dimm_NT6CL256T32CM-H1.spd.hex:
PS1:
I guess you just wanted to update the required bytes since a file with this name already exists.
--
To view, visit https://review.coreboot.org/27274
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e201399e57af19dd5b58a957af51f2071d79b3
Gerrit-Change-Number: 27274
Gerrit-PatchSet: 1
Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 06:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No