build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 )
Change subject: soc/intel/common/block: Move common uart function to block/uart
......................................................................
Patch Set 34:
(1 comment)
https://review.coreboot.org/#/c/26164/34/src/soc/intel/apollolake/uart.c
File src/soc/intel/apollolake/uart.c:
https://review.coreboot.org/#/c/26164/34/src/soc/intel/apollolake/uart.c@73
PS34, Line 73: else
else is not generally useful after a break or return
--
To view, visit https://review.coreboot.org/26164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6
Gerrit-Change-Number: 26164
Gerrit-PatchSet: 34
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Comment-Date: Sat, 09 Jun 2018 17:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No