coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: util/sconfig: Change chip_queue to be more generic
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26737 ) Change subject: util/sconfig: Change chip_queue to be more generic ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73839/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/27952/ : SUCCESS -- To view, visit https://review.coreboot.org/26737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Gerrit-Change-Number: 26737 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:42:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of struct header
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26739 ) Change subject: util/sconfig: Get rid of struct header ...................................................................... Patch Set 1: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/27954/ : SUCCESS -- To view, visit https://review.coreboot.org/26739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Gerrit-Change-Number: 26739 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:42:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Change chip_queue to be more generic
by Furquan Shaikh (Code Review) 31 May '18

31 May '18

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/26737 ) Change subject: util/sconfig: Change chip_queue to be more generic ...................................................................... util/sconfig: Change chip_queue to be more generic This CL changes chip_queue to be more generic to allow any data to be added/removed to/from queue. BUG=b:80081934 Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h M util/sconfig/sconfig.tab.c_shipped M util/sconfig/sconfig.y 4 files changed, 25 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/26737/2 -- To view, visit https://review.coreboot.org/26737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Gerrit-Change-Number: 26737 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/kahlee: Remove #include <soc/smi.h>
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26721 ) Change subject: mb/google/kahlee: Remove #include <soc/smi.h> ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73838/ : SUCCESS -- To view, visit https://review.coreboot.org/26721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69 Gerrit-Change-Number: 26721 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Thu, 31 May 2018 17:40:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Get rid of struct header
by Furquan Shaikh (Code Review) 31 May '18

31 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26739 Change subject: util/sconfig: Get rid of struct header ...................................................................... util/sconfig: Get rid of struct header Now that chips and devices are treated differently in sconfig, this change gets rid of struct header and add_header function which were responsible for maintaining list of headers that need to be added to static.c. Instead, struct chip is re-factored into struct chip and struct chip_instance, where chip is a list of unique chips required by the mainboard whereas chip_instance is an instance of the chip. One chip can have multiple instances dependending upon the devices in the system. Also, struct device is updated to hold a pointer to chip instance instead of the chip structure. This unique list of chips is then used to add appropriate headers to static.c BUG=b:80081934 TEST=Verified using abuild that all boards compile successfully. Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h M util/sconfig/sconfig.tab.c_shipped M util/sconfig/sconfig.y 4 files changed, 135 insertions(+), 111 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/26739/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 8287cce..32d7aac 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -22,7 +22,7 @@ struct device *head, *lastdev; -static struct chip *chip_head; +static struct chip chip_header; /* * This is intentionally shared between chip and device structure ids because it @@ -38,15 +38,24 @@ } translate_t; static struct device root; -static struct chip mainboard = { + +static struct chip_instance mainboard_instance; + +static struct chip mainboard_chip = { .name = "mainboard", .name_underscore = "mainboard", + .instance = &mainboard_instance, +}; + +static struct chip_instance mainboard_instance = { + .id = 0, + .chip = &mainboard_chip, }; static struct device root = { .name = "dev_root", .id = 0, - .chip = &mainboard, + .chip_instance = &mainboard_instance, .path = " .type = DEVICE_PATH_ROOT ", .ops = "&default_dev_ops_root", .parent = &root, @@ -205,14 +214,28 @@ return b; } -struct chip *new_chip(char *path) +static struct chip *get_chip(char *path) { - struct chip *new_chip = S_ALLOC(sizeof(*new_chip)); + struct chip *h = &chip_header; - new_chip->id = ++count; + while (h->next) { + int result = strcmp(path, h->next->name); + if (result == 0) + return h->next; + + if (result < 0) + break; + + h = h->next; + } + + struct chip *new_chip = S_ALLOC(sizeof(struct chip)); + new_chip->next = h->next; + h->next = new_chip; + new_chip->chiph_exists = 1; new_chip->name = path; - new_chip->name_underscore = translate_name(new_chip->name, UNSLASH); + new_chip->name_underscore = translate_name(path, UNSLASH); struct stat st; char *chip_h = S_ALLOC(strlen(path) + 18); @@ -235,13 +258,24 @@ free(chip_h); - new_chip->next = chip_head; - chip_head = new_chip; - return new_chip; } -struct device *new_device(struct device *parent, struct chip *chip, +struct chip_instance *new_chip_instance(char *path) +{ + struct chip *chip = get_chip(path); + struct chip_instance *instance = S_ALLOC(sizeof(*instance)); + + instance->id = ++count; + instance->chip = chip; + instance->next = chip->instance; + chip->instance = instance; + + return instance; +} + +struct device *new_device(struct device *parent, + struct chip_instance *chip_instance, const int bustype, const char *devnum, int enabled) { @@ -260,7 +294,7 @@ new_d->name = name; new_d->enabled = enabled; - new_d->chip = chip; + new_d->chip_instance = chip_instance; if (parent->latestchild) { parent->latestchild->next_sibling = new_d; @@ -367,14 +401,14 @@ dev->rescnt++; } -void add_register(struct chip *chip, char *name, char *val) +void add_register(struct chip_instance *chip_instance, char *name, char *val) { struct reg *r = S_ALLOC(sizeof(struct reg)); r->key = name; r->value = val; - if (chip->reg) { - struct reg *head = chip->reg; + if (chip_instance->reg) { + struct reg *head = chip_instance->reg; // sorting to be equal to sconfig's behaviour int sort = strcmp(r->key, head->key); if (sort == 0) { @@ -383,7 +417,7 @@ } if (sort < 0) { r->next = head; - chip->reg = r; + chip_instance->reg = r; } else { while ((head->next) && (strcmp(head->next->key, r->key) < 0)) @@ -392,7 +426,7 @@ head->next = r; } } else { - chip->reg = r; + chip_instance->reg = r; } } @@ -458,6 +492,7 @@ static void pass1(FILE * fil, struct device *ptr) { int pin; + struct chip_instance *chip_ins = ptr->chip_instance; if (!ptr->used) { if (ptr->id != 0) @@ -504,13 +539,13 @@ if (ptr->sibling) fprintf(fil, "\t.sibling = &%s,\n", ptr->sibling->name); fprintf(fil, "#if !DEVTREE_EARLY\n"); - fprintf(fil, "\t.chip_ops = &%s_ops,\n", ptr->chip->name_underscore); - if (ptr->chip == &mainboard) + fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore); + if (chip_ins == &mainboard_instance) fprintf(fil, "\t.name = mainboard_name,\n"); fprintf(fil, "#endif\n"); - if (ptr->chip->chiph_exists) + if (chip_ins->chip->chiph_exists) fprintf(fil, "\t.chip_info = &%s_info_%d,\n", - ptr->chip->name_underscore, ptr->chip->id); + chip_ins->chip->name_underscore, chip_ins->id); if (ptr->nextdev) fprintf(fil, "\t.next=&%s\n", ptr->nextdev->name); fprintf(fil, "};\n"); @@ -594,89 +629,70 @@ } while (ptr); } -static void add_header(struct chip *chip, struct header *h) +static void emit_chip_headers(FILE *fil) { - int include_exists = 0; - - while (h->next) { - int result = strcmp(chip->name, h->next->name); - if (result == 0) { - include_exists = 1; - break; - } - if (result < 0) - break; - h = h->next; - } - - if (!include_exists) { - struct header *tmp = h->next; - h->next = S_ALLOC(sizeof(struct header)); - - h->next->chiph_exists = chip->chiph_exists; - h->next->name = chip->name; - h->next->next = tmp; - } -} - -static void emit_headers(FILE *fil) -{ - struct header *h; - struct chip *chip; - struct header headers = {}; - - for (chip = chip_head; chip; chip = chip->next) - add_header(chip, &headers); + struct chip *chip = chip_header.next; fprintf(fil, "#include <device/device.h>\n"); fprintf(fil, "#include <device/pci.h>\n"); - h = &headers; - while (h->next) { - h = h->next; - if (h->chiph_exists) - fprintf(fil, "#include \"%s/chip.h\"\n", h->name); + + while (chip) { + if (chip->chiph_exists) + fprintf(fil, "#include \"%s/chip.h\"\n", chip->name); + chip = chip->next; } fprintf(fil, "\n#if !DEVTREE_EARLY\n"); fprintf(fil, "__attribute__((weak)) struct chip_operations mainboard_ops = {};\n"); - h = &headers; - while (h->next) { - h = h->next; - char *name_underscore = translate_name(h->name, UNSLASH); + + chip = chip_header.next; + while (chip) { fprintf(fil, "__attribute__((weak)) struct chip_operations %s_ops = {};\n", - name_underscore); - free(name_underscore); + chip->name_underscore); + chip = chip->next; } fprintf(fil, "#endif\n"); } +static void emit_chip_instance(FILE *fil, struct chip_instance *instance) +{ + if (instance->reg) { + fprintf(fil, + "DEVTREE_CONST struct %s_config %s_info_%d = {\n", + instance->chip->name_underscore, + instance->chip->name_underscore, + instance->id); + struct reg *r = instance->reg; + while (r) { + fprintf(fil, "\t.%s = %s,\n", r->key, r->value); + r = r->next; + } + fprintf(fil, "};\n\n"); + } else { + fprintf(fil, + "DEVTREE_CONST struct %s_config %s_info_%d = { };\n", + instance->chip->name_underscore, + instance->chip->name_underscore, + instance->id); + } +} + static void emit_chips(FILE *fil) { - struct chip *chip; + struct chip *chip = chip_header.next; + struct chip_instance *instance; - emit_headers(fil); + emit_chip_headers(fil); - for (chip = chip_head; chip; chip = chip->next) { + for (; chip; chip = chip->next) { if (!chip->chiph_exists) continue; - if (chip->reg) { - fprintf(fil, - "DEVTREE_CONST struct %s_config %s_info_%d = {\n", - chip->name_underscore, chip->name_underscore, - chip->id); - struct reg *r = chip->reg; - while (r) { - fprintf(fil, "\t.%s = %s,\n", r->key, r->value); - r = r->next; - } - fprintf(fil, "};\n\n"); - } else { - fprintf(fil, - "DEVTREE_CONST struct %s_config %s_info_%d = { };\n", - chip->name_underscore, chip->name_underscore, - chip->id); + instance = chip->instance; + while (instance) { + emit_chip_instance(fil, instance); + instance = instance->next; } } } diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index b9df91e..33176ae 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -42,13 +42,25 @@ int ioapic_dst_id; }; -struct chip { +struct chip; +struct chip_instance { /* * Monotonically increasing ID for each newly allocated * node(chip/device). */ int id; + /* Pointer to registers for this chip. */ + struct reg *reg; + + /* Pointer to chip of which this is instance. */ + struct chip *chip; + + /* Pointer to next instance of the same chip. */ + struct chip_instance *next; +}; + +struct chip { /* Indicates if chip header exists for this chip. */ int chiph_exists; @@ -58,8 +70,8 @@ /* Name of current chip normalized to _. */ char *name_underscore; - /* Pointer to registers for this chip. */ - struct reg *reg; + /* Pointer to first instance of this chip. */ + struct chip_instance *instance; /* Pointer to next chip. */ struct chip *next; @@ -93,28 +105,21 @@ struct device *sibling; struct resource *res; - struct chip *chip; + struct chip_instance *chip_instance; }; extern struct device *head; -struct header; -struct header { - char *name; - int chiph_exists; - struct header *next; -}; - void fold_in(struct device *parent); void postprocess_devtree(void); -struct chip *new_chip(char *path); -struct device *new_device(struct device *parent, struct chip *chip, + +struct device *new_device(struct device *parent, + struct chip_instance *chip_instance, const int bustype, const char *devnum, int enabled); void alias_siblings(struct device *d); void add_resource(struct device *dev, int type, int index, int base); -void add_register(struct chip *chip, char *name, char *val); void add_pci_subsystem_ids(struct device *dev, int vendor, int device, int inherit); void add_ioapic_info(struct device *dev, int apicid, const char *_srcpin, @@ -124,3 +129,6 @@ void enqueue(void *data); void *dequeue(void); + +struct chip_instance *new_chip_instance(char *path); +void add_register(struct chip_instance *chip, char *name, char *val); diff --git a/util/sconfig/sconfig.tab.c_shipped b/util/sconfig/sconfig.tab.c_shipped index 17bb31f..e774c2d 100644 --- a/util/sconfig/sconfig.tab.c_shipped +++ b/util/sconfig/sconfig.tab.c_shipped @@ -86,7 +86,7 @@ void yyerror(const char *s); static struct device *cur_parent; -static struct chip *cur_chip; +static struct chip *cur_chip_instance; @@ -1300,9 +1300,9 @@ case 14: { - (yyval.chip) = new_chip((yyvsp[0].string)); - enqueue(cur_chip); - cur_chip = (yyval.chip); + (yyval.chip) = new_chip_instance((yyvsp[0].string)); + enqueue(cur_chip_instance); + cur_chip_instance = (yyval.chip); } break; @@ -1310,7 +1310,7 @@ case 15: { - cur_chip = dequeue(); + cur_chip_instance = dequeue(); } break; @@ -1318,7 +1318,7 @@ case 16: { - (yyval.device) = new_device(cur_parent, cur_chip, (yyvsp[-2].number), (yyvsp[-1].string), (yyvsp[0].number)); + (yyval.device) = new_device(cur_parent, cur_chip_instance, (yyvsp[-2].number), (yyvsp[-1].string), (yyvsp[0].number)); cur_parent = (yyval.device); } @@ -1342,7 +1342,7 @@ case 19: - { add_register(cur_chip, (yyvsp[-2].string), (yyvsp[0].string)); } + { add_register(cur_chip_instance, (yyvsp[-2].string), (yyvsp[0].string)); } break; diff --git a/util/sconfig/sconfig.y b/util/sconfig/sconfig.y index 01ce92d..a1bcdee 100755 --- a/util/sconfig/sconfig.y +++ b/util/sconfig/sconfig.y @@ -21,7 +21,7 @@ void yyerror(const char *s); static struct device *cur_parent; -static struct chip *cur_chip; +static struct chip *cur_chip_instance; %} %union { @@ -40,16 +40,16 @@ devicechildren: devicechildren device | devicechildren chip | devicechildren resource | devicechildren subsystemid | devicechildren ioapic_irq | /* empty */ ; chip: CHIP STRING /* == path */ { - $<chip>$ = new_chip($<string>2); - enqueue(cur_chip); - cur_chip = $<chip>$; + $<chip>$ = new_chip_instance($<string>2); + enqueue(cur_chip_instance); + cur_chip_instance = $<chip>$; } chipchildren END { - cur_chip = dequeue(); + cur_chip_instance = dequeue(); }; device: DEVICE BUS NUMBER /* == devnum */ BOOL { - $<device>$ = new_device(cur_parent, cur_chip, $<number>2, $<string>3, $<number>4); + $<device>$ = new_device(cur_parent, cur_chip_instance, $<number>2, $<string>3, $<number>4); cur_parent = $<device>$; } devicechildren END { @@ -62,7 +62,7 @@ { add_resource(cur_parent, $<number>1, strtol($<string>2, NULL, 0), strtol($<string>4, NULL, 0)); } ; registers: REGISTER STRING /* == regname */ EQUALS STRING /* == regval */ - { add_register(cur_chip, $<string>2, $<string>4); } ; + { add_register(cur_chip_instance, $<string>2, $<string>4); } ; subsystemid: SUBSYSTEMID NUMBER NUMBER { add_pci_subsystem_ids(cur_parent, strtol($<string>2, NULL, 16), strtol($<string>3, NULL, 16), 0); }; -- To view, visit https://review.coreboot.org/26739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Gerrit-Change-Number: 26739 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: util/sconfig: Add helper function for allocating memory
by Furquan Shaikh (Code Review) 31 May '18

31 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26738 Change subject: util/sconfig: Add helper function for allocating memory ...................................................................... util/sconfig: Add helper function for allocating memory Add a helper function s_alloc (sconfig alloc) that allocates memory using calloc to get 0 initialized memory and checks to ensure it is not NULL. BUG=b:80081934 Change-Id: I56a70cf4865c50ed238226ace86e867bb1ec53db Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c 1 file changed, 23 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/26738/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 0659ecd..8287cce 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -59,14 +59,21 @@ struct queue *prev; } *q; -struct queue *new_entry(void *data) -{ - struct queue *e = malloc(sizeof(*e)); +#define S_ALLOC(_s) s_alloc(__func__, _s) - if (!e) { - fprintf(stderr, "%s: malloc failure!\n", __func__); +static void *s_alloc(const char *f, size_t s) +{ + void *data = calloc(1, s); + if (!data) { + fprintf(stderr, "%s: Failed to alloc mem!\n", f, s); exit(1); } + return data; +} + +struct queue *new_entry(void *data) +{ + struct queue *e = S_ALLOC(sizeof(*e)); e->data = data; e->next = e->prev = e; @@ -108,8 +115,8 @@ static struct device *new_dev(struct device *parent) { - struct device *dev = malloc(sizeof(struct device)); - memset(dev, 0, sizeof(struct device)); + struct device *dev = S_ALLOC(sizeof(struct device)); + dev->id = ++count; dev->parent = parent; dev->subsystem_vendor = -1; @@ -200,13 +207,7 @@ struct chip *new_chip(char *path) { - struct chip *new_chip = malloc(sizeof(*new_chip)); - if (!new_chip) { - fprintf(stderr, "%s: malloc failure!\n", __func__); - exit(1); - } - - memset(new_chip, 0, sizeof(*new_chip)); + struct chip *new_chip = S_ALLOC(sizeof(*new_chip)); new_chip->id = ++count; new_chip->chiph_exists = 1; @@ -214,7 +215,7 @@ new_chip->name_underscore = translate_name(new_chip->name, UNSLASH); struct stat st; - char *chip_h = malloc(strlen(path) + 18); + char *chip_h = S_ALLOC(strlen(path) + 18); sprintf(chip_h, "src/%s", path); if ((stat(chip_h, &st) == -1) && (errno == ENOENT)) { /* root_complex gets away without a separate directory, but @@ -254,7 +255,7 @@ new_d->path_b = strtol(tmp, NULL, 16); } - char *name = malloc(10); + char *name = S_ALLOC(10); sprintf(name, "_dev%d", new_d->id); new_d->name = name; @@ -350,8 +351,8 @@ void add_resource(struct device *dev, int type, int index, int base) { - struct resource *r = malloc(sizeof(struct resource)); - memset(r, 0, sizeof(struct resource)); + struct resource *r = S_ALLOC(sizeof(struct resource)); + r->type = type; r->index = index; r->base = base; @@ -368,8 +369,8 @@ void add_register(struct chip *chip, char *name, char *val) { - struct reg *r = malloc(sizeof(struct reg)); - memset(r, 0, sizeof(struct reg)); + struct reg *r = S_ALLOC(sizeof(struct reg)); + r->key = name; r->value = val; if (chip->reg) { @@ -610,8 +611,8 @@ if (!include_exists) { struct header *tmp = h->next; - h->next = malloc(sizeof(struct header)); - memset(h->next, 0, sizeof(struct header)); + h->next = S_ALLOC(sizeof(struct header)); + h->next->chiph_exists = chip->chiph_exists; h->next->name = chip->name; h->next->next = tmp; -- To view, visit https://review.coreboot.org/26738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I56a70cf4865c50ed238226ace86e867bb1ec53db Gerrit-Change-Number: 26738 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: util/sconfig: Change chip_queue to be more generic
by Furquan Shaikh (Code Review) 31 May '18

31 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26737 Change subject: util/sconfig: Change chip_queue to be more generic ...................................................................... util/sconfig: Change chip_queue to be more generic This CL changes chip_queue to be more generic to allow any data to be added/removed to/from queue. BUG=b:80081934 Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h M util/sconfig/sconfig.tab.c_shipped M util/sconfig/sconfig.y 4 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/26737/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 41e850c..0659ecd 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -53,29 +53,29 @@ .enabled = 1 }; -static struct chip_queue { - struct chip *ptr; - struct chip_queue *next; - struct chip_queue *prev; +static struct queue { + void *data; + struct queue *next; + struct queue *prev; } *q; -struct chip_queue *new_chip_queue_entry(struct chip *c) +struct queue *new_entry(void *data) { - struct chip_queue *e = malloc(sizeof(*e)); + struct queue *e = malloc(sizeof(*e)); if (!e) { fprintf(stderr, "%s: malloc failure!\n", __func__); exit(1); } - e->ptr = c; + e->data = data; e->next = e->prev = e; return e; } -void push_chip(struct chip *c) +void enqueue(void *data) { - struct chip_queue *tmp = new_chip_queue_entry(c); + struct queue *tmp = new_entry(data); if (!q) { q = tmp; @@ -88,10 +88,10 @@ tmp->next = q; } -struct chip *pop_chip(void) +void *dequeue(void) { - struct chip_queue *tmp = q->prev; - struct chip *c; + struct queue *tmp = q->prev; + void *data; if (tmp == q) q = NULL; @@ -100,10 +100,10 @@ q->prev = tmp->prev; } - c = tmp->ptr; + data = tmp->data; free(tmp); - return c; + return data; } static struct device *new_dev(struct device *parent) diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index 49e22ad..b9df91e 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -122,5 +122,5 @@ void yyrestart(FILE *input_file); -void push_chip(struct chip *chip); -struct chip *pop_chip(void); +void enqueue(void *data); +void *dequeue(void); diff --git a/util/sconfig/sconfig.tab.c_shipped b/util/sconfig/sconfig.tab.c_shipped index e001b31..17bb31f 100644 --- a/util/sconfig/sconfig.tab.c_shipped +++ b/util/sconfig/sconfig.tab.c_shipped @@ -86,7 +86,7 @@ void yyerror(const char *s); static struct device *cur_parent; - static struct chip *cur_chip; +static struct chip *cur_chip; @@ -1301,7 +1301,7 @@ { (yyval.chip) = new_chip((yyvsp[0].string)); - push_chip(cur_chip); + enqueue(cur_chip); cur_chip = (yyval.chip); } @@ -1310,7 +1310,7 @@ case 15: { - cur_chip = pop_chip(); + cur_chip = dequeue(); } break; diff --git a/util/sconfig/sconfig.y b/util/sconfig/sconfig.y index 67cc6d3..01ce92d 100755 --- a/util/sconfig/sconfig.y +++ b/util/sconfig/sconfig.y @@ -21,7 +21,7 @@ void yyerror(const char *s); static struct device *cur_parent; - static struct chip *cur_chip; +static struct chip *cur_chip; %} %union { @@ -41,11 +41,11 @@ chip: CHIP STRING /* == path */ { $<chip>$ = new_chip($<string>2); - push_chip(cur_chip); + enqueue(cur_chip); cur_chip = $<chip>$; } chipchildren END { - cur_chip = pop_chip(); + cur_chip = dequeue(); }; device: DEVICE BUS NUMBER /* == devnum */ BOOL { -- To view, visit https://review.coreboot.org/26737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Gerrit-Change-Number: 26737 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: security/tpm: Unify the coreboot TPM software stack
by Philipp Deppenwiese (Code Review) 31 May '18

31 May '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24903 ) Change subject: security/tpm: Unify the coreboot TPM software stack ...................................................................... Patch Set 33: Measured boot as part of vboot2 -- To view, visit https://review.coreboot.org/24903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec277e82a3c20c62a0548a1a2b013e6ce8f5b3f Gerrit-Change-Number: 24903 Gerrit-PatchSet: 33 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Trammell Hudson <hudson(a)trmm.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 31 May 2018 17:32:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/pch: Add pch lockdown code
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25688 ) Change subject: soc/intel/common/pch: Add pch lockdown code ...................................................................... Patch Set 63: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73837/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27951/ : SUCCESS -- To view, visit https://review.coreboot.org/25688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b81bbc54f737cb4e7120f44bbe705039b45ccb3 Gerrit-Change-Number: 25688 Gerrit-PatchSet: 63 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:21:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/pch: Add pch lockdown code
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25688 ) Change subject: soc/intel/common/pch: Add pch lockdown code ...................................................................... Patch Set 62: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/73835/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/27949/ : SUCCESS -- To view, visit https://review.coreboot.org/25688 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b81bbc54f737cb4e7120f44bbe705039b45ccb3 Gerrit-Change-Number: 25688 Gerrit-PatchSet: 62 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:12:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018