coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: util/sconfig: Get rid of struct header
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26739 ) Change subject: util/sconfig: Get rid of struct header ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73846/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27960/ : SUCCESS -- To view, visit https://review.coreboot.org/26739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Gerrit-Change-Number: 26739 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:59:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/x86/mp: Update CPU name in device structure
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26740 ) Change subject: cpu/x86/mp: Update CPU name in device structure ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73847/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/27961/ : SUCCESS -- To view, visit https://review.coreboot.org/26740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Gerrit-Change-Number: 26740 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:57:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/x86/mp: Update CPU name in device structure
by Naresh Solanki (Code Review) 31 May '18

31 May '18

Hello Rizwan Qureshi, Duncan Laurie, I'd like you to reexamine a change. Please visit https://review.coreboot.org/26740 to look at the new patch set (#2). Change subject: cpu/x86/mp: Update CPU name in device structure ...................................................................... cpu/x86/mp: Update CPU name in device structure Name the CPU device structure as per processor brand string. Before logs use to look like: APIC: 01 (unknown) Now logs looks like(depending on CPU on which it is tested): APIC: 01 (Intel(R) Core(TM) m3-7Y30 CPU @ 1.00GHz) BUG=None BRANCH=None TEST= Build & boot Soraka. Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/cpu/x86/mp_init.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/26740/2 -- To view, visit https://review.coreboot.org/26740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Gerrit-Change-Number: 26740 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: util/sconfig: Change chip_queue to be more generic
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26737 ) Change subject: util/sconfig: Change chip_queue to be more generic ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73844/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27958/ : SUCCESS -- To view, visit https://review.coreboot.org/26737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Gerrit-Change-Number: 26737 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:56:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Add helper function for allocating memory
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26738 ) Change subject: util/sconfig: Add helper function for allocating memory ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73845/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27959/ : SUCCESS -- To view, visit https://review.coreboot.org/26738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a70cf4865c50ed238226ace86e867bb1ec53db Gerrit-Change-Number: 26738 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:55:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Re-factor emitting of headers to static.c
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26726 ) Change subject: util/sconfig: Re-factor emitting of headers to static.c ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73843/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27957/ : SUCCESS -- To view, visit https://review.coreboot.org/26726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24d526e81323115d3cc927242a4b9e49414afbe0 Gerrit-Change-Number: 26726 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:51:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Re-factor sconfig to not assume chip as device
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26720 ) Change subject: util/sconfig: Re-factor sconfig to not assume chip as device ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73842/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27956/ : SUCCESS -- To view, visit https://review.coreboot.org/26720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I255092f527c8eecb144385eb681df20e54caf8f5 Gerrit-Change-Number: 26720 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:49:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: cpu/x86/mp: Update CPU name in device structure
by Naresh Solanki (Code Review) 31 May '18

31 May '18

Naresh Solanki has uploaded this change for review. ( https://review.coreboot.org/26740 Change subject: cpu/x86/mp: Update CPU name in device structure ...................................................................... cpu/x86/mp: Update CPU name in device structure Name the CPU device structure as per processor brand string. Before logs use to look like: APIC: 01 (unknown) Now logs looks: APIC: 01 (Intel(R) Core(TM) m3-7Y30 CPU @ 1.00GHz) BUG=None BRANCH=None TEST= Build & boot Soraka. Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/cpu/x86/mp_init.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/26740/1 diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index a696cd0..4abf653 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -46,6 +46,8 @@ int logical_cpu_number; }; +char processor_name[49]; + /* * A mp_flight_record details a sequence of calls for the APs to perform * along with the BSP to coordinate sequencing. Each flight record either @@ -403,6 +405,7 @@ printk(BIOS_CRIT, "Could not allocate CPU device\n"); max_cpus--; } + new->name = processor_name; cpus[i].dev = new; } @@ -560,7 +563,6 @@ { struct device_path cpu_path; struct cpu_info *info; - char processor_name[49]; /* Print processor name */ fill_processor_name(processor_name); @@ -576,6 +578,7 @@ /* Find the device structure for the boot CPU. */ info = cpu_info(); info->cpu = alloc_find_dev(cpu_bus, &cpu_path); + info->cpu->name = processor_name; if (info->index != 0) printk(BIOS_CRIT, "BSP index(%d) != 0!\n", info->index); -- To view, visit https://review.coreboot.org/26740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6af0e29bbbdb59406baeae32f7874ff9036a9c81 Gerrit-Change-Number: 26740 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com>

1 0

Change in coreboot[master]: util/sconfig: Get rid of bus pointer in device structure
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26736 ) Change subject: util/sconfig: Get rid of bus pointer in device structure ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73841/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27955/ : SUCCESS -- To view, visit https://review.coreboot.org/26736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21f8fe1545a9ed53d66d6d4462df4a5d63023844 Gerrit-Change-Number: 26736 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:47:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Change chip_queue to be more generic
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26737 ) Change subject: util/sconfig: Change chip_queue to be more generic ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/73839/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/27952/ : SUCCESS -- To view, visit https://review.coreboot.org/26737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c094e5bb53cb1f8e6aebba2df0df7a2bb05f3ef Gerrit-Change-Number: 26737 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 17:42:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018