Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/25546
to look at the new patch set (#2).
Change subject: util/scripts/ucode_h_to_bin.sh: Accept microcode in INC format
......................................................................
util/scripts/ucode_h_to_bin.sh: Accept microcode in INC format
Intel supply microcode (at least for MinnowBoard) in Intel Assembly
*.inc format rather than C header. This change allow to pass in
configuration directory with *.inc files rather than list of *.h
files.
Change-Id: I3c716e5ad42e55ab3a3a67de1e9bf10e58855540
Signed-off-by: Bartek Pastudzki <Bartek.Pastudzki(a)3mdeb.com>
---
M util/scripts/ucode_h_to_bin.sh
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/25546/2
--
To view, visit https://review.coreboot.org/25546
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c716e5ad42e55ab3a3a67de1e9bf10e58855540
Gerrit-Change-Number: 25546
Gerrit-PatchSet: 2
Gerrit-Owner: Lev
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Piotr Król has posted comments on this change. ( https://review.coreboot.org/25546 )
Change subject: util/scripts/ucode_h_to_bin.sh: Accept microcode in INC format
......................................................................
Patch Set 1:
(1 comment)
Please add Bay Trail maintainers.
https://review.coreboot.org/#/c/25546/1/src/soc/intel/fsp_baytrail/Kconfig
File src/soc/intel/fsp_baytrail/Kconfig:
https://review.coreboot.org/#/c/25546/1/src/soc/intel/fsp_baytrail/Kconfig@…
PS1, Line 100: default "../Vlv2MiscBinariesPkg/Microcode"
Why you changed this line? This is very specific to MinnowBoard Turbot Binary Objects package - I'm not sure we can generalize in that way. Even if can change that we should not do that in one commit.
--
To view, visit https://review.coreboot.org/25546
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c716e5ad42e55ab3a3a67de1e9bf10e58855540
Gerrit-Change-Number: 25546
Gerrit-PatchSet: 1
Gerrit-Owner: Lev
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 06 Apr 2018 12:48:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No