coreboot-gerrit March 2018

coreboot-gerrit@coreboot.org

1 participants
1399 discussions

Change in coreboot[master]: soc/intel/braswell: add resource allocation for LPE BAR1
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21103 ) Change subject: soc/intel/braswell: add resource allocation for LPE BAR1 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22744/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68308/ : SUCCESS -- To view, visit https://review.coreboot.org/21103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa68319da5fb999fe8d73792eaee692cce60c8a2 Gerrit-Change-Number: 21103 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 20:53:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge/Kconfig: Create a power restore option
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25002 ) Change subject: soc/amd/stoneyridge/Kconfig: Create a power restore option ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22743/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68307/ : SUCCESS -- To view, visit https://review.coreboot.org/25002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec82cb68cf1e2a820e610f12d8620488662232aa Gerrit-Change-Number: 25002 Gerrit-PatchSet: 6 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 19:08:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Add SKU support
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25011 ) Change subject: mb/google/kahlee: Add SKU support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22742/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68306/ : SUCCESS -- To view, visit https://review.coreboot.org/25011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e08d64df3f89d3703de047dd9ec8e1717e6b212 Gerrit-Change-Number: 25011 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 18:28:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/lenovo/w520: Add ThinkPad W520 support
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23564 ) Change subject: mb/lenovo/w520: Add ThinkPad W520 support ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22741/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68305/ : SUCCESS -- To view, visit https://review.coreboot.org/23564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1deb0436a807950c605dcd590deedcb3169bf8c5 Gerrit-Change-Number: 23564 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nico Rikken <nico(a)nicorikken.eu> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 18:24:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge/Kconfig: Create a power restore option
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25002 ) Change subject: soc/amd/stoneyridge/Kconfig: Create a power restore option ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22740/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68304/ : SUCCESS -- To view, visit https://review.coreboot.org/25002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec82cb68cf1e2a820e610f12d8620488662232aa Gerrit-Change-Number: 25002 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 18:09:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee: Add SKU support
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25011 ) Change subject: mb/google/kahlee: Add SKU support ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/68303/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22739/ : SUCCESS -- To view, visit https://review.coreboot.org/25011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e08d64df3f89d3703de047dd9ec8e1717e6b212 Gerrit-Change-Number: 25011 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 17:59:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: kahlee: Add SKU support
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25011 ) Change subject: kahlee: Add SKU support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22738/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68301/ : SUCCESS -- To view, visit https://review.coreboot.org/25011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e08d64df3f89d3703de047dd9ec8e1717e6b212 Gerrit-Change-Number: 25011 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 16:55:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: kahlee: Add SKU support
by Simon Glass (Code Review) 06 Mar '18

06 Mar '18

Simon Glass has uploaded this change for review. ( https://review.coreboot.org/25011 Change subject: kahlee: Add SKU support ...................................................................... kahlee: Add SKU support We want to report the board SKU via the SMBIOS tables. Add support for this, obtaining the ID itself from the EC. I'm not quite sure of the correct code layout/naming, so please check. BUG=b:74175244 BRANCH=none TEST=manually on grunt with another CL: mosys platform sku 0 Change-Id: I9e08d64df3f89d3703de047dd9ec8e1717e6b212 Signed-off-by: Simon Glass <sjg(a)chromium.org> --- M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/kahlee/variants/grunt/Makefile.inc A src/mainboard/google/kahlee/variants/grunt/mainboard.c 4 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/25011/1 diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 753a83e..e82569e 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <string.h> #include <console/console.h> #include <device/device.h> #include <arch/acpi.h> @@ -21,6 +22,7 @@ #include <cbmem.h> #include <baseboard/variants.h> #include <boardid.h> +#include <smbios.h> #include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/smi.h> @@ -221,3 +223,18 @@ .enable_dev = kahlee_enable, .final = mainboard_final, }; + +/* Variants may override this function so see definitions in variants/ */ +uint8_t __attribute__((weak)) variant_board_sku(void) +{ + return 0; +} + +const char *smbios_mainboard_sku(void) +{ + static char sku_str[7]; /* sku{0..255} */ + + snprintf(sku_str, sizeof(sku_str), "sku%d", variant_board_sku()); + + return sku_str; +} diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h index 83ee119..e5a348a 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h @@ -24,6 +24,8 @@ const struct sci_source *get_gpe_table(size_t *num); uint8_t variant_memory_sku(void); +/* Return board SKU. Limited to uint8_t, so it fits into 3 decimal digits */ +uint8_t variant_board_sku(void); int variant_mainboard_read_spd(uint8_t spdAddress, char *buf, size_t len); int variant_get_xhci_oc_map(uint16_t *usb_oc_map); int variant_get_ehci_oc_map(uint16_t *usb_oc_map); diff --git a/src/mainboard/google/kahlee/variants/grunt/Makefile.inc b/src/mainboard/google/kahlee/variants/grunt/Makefile.inc index 319ff13..7a4b994 100644 --- a/src/mainboard/google/kahlee/variants/grunt/Makefile.inc +++ b/src/mainboard/google/kahlee/variants/grunt/Makefile.inc @@ -14,3 +14,5 @@ # subdirs-y += spd + +ramstage-y += mainboard.c diff --git a/src/mainboard/google/kahlee/variants/grunt/mainboard.c b/src/mainboard/google/kahlee/variants/grunt/mainboard.c new file mode 100644 index 0000000..16a8ea9 --- /dev/null +++ b/src/mainboard/google/kahlee/variants/grunt/mainboard.c @@ -0,0 +1,27 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <ec/google/chromeec/ec.h> +#include "baseboard/variants.h" + +uint8_t variant_board_sku(void) +{ + static int sku = -1; + + if (sku == -1) + sku = google_chromeec_get_sku_id(); + + return sku; +} -- To view, visit https://review.coreboot.org/25011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9e08d64df3f89d3703de047dd9ec8e1717e6b212 Gerrit-Change-Number: 25011 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Glass <sjg(a)chromium.org>

1 0

Change in coreboot[master]: src/soc/amd/stoneyridge: clean up southbridge.c
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25010 ) Change subject: src/soc/amd/stoneyridge: clean up southbridge.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22737/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68300/ : SUCCESS -- To view, visit https://review.coreboot.org/25010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcf4d617e2a0a520a6d7e8d0d758d7a9705a84ea Gerrit-Change-Number: 25010 Gerrit-PatchSet: 1 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 16:09:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/soc/amd/stoneyridge: Add southbridge definitions
by build bot (Jenkins) (Code Review) 06 Mar '18

06 Mar '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24998 ) Change subject: src/soc/amd/stoneyridge: Add southbridge definitions ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/22736/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/68298/ : SUCCESS -- To view, visit https://review.coreboot.org/24998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45c1d1d7edc864000282c7ca4e2b8f2a14ea9eac Gerrit-Change-Number: 24998 Gerrit-PatchSet: 8 Gerrit-Owner: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 16:07:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2018