coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/poppy: Fix the SPD for samsung_dimm_K4A8G165WB
by Furquan Shaikh (Code Review) 13 Feb '18

13 Feb '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23729 Change subject: mb/google/poppy: Fix the SPD for samsung_dimm_K4A8G165WB ...................................................................... mb/google/poppy: Fix the SPD for samsung_dimm_K4A8G165WB Original SPD provided by the vendor had bytes after 254 shifted by 16 bytes. This change fixes the SPD data based on the latest details received from the vendor. BUG=b:72749394 Change-Id: I6938dea761c5785048aad69eeeaf50e2d0fa8ca1 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/23729/1 diff --git a/src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex b/src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex index 0ea841d..2fed82a 100644 --- a/src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex +++ b/src/mainboard/google/poppy/spd/samsung_dimm_K4A8G165WB-BCRC.spd.hex @@ -13,7 +13,6 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 @@ -30,3 +29,4 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/23729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6938dea761c5785048aad69eeeaf50e2d0fa8ca1 Gerrit-Change-Number: 23729 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Switch to common PCR ASL
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23725 ) Change subject: soc/intel/skylake: Switch to common PCR ASL ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67414/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21954/ : SUCCESS -- To view, visit https://review.coreboot.org/23725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99ec7c878adaea439108553c0fac9d5abe1bc248 Gerrit-Change-Number: 23725 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 01:39:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add generic PCR asl
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23698 ) Change subject: soc/intel/common: Add generic PCR asl ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67413/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21953/ : SUCCESS -- To view, visit https://review.coreboot.org/23698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf8c386824ee08cb93cb419ce3cdb2d3fe22a026 Gerrit-Change-Number: 23698 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 01:37:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/skylake: Switch to common PCR ASL
by Lijian Zhao (Code Review) 13 Feb '18

13 Feb '18

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/23725 Change subject: soc/intel/skylake: Switch to common PCR ASL ...................................................................... soc/intel/skylake: Switch to common PCR ASL Using common PCR asl for skylake/kabylake platform. BUG=None TEST=None Change-Id: I99ec7c878adaea439108553c0fac9d5abe1bc248 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/skylake/acpi/pch.asl D src/soc/intel/skylake/acpi/pcr.asl 2 files changed, 1 insertion(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/23725/1 diff --git a/src/soc/intel/skylake/acpi/pch.asl b/src/soc/intel/skylake/acpi/pch.asl index e40dd6b..0c4decc 100644 --- a/src/soc/intel/skylake/acpi/pch.asl +++ b/src/soc/intel/skylake/acpi/pch.asl @@ -39,7 +39,7 @@ #include "pcie.asl" /* PCR Access */ -#include "pcr.asl" +#include <soc/intel/common/acpi/pcr.asl> /* PMC 0:1f.2 */ #include "pmc.asl" diff --git a/src/soc/intel/skylake/acpi/pcr.asl b/src/soc/intel/skylake/acpi/pcr.asl deleted file mode 100644 index c73830f..0000000 --- a/src/soc/intel/skylake/acpi/pcr.asl +++ /dev/null @@ -1,88 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 Google Inc. - * Copyright (C) 2015 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -/* - * Calculate PCR register base at specified PID - * Arg0 - PCR Port ID - */ -Method (PCRB, 1, NotSerialized) -{ - Return (Add (CONFIG_PCR_BASE_ADDRESS, - ShiftLeft (Arg0, PCR_PORTID_SHIFT))) -} - -/* - * Read a PCR register at specified PID and offset - * Arg0 - PCR Port ID - * Arg1 - Register Offset - */ -Method (PCRR, 2, Serialized) -{ - OperationRegion (PCRD, SystemMemory, Add (PCRB (Arg0), Arg1), 4) - Field (PCRD, DWordAcc, NoLock, Preserve) - { - DATA, 32 - } - Return (DATA) -} - -/* - * AND a value with PCR register at specified PID and offset - * Arg0 - PCR Port ID - * Arg1 - Register Offset - * Arg2 - Value to AND - */ -Method (PCRA, 3, Serialized) -{ - OperationRegion (PCRD, SystemMemory, Add (PCRB (Arg0), Arg1), 4) - Field (PCRD, DWordAcc, NoLock, Preserve) - { - DATA, 32 - } - And (DATA, Arg2, DATA) - - /* - * After every write one needs to read an innocuous register - * to ensure the writes are completed for certain ports. This is done - * for all ports so that the callers don't need the per-port knowledge - * for each transaction. - */ - PCRR (Arg0, Arg1) -} - -/* - * OR a value with PCR register at specified PID and offset - * Arg0 - PCR Port ID - * Arg1 - Register Offset - * Arg2 - Value to OR - */ -Method (PCRO, 3, Serialized) -{ - OperationRegion (PCRD, SystemMemory, Add (PCRB (Arg0), Arg1), 4) - Field (PCRD, DWordAcc, NoLock, Preserve) - { - DATA, 32 - } - Or (DATA, Arg2, DATA) - - /* - * After every write one needs to read an innocuous register - * to ensure the writes are completed for certain ports. This is done - * for all ports so that the callers don't need the per-port knowledge - * for each transaction. - */ - PCRR (Arg0, Arg1) -} -- To view, visit https://review.coreboot.org/23725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I99ec7c878adaea439108553c0fac9d5abe1bc248 Gerrit-Change-Number: 23725 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: mainboard/google/octopus: Add new board
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23685 ) Change subject: mainboard/google/octopus: Add new board ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67412/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21952/ : SUCCESS -- To view, visit https://review.coreboot.org/23685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c25b3fafbfef31b8b3b802acb3bc53ee7146b6 Gerrit-Change-Number: 23685 Gerrit-PatchSet: 4 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 01:32:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Use common PCR ASL
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23699 ) Change subject: soc/intel/cannonlake: Use common PCR ASL ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67411/ : SUCCESS -- To view, visit https://review.coreboot.org/23699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4975704434d4743bcc0fb6062115da349166c3a6 Gerrit-Change-Number: 23699 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 01:00:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: amd/stoneyridge: Move model_15_init.c to cpu.c
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23724 ) Change subject: amd/stoneyridge: Move model_15_init.c to cpu.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67408/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21949/ : SUCCESS -- To view, visit https://review.coreboot.org/23724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c62b09209fcdaa50ff8ffc7773ef155f979a1b Gerrit-Change-Number: 23724 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 00:29:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: x86/mtrr: Enable Rd/WrDram mod in AMD fixed MTRRs
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23722 ) Change subject: x86/mtrr: Enable Rd/WrDram mod in AMD fixed MTRRs ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67407/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21947/ : SUCCESS -- To view, visit https://review.coreboot.org/23722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie195131ff752400eb886dfccc39b314b4fa6b3f3 Gerrit-Change-Number: 23722 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 00:26:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/stoneyridge: Use generic fixed MTRR setup
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23723 ) Change subject: amd/stoneyridge: Use generic fixed MTRR setup ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67406/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21948/ : SUCCESS -- To view, visit https://review.coreboot.org/23723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5526dcff12555efccab811fa3442ba1bff051bb Gerrit-Change-Number: 23723 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 00:21:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Set up LAPIC
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23718 ) Change subject: soc/amd/stoneyridge: Set up LAPIC ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67405/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21946/ : SUCCESS -- To view, visit https://review.coreboot.org/23718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I648d8b5b5a3744a5781446c7cb72934a071f9a72 Gerrit-Change-Number: 23718 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 00:14:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018