coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mainboard/intel/glkrvp: Configure eSPI GPIOs to enable S0ix
by Shamile Khan (Code Review) 13 Feb '18

13 Feb '18

Hello Hannah Williams, I'd like you to do a code review. Please visit https://review.coreboot.org/23742 to review the following change. Change subject: mainboard/intel/glkrvp: Configure eSPI GPIOs to enable S0ix ...................................................................... mainboard/intel/glkrvp: Configure eSPI GPIOs to enable S0ix Change-Id: Ie0c1013fee638a3b7a91469736efc0c25a1597fa Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> Signed-off-by: Shamile Khan <shamile.khan(a)intel.com> --- M src/mainboard/intel/glkrvp/variants/baseboard/gpio.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/23742/1 diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c index 0646bcf..81d6ba3 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c +++ b/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c @@ -188,6 +188,9 @@ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_153, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/*LPC_AD3*/ PAD_CFG_NF(GPIO_154, UP_20K, DEEP, NF1),/*LPC_CLKRUNB*/ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_155, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD),/*LPC_FRAMEB*/ +#else + PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_155, UP_20K, DEEP, NF2, HIZCRx1, DISPUPD),/*LPC_FRAMEB*/ + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_154, 0, DEEP, NONE, IGNORE, ENPU),/*LPC_CLKRUNB*/ #endif /* !IS_ENABLED(CONFIG_SOC_ESPI) */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_157, 1, DEEP, UP_20K, IGNORE, SAME),/*WWAN_Reset/dGPS Reset*/ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_158, 0, DEEP, DN_20K, IGNORE, SAME),/*NFC_DFU*/ -- To view, visit https://review.coreboot.org/23742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0c1013fee638a3b7a91469736efc0c25a1597fa Gerrit-Change-Number: 23742 Gerrit-PatchSet: 1 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: mb/scaleway/tagada: Copy intel/harcuvar and rename
by Nico Huber (Code Review) 13 Feb '18

13 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23735 ) Change subject: mb/scaleway/tagada: Copy intel/harcuvar and rename ...................................................................... Patch Set 1: Um, I hope nobody told you do add your board this way (copying another and base changes on that). It's a sure way to keep flaws in the code; because nobody is going to review this commit but only your later changes. That's just my opinion, though. Other reviewers might see it differently. -- To view, visit https://review.coreboot.org/23735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fc1f8393ce3f5ba6f52edad7cf8efa5524d2704 Gerrit-Change-Number: 23735 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 23:20:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/scaleway/tagada: Remove unused board_id
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23741 ) Change subject: mb/scaleway/tagada: Remove unused board_id ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67430/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21968/ : SUCCESS -- To view, visit https://review.coreboot.org/23741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6175ce3d3ef739c4f503db826036ffe8feff9ddc Gerrit-Change-Number: 23741 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:55:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Update HSIO configuration
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23737 ) Change subject: mb/scaleway/tagada: Update HSIO configuration ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67426/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21963/ : SUCCESS -- To view, visit https://review.coreboot.org/23737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I213ea13078fdc28489eb4572a084146df333a31d Gerrit-Change-Number: 23737 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:54:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Update GPIO configuration
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23740 ) Change subject: mb/scaleway/tagada: Update GPIO configuration ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67429/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21967/ : SUCCESS -- To view, visit https://review.coreboot.org/23740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0293a0ec85c752686750dadb9730a159fd0c073 Gerrit-Change-Number: 23740 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:54:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Remove eMMC configuration
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23739 ) Change subject: mb/scaleway/tagada: Remove eMMC configuration ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67428/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21966/ : SUCCESS -- To view, visit https://review.coreboot.org/23739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If29009a09f39484b1da16fb650b4f9cbee2a6d19 Gerrit-Change-Number: 23739 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:53:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Update device tree
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23736 ) Change subject: mb/scaleway/tagada: Update device tree ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67425/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21965/ : SUCCESS -- To view, visit https://review.coreboot.org/23736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c42519dbe848b0bbcafa7f923d862ba7c9d8ed5 Gerrit-Change-Number: 23736 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:49:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Remove memory down option
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23738 ) Change subject: mb/scaleway/tagada: Remove memory down option ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67427/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21964/ : SUCCESS -- To view, visit https://review.coreboot.org/23738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70eda83fbce7a707da170c7e555ed1a6dc6b1f4a Gerrit-Change-Number: 23738 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:49:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Copy intel/harcuvar and rename
by build bot (Jenkins) (Code Review) 13 Feb '18

13 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23735 ) Change subject: mb/scaleway/tagada: Copy intel/harcuvar and rename ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67424/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21962/ : SUCCESS -- To view, visit https://review.coreboot.org/23735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fc1f8393ce3f5ba6f52edad7cf8efa5524d2704 Gerrit-Change-Number: 23735 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:37:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Remove unused board_id
by Julien Viard de Galbert (Code Review) 13 Feb '18

13 Feb '18

Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23741 Change subject: mb/scaleway/tagada: Remove unused board_id ...................................................................... mb/scaleway/tagada: Remove unused board_id Change-Id: I6175ce3d3ef739c4f503db826036ffe8feff9ddc Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/mainboard/scaleway/tagada/Makefile.inc D src/mainboard/scaleway/tagada/boardid.c D src/mainboard/scaleway/tagada/harcuvar_boardid.h 3 files changed, 0 insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/23741/1 diff --git a/src/mainboard/scaleway/tagada/Makefile.inc b/src/mainboard/scaleway/tagada/Makefile.inc index 7421f38..2c8186f 100644 --- a/src/mainboard/scaleway/tagada/Makefile.inc +++ b/src/mainboard/scaleway/tagada/Makefile.inc @@ -14,11 +14,9 @@ ## GNU General Public License for more details. ## -romstage-y += boardid.c romstage-y += hsio.c ramstage-y += ramstage.c -ramstage-y += boardid.c ramstage-y += hsio.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c diff --git a/src/mainboard/scaleway/tagada/boardid.c b/src/mainboard/scaleway/tagada/boardid.c deleted file mode 100644 index c9df766..0000000 --- a/src/mainboard/scaleway/tagada/boardid.c +++ /dev/null @@ -1,29 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 - 2017 Intel Corporation. - * Copyright (C) 2017 - 2018 Online SAS. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - */ - -#include <console/console.h> - -#include "harcuvar_boardid.h" - -uint8_t board_id(void) -{ - int id = BoardIdHarcuvar; - - printk(BIOS_SPEW, "Board ID: %#x.\n", id); - - return id; -} diff --git a/src/mainboard/scaleway/tagada/harcuvar_boardid.h b/src/mainboard/scaleway/tagada/harcuvar_boardid.h deleted file mode 100644 index 3bcd60c..0000000 --- a/src/mainboard/scaleway/tagada/harcuvar_boardid.h +++ /dev/null @@ -1,26 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2015 - 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - */ - -#ifndef HARCUVAR_MAINBOARD_BOARD_H -#define HARCUVAR_MAINBOARD_BOARD_H - -#include <stdint.h> - -#define BoardIdHarcuvar 0x52 - -uint8_t board_id(void); - -#endif /* MAINBOARD_BOARD_H */ -- To view, visit https://review.coreboot.org/23741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6175ce3d3ef739c4f503db826036ffe8feff9ddc Gerrit-Change-Number: 23741 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018