coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: chromeec: Add google_chromeec_get_alternate_mode
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23744 ) Change subject: chromeec: Add google_chromeec_get_alternate_mode ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67436/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21974/ : SUCCESS -- To view, visit https://review.coreboot.org/23744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9b4ad06b61326fa167c77758603e038d817f928 Gerrit-Change-Number: 23744 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 03:13:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Fizz: Wait until display is ready
by Daisuke Nojiri (Code Review) 14 Feb '18

14 Feb '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/23746 Change subject: Fizz: Wait until display is ready ...................................................................... Fizz: Wait until display is ready With this patch, when firmware needs to display something, Fizz calls google_chromeec_wait_for_display to make sure display is ready. BUG=b:72387533 BRANCH=none TEST=Boot Fizz in manual recovery mode. Verify recovery screen is displayed. Change-Id: I90befe94f93e13904987acda50b2598d034b0031 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/mainboard/google/fizz/ramstage.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/23746/1 diff --git a/src/mainboard/google/fizz/ramstage.c b/src/mainboard/google/fizz/ramstage.c index 6dafe65..be64498 100644 --- a/src/mainboard/google/fizz/ramstage.c +++ b/src/mainboard/google/fizz/ramstage.c @@ -13,11 +13,15 @@ * GNU General Public License for more details. */ +#include <bootmode.h> +#include <ec/google/chromeec/ec.h> #include <soc/ramstage.h> #include "gpio.h" void mainboard_silicon_init_params(FSP_SIL_UPD *params) { + if (display_init_required()) + google_chromeec_wait_for_display(); gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); } -- To view, visit https://review.coreboot.org/23746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I90befe94f93e13904987acda50b2598d034b0031 Gerrit-Change-Number: 23746 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_wait_for_display
by Daisuke Nojiri (Code Review) 14 Feb '18

14 Feb '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/23745 Change subject: chromeec: Add google_chromeec_wait_for_display ...................................................................... chromeec: Add google_chromeec_wait_for_display The google_chromeec_wait_for_displa API checks whether a display is ready or not. It waits in a loop until EC says it entered DisplayPort alternative mode or times out in 2 seconds. BUG=b:72387533 BRANCH=none TEST=Boot Fizz in manual recovery mode. Verify recovery screen is displayed. Change-Id: Ieee5db77bd6e147936ea8fc735dcbeffec98c0f8 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/23745/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 229a710..156357a 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -953,3 +953,19 @@ return 0; } + +#define USB_SID_DISPLAYPORT 0xff01 +void google_chromeec_wait_for_display(void) +{ + int count = 0; + printk(BIOS_INFO, "Waiting for display."); + while (google_chromeec_get_alternate_mode(USB_SID_DISPLAYPORT) != 1) { + if (count++ > 10) { + printk(BIOS_WARNING, " Not ready\n"); + return; + } + udelay(200000); + printk(BIOS_INFO, "."); + } + printk(BIOS_INFO, " Ready\n"); +} diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index dde23c1..45d6f55 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -37,6 +37,7 @@ int google_ec_running_ro(void); void google_chromeec_init(void); int google_chromeec_get_alternate_mode(uint16_t svid); +void google_chromeec_wait_for_display(void); /* Device events */ uint64_t google_chromeec_get_device_enabled_events(void); -- To view, visit https://review.coreboot.org/23745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieee5db77bd6e147936ea8fc735dcbeffec98c0f8 Gerrit-Change-Number: 23745 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_get_alternate_mode
by Daisuke Nojiri (Code Review) 14 Feb '18

14 Feb '18

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/23744 Change subject: chromeec: Add google_chromeec_get_alternate_mode ...................................................................... chromeec: Add google_chromeec_get_alternate_mode google_chromeec_get_alternate_mode checks whether TCPM is in an specified alternate mode or not. BUG=b:72387533 BRANCH=none TEST=Boot Fizz in manual recovery mode. Verify recovery screen is displayed. Change-Id: Ib9b4ad06b61326fa167c77758603e038d817f928 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/23744/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 89241da..229a710 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -902,3 +902,54 @@ #endif /* ! __SMM__ */ #endif /* ! __PRE_RAM__ */ + +/** + * Check if EC is in a alternate mode or not. + * + * @param svid SVID of the alternate mode to check + * @return 0: Not in the mode. -1: Error. 1: Yes. + */ +#define SVID_DISCOVERY_MAX 16 /* Defined in usb_pd.h */ +int google_chromeec_get_alternate_mode(uint16_t svid) +{ + struct ec_response_usb_pd_ports r; + struct chromeec_command cmd; + int i; + + cmd.cmd_code = EC_CMD_USB_PD_PORTS; + cmd.cmd_version = 0; + cmd.cmd_data_in = NULL; + cmd.cmd_size_in = 0; + cmd.cmd_data_out = &r; + cmd.cmd_size_out = sizeof(r); + cmd.cmd_dev_index = 0; + if (google_chromeec_command(&cmd) < 0) + return -1; + + for (i = 0; i < r.num_ports; i++) { + struct ec_params_usb_pd_get_mode_request p; + struct ec_params_usb_pd_get_mode_response res; + + p.port = i; + p.svid_idx = 0; + cmd.cmd_code = EC_CMD_USB_PD_GET_AMODE; + cmd.cmd_version = 0; + cmd.cmd_data_in = &p; + cmd.cmd_size_in = sizeof(p); + cmd.cmd_data_out = &res; + cmd.cmd_size_out = sizeof(res); + cmd.cmd_dev_index = 0; + + do { + if (google_chromeec_command(&cmd) < 0) + return -1; + if (!res.svid) + break; + if (res.svid == svid) + return 1; + p.svid_idx++; + } while (p.svid_idx < SVID_DISCOVERY_MAX); + } + + return 0; +} diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 90bb6fa..dde23c1 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -36,6 +36,7 @@ bool google_chromeec_is_uhepi_supported(void); int google_ec_running_ro(void); void google_chromeec_init(void); +int google_chromeec_get_alternate_mode(uint16_t svid); /* Device events */ uint64_t google_chromeec_get_device_enabled_events(void); -- To view, visit https://review.coreboot.org/23744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9b4ad06b61326fa167c77758603e038d817f928 Gerrit-Change-Number: 23744 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: mb/intel/glkrvp: Add FPF_STATUS section in fmd file
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23743 ) Change subject: mb/intel/glkrvp: Add FPF_STATUS section in fmd file ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67435/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21973/ : SUCCESS -- To view, visit https://review.coreboot.org/23743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c92eefc64fe146c628d9c104d7dfb016204004c Gerrit-Change-Number: 23743 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 02:42:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/intel/glkrvp: Add FPF_STATUS section in fmd file
by Hannah Williams (Code Review) 14 Feb '18

14 Feb '18

Hannah Williams has uploaded this change for review. ( https://review.coreboot.org/23743 Change subject: mb/intel/glkrvp: Add FPF_STATUS section in fmd file ...................................................................... mb/intel/glkrvp: Add FPF_STATUS section in fmd file Read cse file was not getting cached and taking about 500ms on every boot. Change-Id: I8c92eefc64fe146c628d9c104d7dfb016204004c Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/intel/glkrvp/chromeos.fmd 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/23743/1 diff --git a/src/mainboard/intel/glkrvp/chromeos.fmd b/src/mainboard/intel/glkrvp/chromeos.fmd index 56c8d58..fad3537 100644 --- a/src/mainboard/intel/glkrvp/chromeos.fmd +++ b/src/mainboard/intel/glkrvp/chromeos.fmd @@ -24,7 +24,8 @@ VBLOCK_DEV@0x2000 0x2000 } RW_VPD@0x39000 0x2000 - TMP_UNUSED_HOLE@0x3B000 0xF000 + FPF_STATUS@0x3B000 0x1000 + TMP_UNUSED_HOLE@0x3C000 0xE000 } RW_SECTION_A@0x44a000 0x477800 { VBLOCK_A@0x0 0x10000 -- To view, visit https://review.coreboot.org/23743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8c92eefc64fe146c628d9c104d7dfb016204004c Gerrit-Change-Number: 23743 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: mb/google/octopus: Add new board
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23685 ) Change subject: mb/google/octopus: Add new board ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67434/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21972/ : SUCCESS -- To view, visit https://review.coreboot.org/23685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c25b3fafbfef31b8b3b802acb3bc53ee7146b6 Gerrit-Change-Number: 23685 Gerrit-PatchSet: 7 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 02:26:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Add new board
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23685 ) Change subject: mb/google/octopus: Add new board ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67433/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21971/ : SUCCESS -- To view, visit https://review.coreboot.org/23685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c25b3fafbfef31b8b3b802acb3bc53ee7146b6 Gerrit-Change-Number: 23685 Gerrit-PatchSet: 6 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 02:08:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/octopus: Add new board
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23685 ) Change subject: mb/google/octopus: Add new board ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67432/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21970/ : SUCCESS -- To view, visit https://review.coreboot.org/23685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c25b3fafbfef31b8b3b802acb3bc53ee7146b6 Gerrit-Change-Number: 23685 Gerrit-PatchSet: 5 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 02:05:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Configure eSPI GPIOs to enable S0ix
by build bot (Jenkins) (Code Review) 14 Feb '18

14 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23742 ) Change subject: mainboard/intel/glkrvp: Configure eSPI GPIOs to enable S0ix ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67431/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21969/ : SUCCESS -- To view, visit https://review.coreboot.org/23742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c1013fee638a3b7a91469736efc0c25a1597fa Gerrit-Change-Number: 23742 Gerrit-PatchSet: 1 Gerrit-Owner: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Feb 2018 00:03:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018