Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23739
Change subject: mb/scaleway/tagada: Remove eMMC configuration
......................................................................
mb/scaleway/tagada: Remove eMMC configuration
The board does no support eMMC so no need to configure it.
Change-Id: If29009a09f39484b1da16fb650b4f9cbee2a6d19
Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net>
---
D src/mainboard/scaleway/tagada/emmc.h
M src/mainboard/scaleway/tagada/ramstage.c
2 files changed, 3 insertions(+), 67 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/23739/1
diff --git a/src/mainboard/scaleway/tagada/emmc.h b/src/mainboard/scaleway/tagada/emmc.h
deleted file mode 100644
index 9832191..0000000
--- a/src/mainboard/scaleway/tagada/emmc.h
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2016 - 2017 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- */
-
-#ifndef _MAINBOARD_EMMC_H
-#define _MAINBOARD_EMMC_H
-
-#include <fsp/util.h>
-
-#define DEFAULT_EMMC_DLL_SIGN 0x55aa
-
-#ifndef __ACPI__
-BL_EMMC_INFORMATION harcuvar_emmc_config[] = {
- /*
- * Default eMMC DLL configuration.
- */
- {DEFAULT_EMMC_DLL_SIGN,
- {0x00000508, 0x00000c11, 0x1c2a2a2a, 0x00191e27, 0x00000a0a,
- 0x00010013, 0x00000001} } };
-#endif
-
-#endif /* _MAINBOARD_EMMC_H */
diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c
index 4d90858..0aa6f13 100644
--- a/src/mainboard/scaleway/tagada/ramstage.c
+++ b/src/mainboard/scaleway/tagada/ramstage.c
@@ -2,6 +2,7 @@
* This file is part of the coreboot project.
*
* Copyright (C) 2014 - 2017 Intel Corporation
+ * Copyright (C) 2017 - 2018 Online SAS.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -17,40 +18,9 @@
#include <console/console.h>
#include <fsp/api.h>
#include <soc/ramstage.h>
-#include "emmc.h"
-
-static int get_emmc_dll_info(uint16_t signature, size_t num_of_entry,
- BL_EMMC_INFORMATION **config)
-{
- uint8_t entry;
-
- if ((signature == 0) || (num_of_entry == 0) || (*config == NULL))
- return 1;
-
- for (entry = 0; entry < num_of_entry; entry++) {
- if ((*config)[entry].Signature == signature) {
- *config = &(*config)[entry];
- return 0;
- }
- }
-
- return 1;
-}
void mainboard_silicon_init_params(FSPS_UPD *params)
{
- size_t num;
- uint16_t emmc_dll_sign;
- BL_EMMC_INFORMATION *emmc_config;
-
- /* Configure eMMC DLL PCD */
- emmc_dll_sign = DEFAULT_EMMC_DLL_SIGN;
- num = ARRAY_SIZE(harcuvar_emmc_config);
- emmc_config = harcuvar_emmc_config;
-
- if (get_emmc_dll_info(emmc_dll_sign, num, &emmc_config))
- die("eMMC DLL Configuration is invalid, please correct it!");
-
- params->FspsConfig.PcdEMMCDLLConfigPtr =
- (uint32_t)&emmc_config->eMMCDLLConfig;
+ /* Disable eMMC */
+ params->FspsConfig.PcdEnableEmmc = 0;
}
--
To view, visit https://review.coreboot.org/23739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If29009a09f39484b1da16fb650b4f9cbee2a6d19
Gerrit-Change-Number: 23739
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23736
Change subject: mb/scaleway/tagada: Update device tree
......................................................................
mb/scaleway/tagada: Update device tree
Change-Id: I1c42519dbe848b0bbcafa7f923d862ba7c9d8ed5
Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net>
---
M src/mainboard/scaleway/tagada/devicetree.cb
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/23736/1
diff --git a/src/mainboard/scaleway/tagada/devicetree.cb b/src/mainboard/scaleway/tagada/devicetree.cb
index 7fce211..acf56a0 100644
--- a/src/mainboard/scaleway/tagada/devicetree.cb
+++ b/src/mainboard/scaleway/tagada/devicetree.cb
@@ -53,18 +53,19 @@
device pci 04.0 on end # RAS
device pci 05.0 on end # RCEC(Root Complex Event Collector)
device pci 06.0 on end # Virtual root port 2 (QAT)
- device pci 09.0 on end # PCI Express Port 0, cluster #0, x8
- device pci 0e.0 on end # PCI Express Port 4, cluster #1, x4
- device pci 10.0 on end # PCI Express Port 6, cluster #1, x4
+ device pci 09.0 on end # PCI Express Port 0, cluster #0, x4
+ device pci 10.0 on end # PCI Express Port 6, cluster #1, x2
+ device pci 11.0 on end # PCI Express Port 7, cluster #1, x2
device pci 12.0 on end # SMBus Controller 1
+ device pci 13.0 on end # SATA Controller 0
device pci 14.0 on end # SATA Controller 1
device pci 15.0 on end # XHCI USB Controller
device pci 16.0 on end # Virtual root port 0 (10GBE0)
device pci 17.0 on end # Virtual root port 1 (10GBE1)
device pci 18.0 on end # CSME HECI 1
device pci 1a.0 on end # UART 0
- device pci 1a.1 on end # UART 1
- device pci 1a.2 on end # UART 2
+ device pci 1a.1 off end # UART 1
+ device pci 1a.2 off end # UART 2
device pci 1c.0 on end # eMMC
device pci 1f.0 on end # LPC bridge
device pci 1f.2 on end # PMC/ACPI
--
To view, visit https://review.coreboot.org/23736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c42519dbe848b0bbcafa7f923d862ba7c9d8ed5
Gerrit-Change-Number: 23736
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23733 )
Change subject: arch/riscv: Make RVC support configurable
......................................................................
Patch Set 1: Verified+1
Build Successful
https://qa.coreboot.org/job/coreboot-gerrit/67419/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/21957/ : SUCCESS
--
To view, visit https://review.coreboot.org/23733
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4f69fa6b33604a5aa60fd6f6da8bd966494112f
Gerrit-Change-Number: 23733
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 13 Feb 2018 13:36:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes