coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: mb/google/{soraka, poppy, nautilus}: Set psys_pmax to 45W
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23757 ) Change subject: mb/google/{soraka,poppy,nautilus}: Set psys_pmax to 45W ...................................................................... Patch Set 8: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67578/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22096/ : ABORTED -- To view, visit https://review.coreboot.org/23757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f624733830b462329b5f539c20e2aea664143e Gerrit-Change-Number: 23757 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 07:08:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/nvidia/tegra210: add missing bl31 params
by Andre Heider (Code Review) 16 Feb '18

16 Feb '18

Andre Heider has posted comments on this change. ( https://review.coreboot.org/23783 ) Change subject: soc/nvidia/tegra210: add missing bl31 params ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/23783/1/src/soc/nvidia/tegra210/arm_tf.c File src/soc/nvidia/tegra210/arm_tf.c: https://review.coreboot.org/#/c/23783/1/src/soc/nvidia/tegra210/arm_tf.c@45 PS1, Line 45: t210_plat_params.uart_id = 1; > Shouldn't this depend on the CONSOLE_SERIAL_TEGRA210_UARTx Kconfigs? It should, yes ;) But this was just the first step without functional change. UARTA is currently hard wired, see e.g. src/soc/nvidia/tegra210/clock.c:clock_early_uart() I have follow up patches which need a bit of polishing, but the end result is a working serial based on CONSOLE_SERIAL_TEGRA210_UARTx -- To view, visit https://review.coreboot.org/23783 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a47647216a154894e6c2c1fd3b304e18e85c6a5 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 1 Gerrit-Owner: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Andre Heider <a.heider(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 04:22:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/zoombini: re-enable software sync
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23630 ) Change subject: mb/google/zoombini: re-enable software sync ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67576/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22094/ : SUCCESS -- To view, visit https://review.coreboot.org/23630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7f5a24ed8a47cb44b3f505e3cd49e0cb6931dc0 Gerrit-Change-Number: 23630 Gerrit-PatchSet: 2 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 04:01:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add emmc/sdc port id
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23789 ) Change subject: soc/intel/cannonlake: Add emmc/sdc port id ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67575/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22093/ : SUCCESS -- To view, visit https://review.coreboot.org/23789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I901e90c47b08bb013fcfee5def610e320a7ac19a Gerrit-Change-Number: 23789 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 01:22:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add emmc/sdc port id
by Lijian Zhao (Code Review) 16 Feb '18

16 Feb '18

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/23789 Change subject: soc/intel/cannonlake: Add emmc/sdc port id ...................................................................... soc/intel/cannonlake: Add emmc/sdc port id EMMC and SD Controller port id listed here, the port id definition came from Cannonlake BIOS Writer Guide 570374. BUG=None TEST=None Change-Id: I901e90c47b08bb013fcfee5def610e320a7ac19a Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/include/soc/pcr_ids.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/23789/1 diff --git a/src/soc/intel/cannonlake/include/soc/pcr_ids.h b/src/soc/intel/cannonlake/include/soc/pcr_ids.h index b77eab8..3f356b9 100644 --- a/src/soc/intel/cannonlake/include/soc/pcr_ids.h +++ b/src/soc/intel/cannonlake/include/soc/pcr_ids.h @@ -35,5 +35,7 @@ #define PID_ITSS 0xc2 #define PID_LPC 0xc7 #define PID_SERIALIO 0xcb +#define PID_EMMC 0x52 +#define PID_SDX 0x53 #endif -- To view, visit https://review.coreboot.org/23789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I901e90c47b08bb013fcfee5def610e320a7ac19a Gerrit-Change-Number: 23789 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common/block/gpio: Change group offset calculation
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22571 ) Change subject: soc/intel/common/block/gpio: Change group offset calculation ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67574/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22092/ : SUCCESS -- To view, visit https://review.coreboot.org/22571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02ab1d878bc83d32222be074bd2db5e23adaf580 Gerrit-Change-Number: 22571 Gerrit-PatchSet: 20 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 00:46:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common/block/gpio: Change group offset calculation
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22571 ) Change subject: soc/intel/common/block/gpio: Change group offset calculation ...................................................................... Patch Set 19: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67573/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/22091/ : ABORTED -- To view, visit https://review.coreboot.org/22571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02ab1d878bc83d32222be074bd2db5e23adaf580 Gerrit-Change-Number: 22571 Gerrit-PatchSet: 19 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 00:36:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Sync ec_commands.h for CBI tags
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23788 ) Change subject: chromeec: Sync ec_commands.h for CBI tags ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67571/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22089/ : SUCCESS -- To view, visit https://review.coreboot.org/23788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I451ec9f6f9d7257915b7d4cb1e5adbee82d107de Gerrit-Change-Number: 23788 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 23:55:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_wait_for_display
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23745 ) Change subject: chromeec: Add google_chromeec_wait_for_display ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67570/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22088/ : SUCCESS -- To view, visit https://review.coreboot.org/23745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieee5db77bd6e147936ea8fc735dcbeffec98c0f8 Gerrit-Change-Number: 23745 Gerrit-PatchSet: 5 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 23:32:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: chromeec: Add google_chromeec_get_alternate_mode
by build bot (Jenkins) (Code Review) 16 Feb '18

16 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23744 ) Change subject: chromeec: Add google_chromeec_get_alternate_mode ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67568/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22086/ : SUCCESS -- To view, visit https://review.coreboot.org/23744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9b4ad06b61326fa167c77758603e038d817f928 Gerrit-Change-Number: 23744 Gerrit-PatchSet: 5 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Feb 2018 23:29:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018