coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: smbios: Extend Baseboard (or Module) Information (type2)
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23842 ) Change subject: smbios: Extend Baseboard (or Module) Information (type2) ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67806/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22305/ : SUCCESS -- To view, visit https://review.coreboot.org/23842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fe1c4fe70c66f8a7fcc75b93672421ae808bf1b Gerrit-Change-Number: 23842 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 16:01:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Override baudrate with bmcInfo
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23815 ) Change subject: mb/scaleway/tagada: Override baudrate with bmcInfo ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67805/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22304/ : SUCCESS -- To view, visit https://review.coreboot.org/23815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd93b64ef91a569127a0713fdb499dff2a1f11db Gerrit-Change-Number: 23815 Gerrit-PatchSet: 5 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 15:55:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: Implement console loglevel override using bmcInfo
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23814 ) Change subject: mb/scaleway/tagada: Implement console loglevel override using bmcInfo ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67803/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22302/ : SUCCESS -- To view, visit https://review.coreboot.org/23814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0093cfafe7eaa4a4381e67c9b871fdf28abc470d Gerrit-Change-Number: 23814 Gerrit-PatchSet: 5 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 15:51:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/scaleway/tagada: populate smbios information
by Julien Viard de Galbert (Code Review) 22 Feb '18

22 Feb '18

Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23843 Change subject: mb/scaleway/tagada: populate smbios information ...................................................................... mb/scaleway/tagada: populate smbios information Change-Id: I9b08660c6677864f5c96c66002b35bd05a366053 Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/mainboard/scaleway/tagada/ramstage.c 1 file changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/23843/1 diff --git a/src/mainboard/scaleway/tagada/ramstage.c b/src/mainboard/scaleway/tagada/ramstage.c index 55cd175..a56a95e 100644 --- a/src/mainboard/scaleway/tagada/ramstage.c +++ b/src/mainboard/scaleway/tagada/ramstage.c @@ -15,9 +15,11 @@ * */ +#include <string.h> #include <console/console.h> #include <fsp/api.h> #include <soc/ramstage.h> +#include <smbios.h> #include "bmcinfo.h" @@ -29,3 +31,58 @@ if (bmcinfo_disable_nic1()) params->FspsConfig.PcdEnableGbE = 2; // disable lan 1 only } + +/* Override smbios_mainboard_serial_number to retrieve it from BMC */ +const char *smbios_mainboard_serial_number(void) +{ + const char *bmc_serial = bmcinfo_serial(); + if (bmc_serial) + return bmc_serial; + return CONFIG_MAINBOARD_SERIAL_NUMBER; +} + +/* Override smbios_mainboard_set_uuid */ +void smbios_mainboard_set_uuid(u8 *uuid) +{ + const u8 *bmc_uuid = bmcinfo_uuid(); + if (bmc_uuid) + memcpy(uuid, bmc_uuid, 16); + /* leave all zero */ +} + +/* Override smbios_mainboard_version */ +const char *smbios_mainboard_version(void) +{ + const int hwRev = bmcinfo_hwrev(); + switch (hwRev) { + case 0: + return "Z0"; + case 1: + return "A0"; + case 2: + return "A1"; + } + return ""; +} + +/* Override smbios_mainboard_features_flags */ +u8 smbios_mainboard_features_flags(void) +{ + return 0xc; +} + +/* Override smbios_mainboard_location_in_chassis */ +const char *smbios_mainboard_location_in_chassis(void) +{ + static char location[4] = "n/a"; + int slot = bmcinfo_slot(); + if (slot >= 0) + snprintf(location, 4, "N%d", slot); + return location; +} + +/* Override smbios_mainboard_board_type */ +u8 smbios_mainboard_board_type(void) +{ + return 0x3; +} -- To view, visit https://review.coreboot.org/23843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9b08660c6677864f5c96c66002b35bd05a366053 Gerrit-Change-Number: 23843 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>

1 0

Change in coreboot[master]: smbios: Extend Baseboard (or Module) Information (type2)
by Julien Viard de Galbert (Code Review) 22 Feb '18

22 Feb '18

Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23842 Change subject: smbios: Extend Baseboard (or Module) Information (type2) ...................................................................... smbios: Extend Baseboard (or Module) Information (type2) Add more information on basebord as described in SMBIOS Reference Specification 3.1.1 Change-Id: I9fe1c4fe70c66f8a7fcc75b93672421ae808bf1b Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/23842/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 9475034..97b7b61 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -359,6 +359,27 @@ { /* leave all zero */ } + +const char *__attribute__((weak)) smbios_mainboard_asset_tag(void) +{ + return ""; +} + +u8 __attribute__((weak)) smbios_mainboard_features_flags(void) +{ + return 0; +} + +const char *__attribute__((weak)) smbios_mainboard_location_in_chassis(void) +{ + return ""; +} + +u8 __attribute__((weak)) smbios_mainboard_board_type(void) +{ + return 0; +} + #endif const char *__attribute__((weak)) smbios_mainboard_sku(void) @@ -399,7 +420,8 @@ return len; } -static int smbios_write_type2(unsigned long *current, int handle) +static int smbios_write_type2(unsigned long *current, int handle, + int chassis_handle) { struct smbios_type2 *t = (struct smbios_type2 *)*current; int len = sizeof(struct smbios_type2); @@ -415,6 +437,13 @@ t->serial_number = smbios_add_string(t->eos, smbios_mainboard_serial_number()); t->version = smbios_add_string(t->eos, smbios_mainboard_version()); + t->asset_tag = smbios_add_string(t->eos, + smbios_mainboard_asset_tag()); + t->features_flags = smbios_mainboard_features_flags(); + t->location_in_chassis = smbios_add_string(t->eos, + smbios_mainboard_location_in_chassis()); + t->board_type = smbios_mainboard_board_type(); + t->chassis_handle = chassis_handle; len = t->length + smbios_string_table_len(t->eos); *current += len; return len; @@ -629,7 +658,8 @@ update_max(len, max_struct_size, smbios_write_type1(&current, handle++)); update_max(len, max_struct_size, smbios_write_type2(&current, - handle++)); + handle, handle+1)); /* The chassis handle is the next one */ + handle++; update_max(len, max_struct_size, smbios_write_type3(&current, handle++)); update_max(len, max_struct_size, smbios_write_type4(&current, diff --git a/src/include/smbios.h b/src/include/smbios.h index fddcce8..10a122b 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -37,6 +37,11 @@ const char *smbios_mainboard_version(void); void smbios_mainboard_set_uuid(u8 *uuid); const char *smbios_mainboard_bios_version(void); +const char *smbios_mainboard_asset_tag(void); +u8 smbios_mainboard_features_flags(void); +const char *smbios_mainboard_location_in_chassis(void); +u8 smbios_mainboard_board_type(void); + const char *smbios_mainboard_sku(void); u8 smbios_mainboard_enclosure_type(void); #ifdef CONFIG_MAINBOARD_FAMILY @@ -275,6 +280,11 @@ u8 product_name; u8 version; u8 serial_number; + u8 asset_tag; + u8 features_flags; + u8 location_in_chassis; + u16 chassis_handle; + u8 board_type; u8 eos[2]; } __packed; -- To view, visit https://review.coreboot.org/23842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9fe1c4fe70c66f8a7fcc75b93672421ae808bf1b Gerrit-Change-Number: 23842 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>

1 0

Change in coreboot[master]: smbios: Add option to select the enclosure type
by Julien Viard de Galbert (Code Review) 22 Feb '18

22 Feb '18

Julien Viard de Galbert has uploaded this change for review. ( https://review.coreboot.org/23841 Change subject: smbios: Add option to select the enclosure type ...................................................................... smbios: Add option to select the enclosure type Also use it for scaleway/tagada Change-Id: I35bc913af69565531831746040a0afe0cabe1c58 Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/arch/x86/smbios.c M src/mainboard/scaleway/tagada/Kconfig 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/23841/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 548e6ed..9475034 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -434,10 +434,14 @@ t->bootup_state = SMBIOS_STATE_SAFE; t->power_supply_state = SMBIOS_STATE_SAFE; t->thermal_state = SMBIOS_STATE_SAFE; +#ifdef CONFIG_SMBIOS_ENCLOSURE_TYPE + t->_type = CONFIG_SMBIOS_ENCLOSURE_TYPE; +#else if (IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP)) t->_type = SMBIOS_ENCLOSURE_LAPTOP; else t->_type = SMBIOS_ENCLOSURE_DESKTOP; +#endif t->security_status = SMBIOS_STATE_SAFE; len = t->length + smbios_string_table_len(t->eos); *current += len; diff --git a/src/mainboard/scaleway/tagada/Kconfig b/src/mainboard/scaleway/tagada/Kconfig index f8f4ece..691346b 100644 --- a/src/mainboard/scaleway/tagada/Kconfig +++ b/src/mainboard/scaleway/tagada/Kconfig @@ -42,4 +42,8 @@ help Location of BMC SERIAL information. +config SMBIOS_ENCLOSURE_TYPE + hex + default 0x19 + endif # BOARD_SCALEWAY_TAGADA -- To view, visit https://review.coreboot.org/23841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I35bc913af69565531831746040a0afe0cabe1c58 Gerrit-Change-Number: 23841 Gerrit-PatchSet: 1 Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert(a)online.net>

1 0

Change in coreboot[master]: security/tpm: Refactor TSS 1.2 and 2.0 implementation
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22374 ) Change subject: security/tpm: Refactor TSS 1.2 and 2.0 implementation ...................................................................... Patch Set 40: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67800/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22299/ : SUCCESS -- To view, visit https://review.coreboot.org/22374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97bbc7b7b025500b49c743b0c303543c33627c88 Gerrit-Change-Number: 22374 Gerrit-PatchSet: 40 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 15:35:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Set up generic TSPI
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22106 ) Change subject: security/tpm: Set up generic TSPI ...................................................................... Patch Set 47: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67799/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22298/ : SUCCESS -- To view, visit https://review.coreboot.org/22106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 47 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 15:33:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Set up generic TSPI
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22106 ) Change subject: security/tpm: Set up generic TSPI ...................................................................... Patch Set 46: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67798/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22297/ : SUCCESS -- To view, visit https://review.coreboot.org/22106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb Gerrit-Change-Number: 22106 Gerrit-PatchSet: 46 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Randall Spangler <randall(a)spanglers.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 15:05:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/emulation/qemu-armv8: Add new board for ARMv8
by build bot (Jenkins) (Code Review) 22 Feb '18

22 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23812 ) Change subject: mb/emulation/qemu-armv8: Add new board for ARMv8 ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67797/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22296/ : SUCCESS -- To view, visit https://review.coreboot.org/23812 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4f2fd43afb855c2ae5760d9ee6ae1478b09104c Gerrit-Change-Number: 23812 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Feb 2018 10:51:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018