coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: soc/amd/common: Improve misc. formatting in AGESA wrapper
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22889 ) Change subject: soc/amd/common: Improve misc. formatting in AGESA wrapper ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67121/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21685/ : SUCCESS -- To view, visit https://review.coreboot.org/22889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40985e0cf50df6aa4d830937e7f6b6e7908f72fe Gerrit-Change-Number: 22889 Gerrit-PatchSet: 9 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 01:22:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/stage_cache: Add save/get raw storage
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23518 ) Change subject: lib/stage_cache: Add save/get raw storage ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67118/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21683/ : SUCCESS -- To view, visit https://review.coreboot.org/23518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0b25ebe14c176bbd24fc8942f902f627ca8e6f Gerrit-Change-Number: 23518 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 01:19:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common: Add generic create_struct call to wrapper
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23440 ) Change subject: soc/amd/common: Add generic create_struct call to wrapper ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67122/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21687/ : SUCCESS -- To view, visit https://review.coreboot.org/23440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2654b4f21de5a2621086142681181a687be2c8e3 Gerrit-Change-Number: 23440 Gerrit-PatchSet: 6 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 01:18:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: amd/stoneyridge: Put stage cache into TSEG
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23519 ) Change subject: amd/stoneyridge: Put stage cache into TSEG ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67119/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21684/ : SUCCESS -- To view, visit https://review.coreboot.org/23519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1073af04475d862753136c9e14e2b2dde31fe66 Gerrit-Change-Number: 23519 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 01:05:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common: Add S3 supporting functions
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22727 ) Change subject: soc/amd/common: Add S3 supporting functions ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67120/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21682/ : SUCCESS -- To view, visit https://review.coreboot.org/22727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie60162ea10f053393bc84e927dbd80c9279e6b63 Gerrit-Change-Number: 22727 Gerrit-PatchSet: 13 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 01:04:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/poppy: Enable EC_ENABLE_SECOND_BATTERY_DEVICE
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23599 ) Change subject: mb/google/poppy/variants/poppy: Enable EC_ENABLE_SECOND_BATTERY_DEVICE ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67117/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21681/ : SUCCESS -- To view, visit https://review.coreboot.org/23599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I869bf08341b83f359066709e1e9c03af99482b2c Gerrit-Change-Number: 23599 Gerrit-PatchSet: 2 Gerrit-Owner: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 00:55:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: WIP: meowth: re-enable software sync
by Caveh Jalali (Code Review) 07 Feb '18

07 Feb '18

Caveh Jalali has uploaded this change for review. ( https://review.coreboot.org/23630 Change subject: WIP: meowth: re-enable software sync ...................................................................... WIP: meowth: re-enable software sync we had disabled software sync for bringup - we now have enough functionality in place to turn on software sync. Change-Id: Ib7f5a24ed8a47cb44b3f505e3cd49e0cb6931dc0 Signed-off-by: Caveh Jalali <caveh(a)google.com> --- M src/mainboard/google/zoombini/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/23630/1 diff --git a/src/mainboard/google/zoombini/Kconfig b/src/mainboard/google/zoombini/Kconfig index 64180f3..1a320b1 100644 --- a/src/mainboard/google/zoombini/Kconfig +++ b/src/mainboard/google/zoombini/Kconfig @@ -71,7 +71,6 @@ select EC_GOOGLE_CHROMEEC_SWITCHES select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN - select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select VBOOT_LID_SWITCH if BASEBOARD_ZOOMBINI_LAPTOP # Select this option to enable use of cr50 I2C TPM on zoombini. -- To view, visit https://review.coreboot.org/23630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7f5a24ed8a47cb44b3f505e3cd49e0cb6931dc0 Gerrit-Change-Number: 23630 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com>

1 0

Change in coreboot[master]: chromeec: Add support for reading second battery info
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23598 ) Change subject: chromeec: Add support for reading second battery info ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67116/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21680/ : SUCCESS -- To view, visit https://review.coreboot.org/23598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib06176e6ab4c45a899259f0917e6292121865ed6 Gerrit-Change-Number: 23598 Gerrit-PatchSet: 2 Gerrit-Owner: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nicolas Boichat <drinkcat(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 00:50:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: WIP amd/stoneyridge: Add FCH restore functions
by Marshall Dawson (Code Review) 07 Feb '18

07 Feb '18

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/23629 Change subject: WIP amd/stoneyridge: Add FCH restore functions ...................................................................... WIP amd/stoneyridge: Add FCH restore functions This is currently a placeholder which mimics the traditional methodology for reinitializing the FCH during a resume. It will be unnecessary if AGESA is modified to execute these steps internally. Change-Id: I12e302d8d690725d87caf63211eec7fcd67a7b0a Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/chip.c M src/soc/amd/stoneyridge/northbridge.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/23629/1 diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c index f5efcfd..f95fc1d 100644 --- a/src/soc/amd/stoneyridge/chip.c +++ b/src/soc/amd/stoneyridge/chip.c @@ -123,6 +123,11 @@ post_code(0x46); do_agesawrapper(agesawrapper_amds3laterestore, "amds3laterestore"); + + /* Begin the FCH restore */ + post_code(0x47); + do_agesawrapper(agesawrapper_fchs3earlyrestore, + "fchs3earlyrestore"); } } diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 2449077..c78d113 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -429,6 +429,9 @@ /* Must be called after PCI enumeration and resource allocation */ if (!romstage_handoff_is_resume()) do_agesawrapper(agesawrapper_amdinitmid, "amdinitmid"); + else + do_agesawrapper(agesawrapper_fchs3laterestore, + "fchs3laterestore"); } void domain_set_resources(device_t dev) -- To view, visit https://review.coreboot.org/23629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I12e302d8d690725d87caf63211eec7fcd67a7b0a Gerrit-Change-Number: 23629 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: security/vboot: overwrite existing spaces during factory init for tpm2
by build bot (Jenkins) (Code Review) 07 Feb '18

07 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23456 ) Change subject: security/vboot: overwrite existing spaces during factory init for tpm2 ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67115/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21679/ : SUCCESS -- To view, visit https://review.coreboot.org/23456 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48d8bb4f9fc0e5276e6ec81247b3b6768ec9fa3b Gerrit-Change-Number: 23456 Gerrit-PatchSet: 4 Gerrit-Owner: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Feb 2018 00:37:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018