coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/lenovo/t520/romstage: Remove unused includes
by Arthur Heymans (Code Review) 06 Dec '18

06 Dec '18

Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30043 ) Change subject: mb/lenovo/t520/romstage: Remove unused includes ...................................................................... mb/lenovo/t520/romstage: Remove unused includes Tested - Lenovo t520 still builds fine with this patch. Change-Id: I82492c071ca760f0790b992acbdb86021f470cfe Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/30043 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/t520/romstage.c 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved diff --git a/src/mainboard/lenovo/t520/romstage.c b/src/mainboard/lenovo/t520/romstage.c index d4c2f91..b7bdbbb 100644 --- a/src/mainboard/lenovo/t520/romstage.c +++ b/src/mainboard/lenovo/t520/romstage.c @@ -16,18 +16,12 @@ */ #include <stdint.h> -#include <string.h> -#include <timestamp.h> #include <arch/byteorder.h> #include <arch/io.h> #include <device/pci_def.h> -#include <device/pnp_def.h> -#include <cpu/x86/lapic.h> -#include <arch/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/common/gpio.h> #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <device/device.h> #include <device/pci.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/30043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82492c071ca760f0790b992acbdb86021f470cfe Gerrit-Change-Number: 30043 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer for boards I've ported
by Patrick Rudolph (Code Review) 06 Dec '18

06 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30075 ) Change subject: MAINTAINERS: Add myself as a maintainer for boards I've ported ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41363685bb5c84ce15698f96e58f6a5da9bd2ba2 Gerrit-Change-Number: 30075 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 07:20:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Modify SPD for hynix memory part
by Ren Kuo (Code Review) 06 Dec '18

06 Dec '18

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30076 ) Change subject: mb/google/poppy/variants/nami: Modify SPD for hynix memory part ...................................................................... Patch Set 1: Please help to approve to catch up the ekko/bard EVT Build -- To view, visit https://review.coreboot.org/c/coreboot/+/30076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33343eb1269919fba324333897805da1d1ff9b Gerrit-Change-Number: 30076 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vincent Wang <vwang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 07:11:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Modify SPD for hynix memory part
by Ren Kuo (Code Review) 06 Dec '18

06 Dec '18

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30076 ) Change subject: mb/google/poppy/variants/nami: Modify SPD for hynix memory part ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33343eb1269919fba324333897805da1d1ff9b Gerrit-Change-Number: 30076 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vincent Wang <vwang(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 07:07:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Modify SPD for hynix memory part
by Ren Kuo (Code Review) 06 Dec '18

06 Dec '18

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30076 Change subject: mb/google/poppy/variants/nami: Modify SPD for hynix memory part ...................................................................... mb/google/poppy/variants/nami: Modify SPD for hynix memory part correct memory part name form hynix_dimm_H5ANAG6NCMR-VKC to hynix_dimm_H5AN4G6NAFR-UHC BUG=b:113983573 BRANCH=Nami TEST=emerge-nami coreboot chromeos-bootimage Change-Id: I0c33343eb1269919fba324333897805da1d1ff9b Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- R src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex M src/mainboard/google/poppy/variants/nami/Makefile.inc 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/30076/1 diff --git a/src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAFR-UHC.spd.hex b/src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex similarity index 93% rename from src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAFR-UHC.spd.hex rename to src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex index 9a702ce..4aaa98d 100644 --- a/src/mainboard/google/poppy/spd/hynix_dimm_H5ANAG6NAFR-UHC.spd.hex +++ b/src/mainboard/google/poppy/spd/hynix_dimm_H5AN4G6NAFR-UHC.spd.hex @@ -18,8 +18,8 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -80 AD 01 00 00 00 00 00 00 48 4D 41 34 32 35 53 -36 41 46 52 36 4E 2D 55 48 20 20 20 20 00 80 AD +80 AD 01 00 00 00 00 00 00 48 35 41 4E 34 47 36 +4E 41 46 52 2D 55 48 43 20 20 20 20 20 00 80 AD FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DD 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc index 690b9c8..f1808ca 100644 --- a/src/mainboard/google/poppy/variants/nami/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc @@ -11,7 +11,7 @@ SPD_SOURCES += samsung_dimm_K4A4G165WE-BCRC # 0b0111 SPD_SOURCES += samsung_dimm_K4A8G165WC-BCTD # 0b1000 SPD_SOURCES += samsung_dimm_K4AAG165WB-MCRC # 0b1001 -SPD_SOURCES += hynix_dimm_H5ANAG6NAFR-UHC # 0b1010 +SPD_SOURCES += hynix_dimm_H5AN4G6NAFR-UHC # 0b1010 SPD_SOURCES += empty_ddr4 # 0b1011 SPD_SOURCES += empty_ddr4 # 0b1100 SPD_SOURCES += micron_dimm_MT40A1G16KNR-075E # 0b1101 -- To view, visit https://review.coreboot.org/c/coreboot/+/30076 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c33343eb1269919fba324333897805da1d1ff9b Gerrit-Change-Number: 30076 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer for boards I've ported
by Tristan Corrick (Code Review) 06 Dec '18

06 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30075 ) Change subject: MAINTAINERS: Add myself as a maintainer for boards I've ported ...................................................................... Patch Set 1: Could I also please be given the ability to give +2 code reviews? -- To view, visit https://review.coreboot.org/c/coreboot/+/30075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41363685bb5c84ce15698f96e58f6a5da9bd2ba2 Gerrit-Change-Number: 30075 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 06:46:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer for boards I've ported
by Tristan Corrick (Code Review) 06 Dec '18

06 Dec '18

Tristan Corrick has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30075 Change subject: MAINTAINERS: Add myself as a maintainer for boards I've ported ...................................................................... MAINTAINERS: Add myself as a maintainer for boards I've ported Change-Id: I41363685bb5c84ce15698f96e58f6a5da9bd2ba2 Signed-off-by: Tristan Corrick <tristan(a)corrick.kiwi> --- M MAINTAINERS 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/30075/1 diff --git a/MAINTAINERS b/MAINTAINERS index 0dab855..f90315e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -324,6 +324,11 @@ S: Maintained F: src/mainboard/asrock/g41c-gs/ +ASROCK H81M-HDS MAINBOARD +M: Tristan Corrick <tristan(a)corrick.kiwi> +S: Maintained +F: src/mainboard/asrock/h81m-hds/ + ASUS KFSN4-DRE & KFSN4-DRE_K8 MAINBOARDS M: Timothy Pearson <tpearson(a)raptorengineeringinc.com> S: Supported @@ -340,11 +345,21 @@ S: Supported F: src/mainboard/asus/kgpe-d16/ +ASUS MAXIMUS IV GENE-Z MAINBOARD +M: Tristan Corrick <tristan(a)corrick.kiwi> +S: Maintained +F: src/mainboard/asus/maximus_iv_gene-z/ + ASUS P5QC PRO MAINBOARD & VARIANTS M: Angel Pons <th3fanbus(a)gmail.com> S: Maintained F: src/mainboard/asus/p5qc/ +ASUS P8H61-M LX MAINBOARD +M: Tristan Corrick <tristan(a)corrick.kiwi> +S: Maintained +F: src/mainboard/asus/p8h61-m_lx/ + ASUS P8H61-M PRO MAINBOARD M: Angel Pons <th3fanbus(a)gmail.com> S: Maintained -- To view, visit https://review.coreboot.org/c/coreboot/+/30075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41363685bb5c84ce15698f96e58f6a5da9bd2ba2 Gerrit-Change-Number: 30075 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/apollolake: Print ME version on exit of BS_DEV_INIT stage
by Karthik Ramasubramanian (Code Review) 06 Dec '18

06 Dec '18

Hello Karthikeyan Ramasubramanian, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/30074 to review the following change. Change subject: soc/intel/apollolake: Print ME version on exit of BS_DEV_INIT stage ...................................................................... soc/intel/apollolake: Print ME version on exit of BS_DEV_INIT stage Print ME version on exit of BS_DEV_INIT stage so that the HECI device stays in D3 state as configured by FSP. BRANCH=octopus BUG=b:120571529 TEST=Ensure that the ME version gets printed in BIOS logs. Ensure that the device boots to ChromeOS. Ensure that the device enters S0ix successfully(using suspend_stress_test -c 25). Change-Id: I85bc45003a040c8347f929457792d78a9a077c6c Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/soc/intel/apollolake/cse.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/30074/1 diff --git a/src/soc/intel/apollolake/cse.c b/src/soc/intel/apollolake/cse.c index 26249bc..d761a6c 100644 --- a/src/soc/intel/apollolake/cse.c +++ b/src/soc/intel/apollolake/cse.c @@ -195,7 +195,7 @@ return reg; } -static void dump_cse_version(void) +static void dump_cse_version(void *unused) { int res; size_t reply_size; @@ -282,8 +282,6 @@ printk(BIOS_DEBUG, "unknown"); } printk(BIOS_DEBUG, "\n"); - - dump_cse_version(); } #define PCR_PSFX_T0_SHDW_PCIEN 0x1C @@ -307,3 +305,4 @@ } BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_ENTRY, fpf_blown, NULL); +BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, dump_cse_version, NULL); -- To view, visit https://review.coreboot.org/c/coreboot/+/30074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85bc45003a040c8347f929457792d78a9a077c6c Gerrit-Change-Number: 30074 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: HACK: Julius' changes for v18
by Julius Werner (Code Review) 06 Dec '18

06 Dec '18

Julius Werner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29521 ) Change subject: HACK: Julius' changes for v18 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/29521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8c222c152b2f6925c6c5a391a2c7b51e36d54df Gerrit-Change-Number: 29521 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/google/octopus: Override emmc DLL values for Yorp
by Bora Guvendik (Code Review) 06 Dec '18

06 Dec '18

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30073 Change subject: mb/google/octopus: Override emmc DLL values for Yorp ...................................................................... mb/google/octopus: Override emmc DLL values for Yorp New emmc DLL values for Yorp. BUG=b:120561055 BRANCH=octopus TEST=Boot to OS, chromeos-install, mmc_test Change-Id: I771c959a15959160224f056c0a16aa65bfbba94e Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/mainboard/google/octopus/variants/yorp/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/30073/1 diff --git a/src/mainboard/google/octopus/variants/yorp/overridetree.cb b/src/mainboard/google/octopus/variants/yorp/overridetree.cb index de711ba..8d4cd15 100644 --- a/src/mainboard/google/octopus/variants/yorp/overridetree.cb +++ b/src/mainboard/google/octopus/variants/yorp/overridetree.cb @@ -1,5 +1,46 @@ chip soc/intel/apollolake + # EMMC Tx CMD Delay + # Refer to EDS-Vol2-16.32. + # [14:8] steps of delay for DDR mode, each 125ps. + # [6:0] steps of delay for SDR mode, each 125ps. + register "emmc_tx_cmd_cntl" = "0x505" + + # EMMC TX DATA Delay 1 + # Refer to EDS-Vol2-16.33. + # [14:8] steps of delay for HS400, each 125ps. + # [6:0] steps of delay for SDR104/HS200, each 125ps. + register "emmc_tx_data_cntl1" = "0x0A12" + + # EMMC TX DATA Delay 2 + # Refer to EDS-Vol2-16.34. + # [30:24] steps of delay for SDR50, each 125ps. + # [22:16] steps of delay for DDR50, each 125ps. + # [14:8] steps of delay for SDR25/HS50, each 125ps. + # [6:0] steps of delay for SDR12, each 125ps. + register "emmc_tx_data_cntl2" = "0x1c282828" + + # EMMC RX CMD/DATA Delay 1 + # Refer to EDS-Vol2-16.35. + # [30:24] steps of delay for SDR50, each 125ps. + # [22:16] steps of delay for DDR50, each 125ps. + # [14:8] steps of delay for SDR25/HS50, each 125ps. + # [6:0] steps of delay for SDR12, each 125ps. + register "emmc_rx_cmd_data_cntl1" = "0x00195959" + + # EMMC RX CMD/DATA Delay 2 + # Refer to EDS-Vol2-16.37. + # [17:16] stands for Rx Clock before Output Buffer + # [14:8] steps of delay for Auto Tuning Mode, each 125ps. + # [6:0] steps of delay for HS200, each 125ps. + register "emmc_rx_cmd_data_cntl2" = "0x10025" + + # EMMC Rx Strobe Delay + # Refer to EDS-Vol2-16.36. + # [14:8] Rx Strobe Delay DLL 1(HS400 Mode), each 125ps. + # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps. + register "emmc_rx_strobe_cntl" = "0x0a0a" + device domain 0 on device pci 16.0 on chip drivers/i2c/hid -- To view, visit https://review.coreboot.org/c/coreboot/+/30073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I771c959a15959160224f056c0a16aa65bfbba94e Gerrit-Change-Number: 30073 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018