coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/intel/icelake_rvp: Fill Icelake U and Y RVP devicetree parameters
by Subrata Banik (Code Review) 06 Dec '18

06 Dec '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30015 ) Change subject: mb/intel/icelake_rvp: Fill Icelake U and Y RVP devicetree parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585e82799eea0bad19ad2c94d6b4b3024f930ed4 Gerrit-Change-Number: 30015 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 09:48:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src: Get rid of "#define __SIMPLE_DEVICE__"
by HAOUAS Elyes (Code Review) 06 Dec '18

06 Dec '18

Hello Alexander Couzens, Patrick Rudolph, York Yang, Philipp Deppenwiese, build bot (Jenkins), Damien Zammit, David Guckian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30040 to look at the new patch set (#4). Change subject: src: Get rid of "#define __SIMPLE_DEVICE__" ...................................................................... src: Get rid of "#define __SIMPLE_DEVICE__" Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/storage/pci_sdhci.c M src/drivers/uart/oxpcie_early.c M src/mainboard/intel/galileo/reg_access.c M src/mainboard/lenovo/t400/dock.c M src/mainboard/lenovo/x201/dock.c M src/northbridge/amd/pi/ramtop.c M src/northbridge/intel/e7505/memmap.c M src/northbridge/intel/i440bx/ram_calc.c M src/northbridge/intel/pineview/ram_calc.c M src/northbridge/via/vx900/memmap.c M src/soc/amd/stoneyridge/enable_usbdebug.c M src/soc/amd/stoneyridge/ramtop.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/broadwell/usb_debug.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/lpc/lpc_lib.c M src/soc/intel/icelake/pmutil.c M src/soc/intel/quark/reg_access.c M src/southbridge/amd/agesa/hudson/enable_usbdebug.c M src/southbridge/amd/cimx/sb900/early.c M src/southbridge/amd/cimx/sb900/reset.c M src/southbridge/amd/pi/hudson/enable_usbdebug.c M src/southbridge/amd/pi/hudson/imc.c M src/southbridge/amd/sb700/enable_usbdebug.c M src/southbridge/amd/sb800/enable_usbdebug.c M src/southbridge/intel/common/usb_debug.c M src/southbridge/nvidia/ck804/enable_usbdebug.c M src/southbridge/nvidia/mcp55/enable_usbdebug.c 28 files changed, 0 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/30040/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0 Gerrit-Change-Number: 30040 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
by HAOUAS Elyes (Code Review) 06 Dec '18

06 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30044 to look at the new patch set (#5). Change subject: soc/amd/stoneyridge: Get rid of device_t ...................................................................... soc/amd/stoneyridge: Get rid of device_t Use of device_t is deprecated. Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/30044/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/30044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Gerrit-Change-Number: 30044 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
by build bot (Jenkins) (Code Review) 06 Dec '18

06 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30044 ) Change subject: soc/amd/stoneyridge: Get rid of device_t ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/30044/4/src/soc/amd/stoneyridge/southbridge… File src/soc/amd/stoneyridge/southbridge.c: https://review.coreboot.org/#/c/30044/4/src/soc/amd/stoneyridge/southbridge… PS4, Line 712: printk(BIOS_DEBUG, "%s\n", __func__); code indent should use tabs where possible https://review.coreboot.org/#/c/30044/4/src/soc/amd/stoneyridge/southbridge… PS4, Line 712: printk(BIOS_DEBUG, "%s\n", __func__); please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/30044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Gerrit-Change-Number: 30044 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 08:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
by HAOUAS Elyes (Code Review) 06 Dec '18

06 Dec '18

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30044 ) Change subject: soc/amd/stoneyridge: Get rid of device_t ...................................................................... Patch Set 4: > (1 comment) it is used here: src/soc/amd/stoneyridge/chip.c:131 -- To view, visit https://review.coreboot.org/c/coreboot/+/30044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Gerrit-Change-Number: 30044 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 08:27:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
by HAOUAS Elyes (Code Review) 06 Dec '18

06 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30044 to look at the new patch set (#4). Change subject: soc/amd/stoneyridge: Get rid of device_t ...................................................................... soc/amd/stoneyridge: Get rid of device_t Use of device_t is deprecated. Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 11 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/30044/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Gerrit-Change-Number: 30044 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
by HAOUAS Elyes (Code Review) 06 Dec '18

06 Dec '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30044 to look at the new patch set (#3). Change subject: soc/amd/stoneyridge: Get rid of device_t ...................................................................... soc/amd/stoneyridge: Get rid of device_t Use of device_t is deprecated. Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/30044/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Gerrit-Change-Number: 30044 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
by Patrick Rudolph (Code Review) 06 Dec '18

06 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30044 ) Change subject: soc/amd/stoneyridge: Get rid of device_t ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/30044/2/src/soc/amd/stoneyridge/southbridge… File src/soc/amd/stoneyridge/southbridge.c: https://review.coreboot.org/#/c/30044/2/src/soc/amd/stoneyridge/southbridge… PS2, Line 709: void sb_enable(struct device *dev) is it used somewhere ? looks like dead code -- To view, visit https://review.coreboot.org/c/coreboot/+/30044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602 Gerrit-Change-Number: 30044 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 07:33:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/southbridge: Get rid of device_t
by Patrick Rudolph (Code Review) 06 Dec '18

06 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30045 ) Change subject: src/southbridge: Get rid of device_t ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4db9c263ff156966926f9576eed7e3cfb02e78a Gerrit-Change-Number: 30045 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Comment-Date: Thu, 06 Dec 2018 07:27:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src: Get rid of "#define __SIMPLE_DEVICE__"
by HAOUAS Elyes (Code Review) 06 Dec '18

06 Dec '18

Hello Alexander Couzens, Patrick Rudolph, York Yang, Philipp Deppenwiese, build bot (Jenkins), Damien Zammit, David Guckian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30040 to look at the new patch set (#3). Change subject: src: Get rid of "#define __SIMPLE_DEVICE__" ...................................................................... src: Get rid of "#define __SIMPLE_DEVICE__" Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/commonlib/storage/pci_sdhci.c M src/drivers/uart/oxpcie_early.c M src/mainboard/intel/galileo/reg_access.c M src/mainboard/lenovo/t400/dock.c M src/mainboard/lenovo/x201/dock.c M src/northbridge/amd/pi/ramtop.c M src/northbridge/intel/e7505/memmap.c M src/northbridge/intel/fsp_rangeley/port_access.c M src/northbridge/intel/gm45/ram_calc.c M src/northbridge/intel/haswell/ram_calc.c M src/northbridge/intel/i440bx/ram_calc.c M src/northbridge/intel/i945/ram_calc.c M src/northbridge/intel/nehalem/ram_calc.c M src/northbridge/intel/pineview/ram_calc.c M src/northbridge/intel/sandybridge/ram_calc.c M src/northbridge/intel/x4x/ram_calc.c M src/northbridge/via/vx900/memmap.c M src/soc/amd/stoneyridge/enable_usbdebug.c M src/soc/amd/stoneyridge/ramtop.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/broadwell/usb_debug.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/lpc/lpc_lib.c M src/soc/intel/icelake/pmutil.c M src/soc/intel/quark/reg_access.c M src/southbridge/amd/agesa/hudson/enable_usbdebug.c M src/southbridge/amd/cimx/sb800/reset.c M src/southbridge/amd/cimx/sb900/early.c M src/southbridge/amd/cimx/sb900/reset.c M src/southbridge/amd/pi/hudson/enable_usbdebug.c M src/southbridge/amd/pi/hudson/imc.c M src/southbridge/amd/pi/hudson/reset.c M src/southbridge/amd/sb700/enable_usbdebug.c M src/southbridge/amd/sb700/reset.c M src/southbridge/amd/sb800/enable_usbdebug.c M src/southbridge/intel/common/usb_debug.c M src/southbridge/nvidia/ck804/enable_usbdebug.c M src/southbridge/nvidia/mcp55/enable_usbdebug.c 38 files changed, 0 insertions(+), 94 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/30040/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0 Gerrit-Change-Number: 30040 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018