coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: src/cpu/intel: Set get_ia32_fsb function common
by HAOUAS Elyes (Code Review) 08 Dec '18

08 Dec '18

Hello Patrick Rudolph, Arthur Heymans, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30103 to look at the new patch set (#2). Change subject: src/cpu/intel: Set get_ia32_fsb function common ...................................................................... src/cpu/intel: Set get_ia32_fsb function common get_ia32_fsb will return FSB values of intel's CPUs. Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/common/Makefile.inc A src/cpu/intel/common/fsb.c M src/cpu/x86/lapic/apic_timer.c A src/include/cpu/intel/fsb.h 4 files changed, 91 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/30103/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28 Gerrit-Change-Number: 30103 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: src/cpu/intel: Set get_ia32_fsb function common
by Arthur Heymans (Code Review) 08 Dec '18

08 Dec '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 ) Change subject: src/cpu/intel: Set get_ia32_fsb function common ...................................................................... Patch Set 1: Put replacing current implementations also in this patchset. -- To view, visit https://review.coreboot.org/c/coreboot/+/30103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28 Gerrit-Change-Number: 30103 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 08 Dec 2018 13:07:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: buildgcc: Update IASL to version 20181031
by HAOUAS Elyes (Code Review) 08 Dec '18

08 Dec '18

HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/30111 ) Change subject: buildgcc: Update IASL to version 20181031 ...................................................................... buildgcc: Update IASL to version 20181031 Change-Id: Ic83f4e220b7bcf0cfafa8dcb95f575b576e84996 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20181031_iasl.patch D util/crossgcc/sum/acpica-unix2-20180810.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20181031.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/30111/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83f4e220b7bcf0cfafa8dcb95f575b576e84996 Gerrit-Change-Number: 30111 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: buildgcc: Update IASL to version 20181031
by HAOUAS Elyes (Code Review) 08 Dec '18

08 Dec '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30111 Change subject: buildgcc: Update IASL to version 20181031 ...................................................................... buildgcc: Update IASL to version 20181031 Change-Id: Ic83f4e220b7bcf0cfafa8dcb95f575b576e84996 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/patches/acpica-unix2-20180810_iasl.patch D util/crossgcc/sum/acpica-unix2-20180810.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20181031.tar.gz.cksum 4 files changed, 2 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/30111/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index dea42ad..45293cc 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.30 GDB_VERSION=8.0 -IASL_VERSION=20180810 +IASL_VERSION=20181031 PYTHON_VERSION=3.5.1 EXPAT_VERSION=2.2.1 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20180810_iasl.patch b/util/crossgcc/patches/acpica-unix2-20180810_iasl.patch deleted file mode 100644 index 58ccb02..0000000 --- a/util/crossgcc/patches/acpica-unix2-20180810_iasl.patch +++ /dev/null @@ -1,27 +0,0 @@ -diff -Naur acpica-unix2-20180810_/source/compiler/asloptions.c acpica-unix2-20180810/source/compiler/asloptions.c > acpica-unix2-20180810_iasl.patch ---- acpica-unix2-20180810_/source/compiler/asloptions.c -+++ acpica-unix2-20180810/source/compiler/asloptions.c -@@ -126,6 +126,7 @@ - if (Gbl_DoSignon) - { - printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); -+ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); - if (Gbl_IgnoreErrors) - { - printf ("Ignoring all errors, forcing AML file generation\n\n"); -@@ -753,6 +754,7 @@ - case '^': - - printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); -+ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); - exit (0); - - case 'a': -@@ -766,6 +768,7 @@ - - printf (ACPI_COMMON_SIGNON (ASL_COMPILER_NAME)); - printf (ACPI_COMMON_BUILD_TIME); -+ printf ("%s\n", COREBOOT_TOOLCHAIN_VERSION); - exit (0); - - case 'e': diff --git a/util/crossgcc/sum/acpica-unix2-20180810.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20180810.tar.gz.cksum deleted file mode 100644 index 5bb6076..0000000 --- a/util/crossgcc/sum/acpica-unix2-20180810.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -b8e1a287557dda6f4b71c4172a7a9123b6ffaf2a tarballs/acpica-unix2-20180810.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20181031.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20181031.tar.gz.cksum new file mode 100644 index 0000000..2866867 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20181031.tar.gz.cksum @@ -0,0 +1 @@ +a696e9562ad18d7cccc3bba92230d69c0b80b9f2 tarballs/acpica-unix2-20181031.tar.gz -- To view, visit https://review.coreboot.org/c/coreboot/+/30111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic83f4e220b7bcf0cfafa8dcb95f575b576e84996 Gerrit-Change-Number: 30111 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Modul...
by David Wu (Code Review) 08 Dec '18

08 Dec '18

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30049 ) Change subject: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number ...................................................................... Patch Set 3: (1 comment) Done. Thanks. https://review.coreboot.org/#/c/30049/2/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex: https://review.coreboot.org/#/c/30049/2/src/mainboard/google/kahlee/variant… PS2, Line 23: 20 20 > It looks like according to the spec these should both be 20. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/30049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff Gerrit-Change-Number: 30049 Gerrit-PatchSet: 3 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 08 Dec 2018 08:38:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Modul...
by David Wu (Code Review) 08 Dec '18

08 Dec '18

David Wu has uploaded a new patch set (#3) to the change originally created by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/30049 ) Change subject: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number ...................................................................... google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number Correct Ram_ID=0b0011 SPD Module Part Number to "MT40A1G16KNR-075:E" from "4ATS1G64HZ-2G6E1". BUG=b:120000816 BRANCH=master TEST=mosys memory spd print all Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff Signed-off-by: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30049/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff Gerrit-Change-Number: 30049 Gerrit-PatchSet: 3 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: WIP: turn on CLK_AB2 DMIC
by build bot (Jenkins) (Code Review) 08 Dec '18

08 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30110 ) Change subject: WIP: turn on CLK_AB2 DMIC ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30110/1/src/mainboard/google/octopus/varian… File src/mainboard/google/octopus/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/30110/1/src/mainboard/google/octopus/varian… PS1, Line 240: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_174, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_AB2 */ line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/30110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I428b8737ca384bac0594d1f1b608644e14a2aa6d Gerrit-Change-Number: 30110 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 08 Dec 2018 00:20:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: WIP: turn on CLK_AB2 DMIC
by Sathyanarayana Nujella (Code Review) 08 Dec '18

08 Dec '18

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30110 ) Change subject: WIP: turn on CLK_AB2 DMIC ...................................................................... Patch Set 1: Code-Review-1 under test -- To view, visit https://review.coreboot.org/c/coreboot/+/30110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I428b8737ca384bac0594d1f1b608644e14a2aa6d Gerrit-Change-Number: 30110 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Comment-Date: Sat, 08 Dec 2018 00:20:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: WIP: turn on CLK_AB2 DMIC
by Sathyanarayana Nujella (Code Review) 08 Dec '18

08 Dec '18

Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30110 Change subject: WIP: turn on CLK_AB2 DMIC ...................................................................... WIP: turn on CLK_AB2 DMIC Some variants of Octopus has DMIC's attached to PDM2 section. CLK_AB2 should be used for DMIC3 and DMIC4 BUG=NA TEST=None Change-Id: I428b8737ca384bac0594d1f1b608644e14a2aa6d Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> --- M src/mainboard/google/octopus/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30110/1 diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 877cd76..972f303 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -237,7 +237,7 @@ PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_171, DN_20K, DEEP, NF1), /* AVS_M_CLK_A1 -- DMIC_CLK1 */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_172, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_B1 */ PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_173, DN_20K, DEEP, NF1), /* AVS_M_DATA_1 -- DMIC_DATA */ - PAD_NC(GPIO_174, DN_20K), /* AVS_M_CLK_AB2 -- unused */ + PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_174, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_AB2 */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_175, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_DATA_2 */ /* SCC COMMUNITY GPIOS */ -- To view, visit https://review.coreboot.org/c/coreboot/+/30110 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I428b8737ca384bac0594d1f1b608644e14a2aa6d Gerrit-Change-Number: 30110 Gerrit-PatchSet: 1 Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Work in progress: Early eMMC phase 1
by build bot (Jenkins) (Code Review) 07 Dec '18

07 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30109 ) Change subject: Work in progress: Early eMMC phase 1 ...................................................................... Patch Set 1: (13 comments) https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c File src/drivers/emmc/bh7720/bh720.c: https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@97 PS1, Line 97: if(flag) { space required before the open parenthesis '(' https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@97 PS1, Line 97: if(flag) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@108 PS1, Line 108: if (mode & MODE_DIS_SD) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@110 PS1, Line 110: if (mode & MODE_VCCQ_18) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@112 PS1, Line 112: if (mode & MODE_POWER_SAVE) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@114 PS1, Line 114: if (mode & MODE_L1_TIMER) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@116 PS1, Line 116: if (mode & MODE_IDDQ) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@118 PS1, Line 118: if (mode & MODE_TUNNING) { 'TUNNING' may be misspelled - perhaps 'TUNING'? https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@118 PS1, Line 118: if (mode & MODE_TUNNING) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@120 PS1, Line 120: if (mode & MODE_DLL_CLK_PHASE) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h File src/include/device/emmc/bh720.h: https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h@35 PS1, Line 35: #define MODE_TUNNING BIT(6) 'TUNNING' may be misspelled - perhaps 'TUNING'? https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h@43 PS1, Line 43: * adress. 'adress' may be misspelled - perhaps 'address'? https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h@48 PS1, Line 48: * Note 2: MODE_DIS_SD, MODE_VCCQ_18, MODE_POWER_SAVE, MODE_IDDQ, MODE_TUNNING, 'TUNNING' may be misspelled - perhaps 'TUNING'? -- To view, visit https://review.coreboot.org/c/coreboot/+/30109 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd2a307ead37c62abca811654873c43c02ac2a4a Gerrit-Change-Number: 30109 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Dec 2018 21:27:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018