coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/intel/x200: Add data.vbt
by build bot (Jenkins) (Code Review) 10 Dec '18

10 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29904 ) Change subject: mb/intel/x200: Add data.vbt ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/29904/7/src/mainboard/lenovo/x200/blc.c File src/mainboard/lenovo/x200/blc.c: https://review.coreboot.org/#/c/29904/7/src/mainboard/lenovo/x200/blc.c@62 PS7, Line 62: } else { else is not generally useful after a break or return -- To view, visit https://review.coreboot.org/c/coreboot/+/29904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4a7011ce03cdd511fa2e2160c2f006ba2707ba Gerrit-Change-Number: 29904 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 10 Dec 2018 11:59:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/braswell: Correct code style
by Frans Hendriks (Code Review) 10 Dec '18

10 Dec '18

Frans Hendriks has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30126 ) Change subject: soc/intel/braswell: Correct code style ...................................................................... Abandoned Misinterpretation of coding style. -- To view, visit https://review.coreboot.org/c/coreboot/+/30126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: soc/intel/braswell: Correct code style
by Tristan Corrick (Code Review) 10 Dec '18

10 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30126 ) Change subject: soc/intel/braswell: Correct code style ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: Code-Review-1 > > > > Are you getting this as a warning from some tool? The coding style > > states that braces should be used for both branches of an if-else if > > at least one branch has multiple statements. > > I was not aware of this if-else rule. (Noticed 'unnecessary braces for single statement blocks' only) > > Shall I abondon this patch? I suggest abandoning it, yes. -- To view, visit https://review.coreboot.org/c/coreboot/+/30126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 11:34:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: cpuid: Move cpuid(1) function into arch/x86/cpu_common code
by build bot (Jenkins) (Code Review) 10 Dec '18

10 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30123 ) Change subject: cpuid: Move cpuid(1) function into arch/x86/cpu_common code ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/30123/2/src/northbridge/intel/haswell/repor… File src/northbridge/intel/haswell/report_platform.c: https://review.coreboot.org/#/c/30123/2/src/northbridge/intel/haswell/repor… PS2, Line 56: printk(BIOS_DEBUG, "CPU id(%x) ucode:%08x %s\n", cpu_id, microcode_ver.hi, cpu_name); line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/30123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib96a7c79dadb1feff0b8d58aa408b355fbb3bc50 Gerrit-Change-Number: 30123 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 11:33:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/braswell: Correct code style
by Frans Hendriks (Code Review) 10 Dec '18

10 Dec '18

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30126 ) Change subject: soc/intel/braswell: Correct code style ...................................................................... Patch Set 1: > Patch Set 1: Code-Review-1 > > Are you getting this as a warning from some tool? The coding style > states that braces should be used for both branches of an if-else if > at least one branch has multiple statements. I was not aware of this if-else rule. (Noticed 'unnecessary braces for single statement blocks' only) Shall I abondon this patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/30126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 11:20:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/intel/x200: Add data.vbt
by build bot (Jenkins) (Code Review) 10 Dec '18

10 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29904 ) Change subject: mb/intel/x200: Add data.vbt ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29904/6/src/mainboard/lenovo/x200/blc.c File src/mainboard/lenovo/x200/blc.c: https://review.coreboot.org/#/c/29904/6/src/mainboard/lenovo/x200/blc.c@62 PS6, Line 62: } else { else is not generally useful after a break or return -- To view, visit https://review.coreboot.org/c/coreboot/+/29904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c4a7011ce03cdd511fa2e2160c2f006ba2707ba Gerrit-Change-Number: 29904 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 10 Dec 2018 11:06:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/braswell: Correct code style
by Tristan Corrick (Code Review) 10 Dec '18

10 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30126 ) Change subject: soc/intel/braswell: Correct code style ...................................................................... Patch Set 1: Code-Review-1 Are you getting this as a warning from some tool? The coding style states that braces should be used for both branches of an if-else if at least one branch has multiple statements. -- To view, visit https://review.coreboot.org/c/coreboot/+/30126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 11:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/braswell/northcluster.c: Fix typo
by Tristan Corrick (Code Review) 10 Dec '18

10 Dec '18

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30125 ) Change subject: soc/intel/braswell/northcluster.c: Fix typo ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/30125/1/src/soc/intel/braswell/northcluster… File src/soc/intel/braswell/northcluster.c: https://review.coreboot.org/#/c/30125/1/src/soc/intel/braswell/northcluster… PS1, Line 55: to enumerated Another possible fix: this should read "to be enumerated". -- To view, visit https://review.coreboot.org/c/coreboot/+/30125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79dde87007759b7cab92061df37fd3a19d5e3d1f Gerrit-Change-Number: 30125 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 10:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/braswell: Correct code style
by Frans Hendriks (Code Review) 10 Dec '18

10 Dec '18

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30126 Change subject: soc/intel/braswell: Correct code style ...................................................................... soc/intel/braswell: Correct code style Curly braces not required for this else statement BUG=N/A TEST=Intel CherryHill CRB Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20 Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> --- M src/soc/intel/braswell/southcluster.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/30126/1 diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index 6ea2ea9..0852b33 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -179,10 +179,10 @@ printk(BIOS_DEBUG, "Disabling slp_x stretching.\n"); write32(gen_pmcon1, read32(gen_pmcon1) | DIS_SLP_X_STRCH_SUS_UP); - } else { + } else write32(gen_pmcon1, read32(gen_pmcon1) & ~DIS_SLP_X_STRCH_SUS_UP); - } + /* Initialize i8254 timers */ setup_i8254(); -- To view, visit https://review.coreboot.org/c/coreboot/+/30126 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73764aac62762d270f63957cc917c1e4d3f0eb20 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/braswell: Correct configuration of interrupts
by build bot (Jenkins) (Code Review) 10 Dec '18

10 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29419 ) Change subject: soc/intel/braswell: Correct configuration of interrupts ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/29419/4/src/soc/intel/braswell/southcluster… File src/soc/intel/braswell/southcluster.c: https://review.coreboot.org/#/c/29419/4/src/soc/intel/braswell/southcluster… PS4, Line 167: /* Set the Interrupt line register as "unknown or unused" */ line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/29419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I128cb35dd0e348a9cd9fb162651e0aa2b7e4a3ef Gerrit-Change-Number: 29419 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Comment-Date: Mon, 10 Dec 2018 10:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018