coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: device/dram/ddr2: Add break to several case statements that lack it
by Patrick Georgi (Code Review) 22 Sep '17

22 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21642 Change subject: device/dram/ddr2: Add break to several case statements that lack it ...................................................................... device/dram/ddr2: Add break to several case statements that lack it For all valid SPD values the same decoded tRR was returned. Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Found-by: Coverity Scan #1381369, #1381370, 1381371, 1381372, 1381373 --- M src/device/dram/ddr2.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21642/1 diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index 6f43563..2dab681 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -194,16 +194,22 @@ return CB_ERR; case 0x80: *tRR = 15625 << 8; + break; case 0x81: *tRR = 15625 << 6; + break; case 0x82: *tRR = 15625 << 7; + break; case 0x83: *tRR = 15625 << 9; + break; case 0x84: *tRR = 15625 << 10; + break; case 0x85: *tRR = 15625 << 11; + break; } return CB_SUCCESS; } -- To view, visit https://review.coreboot.org/21642 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65 Gerrit-Change-Number: 21642 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Calculate soc reserved memory size
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21540 ) Change subject: soc/intel/skylake: Calculate soc reserved memory size ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60945/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16125/ : SUCCESS -- To view, visit https://review.coreboot.org/21540 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19583f7d18ca11c3a58eb61c927e5c3c3b65d2ec Gerrit-Change-Number: 21540 Gerrit-PatchSet: 13 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 16:22:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Calculate soc reserved memory size
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21540 ) Change subject: soc/intel/skylake: Calculate soc reserved memory size ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60938/ : SUCCESS -- To view, visit https://review.coreboot.org/21540 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19583f7d18ca11c3a58eb61c927e5c3c3b65d2ec Gerrit-Change-Number: 21540 Gerrit-PatchSet: 12 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 16:08:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Fix very long boot delays with USE_OPTION_TABLE
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21641 ) Change subject: mb/intel/dg43gt: Fix very long boot delays with USE_OPTION_TABLE ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60944/ : SUCCESS -- To view, visit https://review.coreboot.org/21641 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a23ef9577161084521b569fc3870a27f50624d1 Gerrit-Change-Number: 21641 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 16:06:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Fix very long boot delays with USE_OPTION_TABLE
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21641 ) Change subject: mb/intel/dg43gt: Fix very long boot delays with USE_OPTION_TABLE ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60943/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16124/ : SUCCESS -- To view, visit https://review.coreboot.org/21641 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a23ef9577161084521b569fc3870a27f50624d1 Gerrit-Change-Number: 21641 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 15:59:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/fizz: Enable EC-EFS support
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21640 ) Change subject: mainboard/google/fizz: Enable EC-EFS support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60942/ : SUCCESS -- To view, visit https://review.coreboot.org/21640 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie18536982e172a45703600eec6e183c1e7c12746 Gerrit-Change-Number: 21640 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 15:58:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60940/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16121/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 9 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 15:56:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 37: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60941/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16122/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 37 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 15:55:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/fizz: Enable EC-EFS support
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21640 ) Change subject: mainboard/google/fizz: Enable EC-EFS support ...................................................................... Patch Set 1: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/16123/ : SUCCESS -- To view, visit https://review.coreboot.org/21640 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie18536982e172a45703600eec6e183c1e7c12746 Gerrit-Change-Number: 21640 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 15:54:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related functions
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related functions ...................................................................... Patch Set 44: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60939/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16120/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 44 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 15:53:56 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017