coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: src/lib/Makefile.inc: Remove loaders subdirectory
by Jonathan Neuschäfer (Code Review) 22 Sep '17

22 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21643 Change subject: src/lib/Makefile.inc: Remove loaders subdirectory ...................................................................... src/lib/Makefile.inc: Remove loaders subdirectory src/lib/loaders was removed in commit 899d13d0df ("cbfs: new API and better program loading"). Change-Id: Ic7a9f5d83c5f9445bf24970e0c8cc645dd1944ff Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/lib/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/21643/1 diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index e50eba6..778bea8 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -12,7 +12,6 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # -subdirs-y += loaders subdirs-y += gnat ifeq ($(CONFIG_UBSAN),y) -- To view, visit https://review.coreboot.org/21643 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic7a9f5d83c5f9445bf24970e0c8cc645dd1944ff Gerrit-Change-Number: 21643 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: buildgcc: Implement simple tarball hash verification
by Jonathan Neuschäfer (Code Review) 22 Sep '17

22 Sep '17

Hello Philipp Deppenwiese, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21592 to look at the new patch set (#3). Change subject: buildgcc: Implement simple tarball hash verification ...................................................................... buildgcc: Implement simple tarball hash verification This patch implements a relatively simple hash-based verification scheme for downloaded files (tarballs): After buildgcc downloads a file or notices that it has already been downloaded, it hashes the file, and compares the hash against the known hash stored in util/crossgcc/sum/$filename.cksum. Two errors can occur: 1. The hash file is missing. In this case, crossgcc asks the user to verify the authenticity of the downloaded file. It also calculates its hash and stores it in util/crossgcc/sum/$filename.cksum.calc. If the file is authentic, the user may rename the calculated hash file to $filename.cksum, so that it can be found the next time buildgcc is started. 2. The known hash and the calculated hash differ. This is the case that this patch seeks to protect against, because it may imply that the downloaded file was unexpectedly changed, either in transit (Man-in-the-Middle attack) or on the file server that it was downloaded from. If buildgcc detects such a hash mismatch, it asks the user to delete the downloaded file and retry, because it can also be caused by a benign network error. If, however, the error persists, buildgcc can't continue without risking that the user runs malicious code, and it stops. Note: The hash algorithm may be changed in the future, but for now I left it at SHA-1, to avoid bloating this patch. TODO: Maybe improve the error messages Change-Id: I0d5d67b34684d02011a845d00f6f5b6769f43b4f Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M util/crossgcc/buildgcc 1 file changed, 92 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21592/3 -- To view, visit https://review.coreboot.org/21592 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d5d67b34684d02011a845d00f6f5b6769f43b4f Gerrit-Change-Number: 21592 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: mb/*/*: Remove rtc nvram configurable baud rate
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19682 ) Change subject: mb/*/*: Remove rtc nvram configurable baud rate ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60951/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16130/ : SUCCESS -- To view, visit https://review.coreboot.org/19682 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71698d9b188eeac73670b18b757dff5fcea0df41 Gerrit-Change-Number: 19682 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 18:24:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [RFC]mb/*/*/cmos.layout: Remove rtc nvram configurable debug level
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21637 ) Change subject: [RFC]mb/*/*/cmos.layout: Remove rtc nvram configurable debug level ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60950/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16129/ : SUCCESS -- To view, visit https://review.coreboot.org/21637 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8db4ba428ec51f9230bb5f3d2259ae9141308f81 Gerrit-Change-Number: 21637 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 18:20:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [RFC]mb/*/*/cmos.layout: Remove rtc nvram configurable debug level
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21637 ) Change subject: [RFC]mb/*/*/cmos.layout: Remove rtc nvram configurable debug level ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60949/ : ABORTED -- To view, visit https://review.coreboot.org/21637 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8db4ba428ec51f9230bb5f3d2259ae9141308f81 Gerrit-Change-Number: 21637 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 18:14:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21113 ) Change subject: sb/intel/common/spi.c: Port to i82801gx ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60948/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16128/ : SUCCESS -- To view, visit https://review.coreboot.org/21113 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 Gerrit-Change-Number: 21113 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 17:44:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER
by Nico Huber (Code Review) 22 Sep '17

22 Sep '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21320 ) Change subject: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER ...................................................................... Patch Set 2: Just noticed a minor inconsistency, models f3x and f4x don't select UDELAY_LAPIC. Seems to be supported for these models too, though. -- To view, visit https://review.coreboot.org/21320 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01059c8cbdc6a002dfd75b6da3a629811b137702 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 17:33:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER
by Nico Huber (Code Review) 22 Sep '17

22 Sep '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21320 ) Change subject: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER ...................................................................... nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER Needed for coreboot spi driver. Change-Id: I01059c8cbdc6a002dfd75b6da3a629811b137702 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/21320 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/northbridge/intel/x4x/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Nico Huber: Looks good to me, approved diff --git a/src/northbridge/intel/x4x/Kconfig b/src/northbridge/intel/x4x/Kconfig index 5517d97..9239637 100644 --- a/src/northbridge/intel/x4x/Kconfig +++ b/src/northbridge/intel/x4x/Kconfig @@ -22,6 +22,7 @@ config NORTHBRIDGE_SPECIFIC_OPTIONS # dummy def_bool y select HAVE_DEBUG_RAM_SETUP + select LAPIC_MONOTONIC_TIMER select VGA select INTEL_GMA_ACPI select RELOCATABLE_RAMSTAGE -- To view, visit https://review.coreboot.org/21320 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I01059c8cbdc6a002dfd75b6da3a629811b137702 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: device/dram/ddr2.c: Decoding byte[12] bit7 as self refresh flag
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21620 ) Change subject: device/dram/ddr2.c: Decoding byte[12] bit7 as self refresh flag ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60947/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16127/ : SUCCESS -- To view, visit https://review.coreboot.org/21620 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5 Gerrit-Change-Number: 21620 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 17:13:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2: Add break to several case statements that lack it
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21642 ) Change subject: device/dram/ddr2: Add break to several case statements that lack it ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60946/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16126/ : SUCCESS -- To view, visit https://review.coreboot.org/21642 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65 Gerrit-Change-Number: 21642 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 16:29:19 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017