coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: soc/intel/skylake: Use common/block/gpio
by build bot (Jenkins) (Code Review) 07 Sep '17

07 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19201 ) Change subject: soc/intel/skylake: Use common/block/gpio ...................................................................... Patch Set 42: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60018/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15265/ : SUCCESS -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 42 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-Comment-Date: Thu, 07 Sep 2017 15:36:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Configure clockgen
by build bot (Jenkins) (Code Review) 07 Sep '17

07 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21440 ) Change subject: mb/intel/dg43gt: Configure clockgen ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15263/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60016/ : SUCCESS -- To view, visit https://review.coreboot.org/21440 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b6bf33816f7e468a09ff5e2008c2cb9f7c0a8b Gerrit-Change-Number: 21440 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Sep 2017 15:33:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82801jx: Add smbus block operations
by build bot (Jenkins) (Code Review) 07 Sep '17

07 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21439 ) Change subject: sb/intel/i82801jx: Add smbus block operations ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15264/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60015/ : SUCCESS -- To view, visit https://review.coreboot.org/21439 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a84b4451efe25c1c3b0ce33ddbcb6ed06c29f9e Gerrit-Change-Number: 21439 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Sep 2017 15:22:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Select right gmbus port for VGA output
by build bot (Jenkins) (Code Review) 07 Sep '17

07 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21441 ) Change subject: mb/intel/dg43gt: Select right gmbus port for VGA output ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15262/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60017/ : SUCCESS -- To view, visit https://review.coreboot.org/21441 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bd9d451295d26a3e11ded9863f5d45d42c8fead Gerrit-Change-Number: 21441 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Sep 2017 15:14:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Select right gmbus port for VGA output
by Arthur Heymans (Code Review) 07 Sep '17

07 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21441 Change subject: mb/intel/dg43gt: Select right gmbus port for VGA output ...................................................................... mb/intel/dg43gt: Select right gmbus port for VGA output TESTED: NGI works on VGA with adapter on DVI-I port Change-Id: I4bd9d451295d26a3e11ded9863f5d45d42c8fead Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/dg43gt/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/21441/1 diff --git a/src/mainboard/intel/dg43gt/Kconfig b/src/mainboard/intel/dg43gt/Kconfig index b299f42..de5448f 100644 --- a/src/mainboard/intel/dg43gt/Kconfig +++ b/src/mainboard/intel/dg43gt/Kconfig @@ -32,6 +32,7 @@ select HAVE_ACPI_RESUME select INTEL_EDID select MAINBOARD_HAS_NATIVE_VGA_INIT + select GFX_GMA_ANALOG_I2C_HDMI_C select DRIVERS_I2C_CK505 config VGA_BIOS_ID -- To view, visit https://review.coreboot.org/21441 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4bd9d451295d26a3e11ded9863f5d45d42c8fead Gerrit-Change-Number: 21441 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/intel/dg43gt: Configure clockgen
by Arthur Heymans (Code Review) 07 Sep '17

07 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21440 Change subject: mb/intel/dg43gt: Configure clockgen ...................................................................... mb/intel/dg43gt: Configure clockgen This makes the VGA output on the DVI-I connector usable. This reuses vendor settings. Change-Id: Ib8b6bf33816f7e468a09ff5e2008c2cb9f7c0a8b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/dg43gt/Kconfig M src/mainboard/intel/dg43gt/devicetree.cb 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/21440/1 diff --git a/src/mainboard/intel/dg43gt/Kconfig b/src/mainboard/intel/dg43gt/Kconfig index d55f82d..b299f42 100644 --- a/src/mainboard/intel/dg43gt/Kconfig +++ b/src/mainboard/intel/dg43gt/Kconfig @@ -32,6 +32,7 @@ select HAVE_ACPI_RESUME select INTEL_EDID select MAINBOARD_HAS_NATIVE_VGA_INIT + select DRIVERS_I2C_CK505 config VGA_BIOS_ID string diff --git a/src/mainboard/intel/dg43gt/devicetree.cb b/src/mainboard/intel/dg43gt/devicetree.cb index 6421673..79a8eb7 100644 --- a/src/mainboard/intel/dg43gt/devicetree.cb +++ b/src/mainboard/intel/dg43gt/devicetree.cb @@ -101,7 +101,19 @@ end device pci 1f.1 on end # PATA/IDE device pci 1f.2 on end # SATA - device pci 1f.3 on end # SMbus + device pci 1f.3 on # SMbus + chip drivers/i2c/ck505 # SLG8XP549T + register "mask" = "{ 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff, 0xff, 0xff, + 0xff, 0xff }" + register "regs" = "{ 0x11, 0xd9, 0xff, + 0xfd, 0xff, 0x00, 0x00, + 0x06, 0x10, 0x05, 0x01, + 0x80, 0x0d }" + device i2c 69 on end + end + end device pci 1f.4 off end device pci 1f.5 on end # IDE device pci 1f.6 off end -- To view, visit https://review.coreboot.org/21440 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8b6bf33816f7e468a09ff5e2008c2cb9f7c0a8b Gerrit-Change-Number: 21440 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: sb/intel/i82801jx: Add smbus block operations
by Arthur Heymans (Code Review) 07 Sep '17

07 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21439 Change subject: sb/intel/i82801jx: Add smbus block operations ...................................................................... sb/intel/i82801jx: Add smbus block operations Change-Id: I1a84b4451efe25c1c3b0ce33ddbcb6ed06c29f9e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/southbridge/intel/i82801jx/smbus.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/21439/1 diff --git a/src/southbridge/intel/i82801jx/smbus.c b/src/southbridge/intel/i82801jx/smbus.c index bc735a3..9ccff41 100644 --- a/src/southbridge/intel/i82801jx/smbus.c +++ b/src/southbridge/intel/i82801jx/smbus.c @@ -61,9 +61,35 @@ return do_smbus_write_byte(res->base, device, address, val); } +static int lsmbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buf) +{ + u16 device; + struct resource *res; + struct bus *pbus; + + device = dev->path.i2c.device; + pbus = get_pbus_smbus(dev); + res = find_resource(pbus->dev, 0x20); + return do_smbus_block_write(res->base, device, cmd, bytes, buf); +} + +static int lsmbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buf) +{ + u16 device; + struct resource *res; + struct bus *pbus; + + device = dev->path.i2c.device; + pbus = get_pbus_smbus(dev); + res = find_resource(pbus->dev, 0x20); + return do_smbus_block_read(res->base, device, cmd, bytes, buf); +} + static struct smbus_bus_operations lops_smbus_bus = { .read_byte = lsmbus_read_byte, .write_byte = lsmbus_write_byte, + .block_read = lsmbus_block_read, + .block_write = lsmbus_block_write, }; static void smbus_set_subsystem(device_t dev, unsigned vendor, unsigned device) -- To view, visit https://review.coreboot.org/21439 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1a84b4451efe25c1c3b0ce33ddbcb6ed06c29f9e Gerrit-Change-Number: 21439 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: add util/iotool: a simple tool to do inb/outb calls
by Alexander Couzens (Code Review) 07 Sep '17

07 Sep '17

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/21438 ) Change subject: add util/iotool: a simple tool to do inb/outb calls ...................................................................... Patch Set 1: maybe better use https://github.com/adurbin/iotools -- To view, visit https://review.coreboot.org/21438 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bc8501a355b76a47df7619c4cae22f76c8f5927 Gerrit-Change-Number: 21438 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Sep 2017 14:29:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: add util/iotool: a simple tool to do inb/outb calls
by Felix Held (Code Review) 07 Sep '17

07 Sep '17

Felix Held has posted comments on this change. ( https://review.coreboot.org/21438 ) Change subject: add util/iotool: a simple tool to do inb/outb calls ...................................................................... Patch Set 1: > Or should we start a more generic tools to manipulate different > things? like msr, gpio, iotool A tool for that already exists: https://github.com/adurbin/iotools -- To view, visit https://review.coreboot.org/21438 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bc8501a355b76a47df7619c4cae22f76c8f5927 Gerrit-Change-Number: 21438 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Sep 2017 14:28:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions
by build bot (Jenkins) (Code Review) 07 Sep '17

07 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18305 ) Change subject: nb/i945/raminit: Use common ddr2 decode functions ...................................................................... Patch Set 51: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15261/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60014/ : SUCCESS -- To view, visit https://review.coreboot.org/18305 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3 Gerrit-Change-Number: 18305 Gerrit-PatchSet: 51 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Thu, 07 Sep 2017 14:26:56 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017