coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: soc/intel/skylake: Fix SPI WP disable status check
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21449 ) Change subject: soc/intel/skylake: Fix SPI WP disable status check ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15475/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60249/ : SUCCESS -- To view, visit https://review.coreboot.org/21449 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie79fb4e3e92a4ae777c5d501abbb44a732a9862a Gerrit-Change-Number: 21449 Gerrit-PatchSet: 3 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 21:23:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add serialio device config
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21411 ) Change subject: soc/intel/cannonlake: Add serialio device config ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15476/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60250/ : SUCCESS -- To view, visit https://review.coreboot.org/21411 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7009120d69646cf60cb5a622e438ae1eeb6498cf Gerrit-Change-Number: 21411 Gerrit-PatchSet: 11 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 21:12:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Add config to enable EC EFS support
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21489 ) Change subject: vboot: Add config to enable EC EFS support ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60248/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15474/ : SUCCESS -- To view, visit https://review.coreboot.org/21489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 21:05:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add common ACPI support for CNL
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21076 ) Change subject: soc/intel/cannonlake: Add common ACPI support for CNL ...................................................................... Patch Set 34: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15471/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60245/ : SUCCESS -- To view, visit https://review.coreboot.org/21076 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc16d2afdd3cb9bad2ecb85cf320c88504409707 Gerrit-Change-Number: 21076 Gerrit-PatchSet: 34 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 20:55:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add serialio device config
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21411 ) Change subject: soc/intel/cannonlake: Add serialio device config ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60247/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/15473/ : SUCCESS -- To view, visit https://review.coreboot.org/21411 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7009120d69646cf60cb5a622e438ae1eeb6498cf Gerrit-Change-Number: 21411 Gerrit-PatchSet: 10 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 20:53:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Add config to enable EC EFS support
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21489 ) Change subject: vboot: Add config to enable EC EFS support ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60246/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15472/ : SUCCESS -- To view, visit https://review.coreboot.org/21489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 20:53:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Add config to enable EC EFS support
by Daisuke Nojiri (Code Review) 11 Sep '17

11 Sep '17

Hello Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21489 to look at the new patch set (#2). Change subject: vboot: Add config to enable EC EFS support ...................................................................... vboot: Add config to enable EC EFS support This patch makes coreboot set VBSD_EC_EFS flag if CONFIG_VBOOT_EC_EFS is set. Depthcharge/Vboot uses this flag to determine whether it can update EC when it's already running a RW copy. BUG=b:65028930 BRANCH=none TEST=Verify soft sync runs successfully on Fizz. Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M payloads/external/depthcharge/Makefile M src/vboot/Kconfig M src/vboot/vboot_handoff.c 3 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/21489/2 -- To view, visit https://review.coreboot.org/21489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: vboot: Add config to enable EC EFS support
by Daisuke Nojiri (Code Review) 11 Sep '17

11 Sep '17

Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/21489 Change subject: vboot: Add config to enable EC EFS support ...................................................................... vboot: Add config to enable EC EFS support This patch makes coreboot set VBSD_EC_EFS flag if CONFIG_VBOOT_EC_EFS is set. Depthcharge/Vboot uses this flag to determine whether it can update EC when it's already running a RW copy. BUG=b:65028930 BRANCH=none CQ-DEPEND=CL:616346 TEST=Verify soft sync runs successfully on Fizz. Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/vboot/Kconfig M src/vboot/vboot_handoff.c 2 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/21489/1 diff --git a/src/vboot/Kconfig b/src/vboot/Kconfig index 8c8dffe..14490d6 100644 --- a/src/vboot/Kconfig +++ b/src/vboot/Kconfig @@ -167,6 +167,15 @@ Whether the EC (or PD) is slow to update and needs to display a screen that informs the user the update is happening. +config VBOOT_EC_EFS + bool "Run software sync for EFS EC" + default n + depends on VBOOT_EC_SOFTWARE_SYNC + help + CrosEC can support EFS: Early Firmware Selection. If it's enabled, + software sync need to also support it. This switch enables EFS + support for software sync. + config VBOOT_PHYSICAL_DEV_SWITCH bool default n diff --git a/src/vboot/vboot_handoff.c b/src/vboot/vboot_handoff.c index 64c8ca6..974fe78 100644 --- a/src/vboot/vboot_handoff.c +++ b/src/vboot/vboot_handoff.c @@ -83,12 +83,15 @@ /* TODO: Set these in depthcharge */ if (!IS_ENABLED(CONFIG_VBOOT_PHYSICAL_DEV_SWITCH)) vb_sd->flags |= VBSD_HONOR_VIRT_DEV_SWITCH; - if (IS_ENABLED(CONFIG_VBOOT_EC_SOFTWARE_SYNC)) + if (IS_ENABLED(CONFIG_VBOOT_EC_SOFTWARE_SYNC)) { vb_sd->flags |= VBSD_EC_SOFTWARE_SYNC; + if (IS_ENABLED(CONFIG_VBOOT_EC_SLOW_UPDATE)) + vb_sd->flags |= VBSD_EC_SLOW_UPDATE; + if (IS_ENABLED(CONFIG_VBOOT_EC_EFS)) + vb_sd->flags |= VBSD_EC_EFS; + } if (!IS_ENABLED(CONFIG_VBOOT_PHYSICAL_REC_SWITCH)) vb_sd->flags |= VBSD_BOOT_REC_SWITCH_VIRTUAL; - if (IS_ENABLED(CONFIG_VBOOT_EC_SLOW_UPDATE)) - vb_sd->flags |= VBSD_EC_SLOW_UPDATE; if (IS_ENABLED(CONFIG_VBOOT_OPROM_MATTERS)) { vb_sd->flags |= VBSD_OPROM_MATTERS; /* -- To view, visit https://review.coreboot.org/21489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 1 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>

1 0

Change in coreboot[master]: MAINTAINERS: Add Julius as LZ4 maintainer
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21488 ) Change subject: MAINTAINERS: Add Julius as LZ4 maintainer ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15470/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60244/ : SUCCESS -- To view, visit https://review.coreboot.org/21488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I249ce24f6630d66d451d993198cd267478e5743e Gerrit-Change-Number: 21488 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 20:32:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/zoombini: Add new board
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21273 ) Change subject: google/zoombini: Add new board ...................................................................... Patch Set 14: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60243/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15469/ : SUCCESS -- To view, visit https://review.coreboot.org/21273 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13ebaae403d08f1b2e6881eeba4dc1787c792b4e Gerrit-Change-Number: 21273 Gerrit-PatchSet: 14 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 18:30:06 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017