August 2017 - coreboot-gerrit - mail.coreboot.org

Change in libgfxinit[master]: WIP: start port for G45
by Arthur Heymans (Code Review) Aug. 30, 2017

Aug. 30, 2017

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21295 Change subject: WIP: start port for G45 ...................................................................... WIP: start port for G45 Adds GPU_Port types G45 Config file Reuse PHC_* types for gmbus access (TODO offsets need fixing) Adapt helper for G45 Change-Id: Ifc05a1516329a61772af84558e5bfceb4d4ca277 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.ads A configs/g45 4 files changed, 40 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/95/21295/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index e82b133..9402654 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -63,7 +63,7 @@ Use_PP_VDD_Override : constant Boolean := CPU <= Ivybridge; ----- PCH/FDI: --------- - Has_PCH : constant Boolean := CPU /= Broxton; + Has_PCH : constant Boolean := CPU /= Broxton and CPU /= G45; Has_PCH_DAC : constant Boolean := CPU in Ironlake .. Ivybridge or (CPU in Broadwell .. Haswell and CPU_Var = Normal); @@ -135,7 +135,11 @@ type Valid_Per_Port is array (Port_Type) of Boolean; type Valid_Per_GPU is array (CPU_Type) of Valid_Per_Port; Valid_Port_GPU : Valid_Per_GPU := - (Ironlake => + (G45 => + (Disabled => False, + Internal => Config.Internal_Display /= None, + others => True), + Ironlake => (Disabled => False, Internal => Config.Internal_Display = LVDS, others => True), @@ -226,6 +230,7 @@ Default_CDClk_Freq : constant Frequency_Type := (case CPU is + when G45 => 320_000_000, when Ironlake | Haswell | Broadwell => 450_000_000, @@ -236,6 +241,7 @@ Default_RawClk_Freq : constant Frequency_Type := (case CPU is + when G45 => 96_000_000, when Ironlake | Sandybridge | Ivybridge => 125_000_000, @@ -256,7 +262,7 @@ Maximum_Scalable_Width : constant Width_Per_Pipe := (case CPU is - when Ironlake..Haswell => + when G45..Haswell => (Primary => 4096, Secondary => 2048, Tertiary => 2048), @@ -274,17 +280,17 @@ ---------------------------------------------------------------------------- GTT_Offset : constant := (case CPU is - when Ironlake .. Haswell => 16#0020_0000#, + when G45 .. Haswell => 16#0020_0000#, when Broadwell .. Skylake => 16#0080_0000#); GTT_Size : constant := (case CPU is - when Ironlake .. Haswell => 16#0020_0000#, + when G45 .. Haswell => 16#0020_0000#, -- Limit Broadwell to 4MiB to have a stable -- interface (i.e. same number of entries): when Broadwell .. Skylake => 16#0040_0000#); GTT_PTE_Size : constant := (case CPU is - when Ironlake .. Haswell => 4, + when G45 .. Haswell => 4, when Broadwell .. Skylake => 8); end HW.GFX.GMA.Config; diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb index 0f60375..7fef8e6 100644 --- a/common/hw-gfx-gma-config_helpers.adb +++ b/common/hw-gfx-gma-config_helpers.adb @@ -30,22 +30,29 @@ begin return (case Config.CPU is + when G45 => + (case Port is + when Internal => LVDS, + when HDMI1 | DP1 => DIGI_B, + when HDMI2 | DP2 => DIGI_C, + when HDMI3 | DP3 => DIGI_D, + when Analog => VGA), when Ironlake .. Ivybridge => -- everything but eDP through FDI/PCH - (if Config.Internal_Is_EDP and then Port = Internal then + (if Config.Internal_Is_EDP and then Port = Internal then DIGI_A - else - (case Pipe is - -- FDIs are fixed to the CPU pipe - when Primary => DIGI_B, - when Secondary => DIGI_C, - when Tertiary => DIGI_D)), + else + (case Pipe is + -- FDIs are fixed to the CPU pipe + when Primary => DIGI_B, + when Secondary => DIGI_C, + when Tertiary => DIGI_D)), when Haswell .. Skylake => -- everything but VGA directly on CPU - (case Port is - when Internal => DIGI_A, -- LVDS not available - when HDMI1 | DP1 => DIGI_B, - when HDMI2 | DP2 => DIGI_C, - when HDMI3 | DP3 => DIGI_D, - when Analog => DIGI_E)); + (case Port is + when Internal => DIGI_A, -- LVDS not available + when HDMI1 | DP1 => DIGI_B, + when HDMI2 | DP2 => DIGI_C, + when HDMI3 | DP3 => DIGI_D, + when Analog => DIGI_E)); end To_GPU_Port; function To_PCH_Port (Port : Active_Port_Type) return PCH_Port diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index 3771804..42e0d4e 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -30,7 +30,8 @@ is type CPU_Type is - (Ironlake, + (G45, + Ironlake, Sandybridge, Ivybridge, Haswell, @@ -118,7 +119,7 @@ subtype Active_Port_Type is Port_Type range Port_Type'Succ (Disabled) .. Port_Type'Last; - type GPU_Port is (DIGI_A, DIGI_B, DIGI_C, DIGI_D, DIGI_E); + type GPU_Port is (DIGI_A, DIGI_B, DIGI_C, DIGI_D, DIGI_E, LVDS, VGA, TV); subtype Digital_Port is GPU_Port range DIGI_A .. DIGI_E; diff --git a/configs/g45 b/configs/g45 new file mode 100644 index 0000000..6b54563 --- /dev/null +++ b/configs/g45 @@ -0,0 +1,5 @@ +CONFIG_GFX_GMA_CPU = G45 +CONFIG_GFX_GMA_CPU_VARIANT = Normal +CONFIG_GFX_GMA_INTERNAL_PORT = LVDS +CONFIG_GFX_GMA_ANALOG_I2C_PORT = PCH_DAC +CONFIG_GFX_GMA_DEFAULT_MMIO = 16\#e000_0000\# -- To view, visit https://review.coreboot.org/21295 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc05a1516329a61772af84558e5bfceb4d4ca277 Gerrit-Change-Number: 21295 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/google/soraka: Camera PMIC run time power control
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20741 ) Change subject: mb/google/soraka: Camera PMIC run time power control ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14893/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59607/ : SUCCESS -- To view, visit https://review.coreboot.org/20741 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0 Gerrit-Change-Number: 20741 Gerrit-PatchSet: 11 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com> Gerrit-Comment-Date: Wed, 30 Aug 2017 21:16:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/lint/checkpatch: Reset the path if running in taint mode
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21293 ) Change subject: util/lint/checkpatch: Reset the path if running in taint mode ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14891/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59605/ : SUCCESS -- To view, visit https://review.coreboot.org/21293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a09915d13547bf9a86c011d44cbcd39c46f3fec Gerrit-Change-Number: 21293 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 20:12:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Common ACPI
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20630 ) Change subject: soc/intel/common/block: Common ACPI ...................................................................... Patch Set 24: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14890/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59604/ : SUCCESS -- To view, visit https://review.coreboot.org/20630 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6eb6fd5366e6e28fd81bc22d050b0efa05a2e5d Gerrit-Change-Number: 20630 Gerrit-PatchSet: 24 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 19:56:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/lint/checkpatch: Reset the path if running in taint mode
by Martin Roth (Code Review) Aug. 30, 2017

Aug. 30, 2017

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21293 Change subject: util/lint/checkpatch: Reset the path if running in taint mode ...................................................................... util/lint/checkpatch: Reset the path if running in taint mode Jenkins is giving warnings due to getting the path from the environment: Insecure $ENV{PATH} while running setgid at util/lint/checkpatch.pl line 907, <$conststructs> line 39. This should fix those warnings. Change-Id: I6a09915d13547bf9a86c011d44cbcd39c46f3fec Signed-off-by: Martin Roth <martinroth(a)google.com> --- M util/lint/checkpatch.pl 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/21293/1 diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 75f6f98..b9dc5f6 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -59,6 +59,13 @@ my $color = 1; my $allow_c99_comments = 1; +# For coreboot jenkins +# If taint mode is enabled, Untaint the path - files must be in /bin, /usr/bin or /usr/local/bin +if ( ${^TAINT} ) { + $ENV{'PATH'} = '/bin:/usr/bin:/usr/local/bin'; + delete @ENV{ 'IFS', 'CDPATH', 'ENV', 'BASH_ENV' }; +} + sub help { my ($exitcode) = @_; -- To view, visit https://review.coreboot.org/21293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6a09915d13547bf9a86c011d44cbcd39c46f3fec Gerrit-Change-Number: 21293 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: 3rdparty/lib{hwbase, gfxinit}: Update to latest master
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20606 ) Change subject: 3rdparty/lib{hwbase,gfxinit}: Update to latest master ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14889/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59603/ : SUCCESS -- To view, visit https://review.coreboot.org/20606 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001ba973d864811503410579fd7ad55ab8612759 Gerrit-Change-Number: 20606 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 18:33:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/zoombini: Add new board
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21273 ) Change subject: google/zoombini: Add new board ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14888/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59602/ : SUCCESS -- To view, visit https://review.coreboot.org/21273 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13ebaae403d08f1b2e6881eeba4dc1787c792b4e Gerrit-Change-Number: 21273 Gerrit-PatchSet: 8 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 18:10:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add Vboot/ChromOS support
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21280 ) Change subject: soc/intel/cannonlake: Add Vboot/ChromOS support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14887/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59598/ : SUCCESS -- To view, visit https://review.coreboot.org/21280 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I114a9d6e92b69199ccacc1e7e1535eccc0e2cb99 Gerrit-Change-Number: 21280 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 17:54:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/zoombini: Add new board
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21273 ) Change subject: google/zoombini: Add new board ...................................................................... Patch Set 7: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59600/ : FAILURE -- To view, visit https://review.coreboot.org/21273 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13ebaae403d08f1b2e6881eeba4dc1787c792b4e Gerrit-Change-Number: 21273 Gerrit-PatchSet: 7 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 17:40:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpigen: Add stop gpio control to power resource
by build bot (Jenkins) (Code Review) Aug. 30, 2017

Aug. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21249 ) Change subject: acpigen: Add stop gpio control to power resource ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14885/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59596/ : SUCCESS -- To view, visit https://review.coreboot.org/21249 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae5ec7eb3972c5c7f80956d60d0d3c321bbefb0f Gerrit-Change-Number: 21249 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 30 Aug 2017 16:34:29 +0000 Gerrit-HasComments: No

1 0