August 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: util/lint/checkpatch: Untaint variables from env & command line
by Martin Roth (Code Review) Aug. 31, 2017

Aug. 31, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21293 to look at the new patch set (#2). Change subject: util/lint/checkpatch: Untaint variables from env & command line ...................................................................... util/lint/checkpatch: Untaint variables from env & command line Jenkins is giving warnings due tainted variables from the environment and command line: Insecure $ENV{PATH} while running setgid at util/lint/checkpatch.pl line 907, <$conststructs> line 39. Insecure dependency in piped open while running setgid at util/lint/checkpatch.pl line 907, <$conststructs> line 39. This should fix those warnings. Change-Id: I6a09915d13547bf9a86c011d44cbcd39c46f3fec Signed-off-by: Martin Roth <martinroth(a)google.com> --- M util/lint/checkpatch.pl 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/21293/2 -- To view, visit https://review.coreboot.org/21293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a09915d13547bf9a86c011d44cbcd39c46f3fec Gerrit-Change-Number: 21293 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/sapphire/pureplatinumh61: Disable the SuperIO serial
by build bot (Jenkins) (Code Review) Aug. 31, 2017

Aug. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21226 ) Change subject: mb/sapphire/pureplatinumh61: Disable the SuperIO serial ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14921/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59641/ : SUCCESS -- To view, visit https://review.coreboot.org/21226 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2c93c51e8ddb8b510f0d7f7e3072befeba5d95 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 3 Gerrit-Owner: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Aug 2017 14:06:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add the revision 1 variant
by build bot (Jenkins) (Code Review) Aug. 31, 2017

Aug. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 ) Change subject: mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14920/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59640/ : SUCCESS -- To view, visit https://review.coreboot.org/21292 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Aug 2017 13:41:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add the revision 1 variant
by Arthur Heymans (Code Review) Aug. 31, 2017

Aug. 31, 2017

Hello build bot (Jenkins), Bill XIE, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21292 to look at the new patch set (#4). Change subject: mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... mb/asrock/g41c-gs: Add the revision 1 variant Both g41c-gs and g41c-s can be supported by the same code since the only difference is ethernet NIC. TESTED, does not yet resume from S3. Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/Kconfig M src/mainboard/asrock/g41c-gs/Kconfig.name M src/mainboard/asrock/g41c-gs/gpio.c M src/mainboard/asrock/g41c-gs/romstage.c A src/mainboard/asrock/g41c-gs/variants/g41c-gs-r2/devicetree.cb A src/mainboard/asrock/g41c-gs/variants/g41c-gs/devicetree.cb 6 files changed, 323 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21292/4 -- To view, visit https://review.coreboot.org/21292 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add the revision 1 variant
by build bot (Jenkins) (Code Review) Aug. 31, 2017

Aug. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 ) Change subject: mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59639/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14919/ : SUCCESS -- To view, visit https://review.coreboot.org/21292 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Aug 2017 13:31:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Add the revision 1 variant
by Arthur Heymans (Code Review) Aug. 31, 2017

Aug. 31, 2017

Hello build bot (Jenkins), Bill XIE, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21292 to look at the new patch set (#3). Change subject: mb/asrock/g41c-gs: Add the revision 1 variant ...................................................................... mb/asrock/g41c-gs: Add the revision 1 variant Both g41c-gs and g41c-s can be supported by the same code since the only difference is ethernet NIC. TESTED, does not yet resume from S3. Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/asrock/g41c-gs/Kconfig M src/mainboard/asrock/g41c-gs/Kconfig.name M src/mainboard/asrock/g41c-gs/gpio.c M src/mainboard/asrock/g41c-gs/romstage.c A src/mainboard/asrock/g41c-gs/variants/g41c-gs-r2/devicetree.cb A src/mainboard/asrock/g41c-gs/variants/g41c-gs/devicetree.cb 6 files changed, 323 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21292/3 -- To view, visit https://review.coreboot.org/21292 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: 3rdparty/vboot: update to latest master
by build bot (Jenkins) (Code Review) Aug. 31, 2017

Aug. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21302 ) Change subject: 3rdparty/vboot: update to latest master ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14918/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59638/ : SUCCESS -- To view, visit https://review.coreboot.org/21302 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I823bad862805cdec1dfecc8ba046f73ac206d3e8 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Aug 2017 12:45:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: 3rdparty/vboot: update to latest master
by Patrick Georgi (Code Review) Aug. 31, 2017

Aug. 31, 2017

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21302 Change subject: 3rdparty/vboot: update to latest master ...................................................................... 3rdparty/vboot: update to latest master Besides some internal changes that won't have much effect on coreboot, the newer version also supports building host tools on systems that self-designate as i686. Change-Id: I823bad862805cdec1dfecc8ba046f73ac206d3e8 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/21302/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 8c4b828..96a0ead 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 8c4b828502d8c6c7112286720dddfd30c92a968e +Subproject commit 96a0ead803c22fb5e55effb9d3a571a4c88f29db -- To view, visit https://review.coreboot.org/21302 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I823bad862805cdec1dfecc8ba046f73ac206d3e8 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) Aug. 31, 2017

Aug. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14917/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59637/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 9 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Aug 2017 09:41:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) Aug. 31, 2017

Aug. 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14916/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59636/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 Aug 2017 09:31:24 +0000 Gerrit-HasComments: No

1 0