coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: ec/google: update ec_commands.h
by build bot (Jenkins) (Code Review) 10 Aug '17

10 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20945 ) Change subject: ec/google: update ec_commands.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58399/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13808/ : SUCCESS -- To view, visit https://review.coreboot.org/20945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I513123547f3854945e827d2f7f6c0df6591886eb Gerrit-Change-Number: 20945 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 10 Aug 2017 17:39:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Documentation: Update Lesson2.md
by Evelyn Huang (Code Review) 10 Aug '17

10 Aug '17

Evelyn Huang has uploaded this change for review. ( https://review.coreboot.org/20948 Change subject: Documentation: Update Lesson2.md ...................................................................... Documentation: Update Lesson2.md Update Lesson2.md to include information about updating a commit after it has been pushed to the remote repository. Change-Id: Iebf86113b13d859d9c9e3db51e22ea44cb1144f6 Signed-off-by: Evelyn Huang <evhuang(a)google.com> --- M Documentation/Lesson2.md 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/20948/1 diff --git a/Documentation/Lesson2.md b/Documentation/Lesson2.md index 55d8188..ee865c7 100644 --- a/Documentation/Lesson2.md +++ b/Documentation/Lesson2.md @@ -251,4 +251,31 @@ on https://github.com/magicmonty/bash-git-prompt. Listed in that section are various lines that you can copy, uncomment and add to your .bashrc file to change the configurations. Example configurations include avoid fetching remote -status, and supporting versions of Git older than 1.7.10. \ No newline at end of file +status, and supporting versions of Git older than 1.7.10. + +## Appendix: Miscellaneous Advice + +### Updating a commit after running git push: + +Suppose you would like to update a commit that has already pushed to the +remote repository. If the commit you wish to update is the most recent +commit you have made, after making your desired changes, stage the files +(either using git add or in git cola), and amend the commit. To do so, +if you are using the command line, run "git commit --amend." If you are +using git cola, click on the gear icon located on the upper left side under +**Commit** and select **Amend Last Commit** in the drop down menu. Then, stage +the files you have changed, commit the changes, and run git push to push the +changes to the remote repository. Your change should be reflected in Gerrit as +a new patch set. + +If, however, the commit you wish to update is not the most recent commit you +have made, you will first need to checkout that commit. To do so, find the +URL of the commit on <https://review.coreboot.org> and go to that page; if +the commit is one that you previously pushed, it can be found by selecting +**My** and then **Changes** in the upper left corner. To checkout this commit, +in the upper right corner, click on **Download**, and copy the command listed +next to checkout by clicking **Copy to clipboard**. Then, run the copied +command in your coreboot repository. Now, the last commit should be the most +recent commit to that patch; to update it, make your desired changes, stage +the files, then amend and push the commit using the instructions in the above +paragraph. -- To view, visit https://review.coreboot.org/20948 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iebf86113b13d859d9c9e3db51e22ea44cb1144f6 Gerrit-Change-Number: 20948 Gerrit-PatchSet: 1 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com>

1 0

Change in coreboot[master]: google/coral: Fetch SKU ID from EC
by Patrick Georgi (Code Review) 10 Aug '17

10 Aug '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20947 Change subject: google/coral: Fetch SKU ID from EC ...................................................................... google/coral: Fetch SKU ID from EC BUG=b:64468585 BRANCH=none TEST=with the other sku-id related patches applied, coreboot obtains the right SKU ID from EC Change-Id: I96a0e030bbc5f1c98165e70353340c413f8dc352 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/mainboard/google/reef/variants/coral/mainboard.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/20947/1 diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 54c24f8..3da5456 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -14,11 +14,13 @@ */ #include <stdint.h> +#include <ec/google/chromeec/ec.h> #include "baseboard/variants.h" uint8_t variant_board_sku(void) { - return 0; + // we know that the values are in 0..255 + return google_chromeec_get_sku_id(); } void variant_nhlt_oem_overrides(const char **oem_id, -- To view, visit https://review.coreboot.org/20947 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I96a0e030bbc5f1c98165e70353340c413f8dc352 Gerrit-Change-Number: 20947 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: ec/google: Add command to fetch SKU ID from EC
by Patrick Georgi (Code Review) 10 Aug '17

10 Aug '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20946 Change subject: ec/google: Add command to fetch SKU ID from EC ...................................................................... ec/google: Add command to fetch SKU ID from EC BUG=b:64468585 BRANCH=none TEST=with the other sku-id related patches applied, coreboot obtains the right SKU ID from EC Change-Id: I82e324407b4b96495a3eb3d4caf110f9eae05116 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/20946/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 2efc66a..3c17f8f 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -386,6 +386,24 @@ return board_v.board_version; } +u32 google_chromeec_get_sku_id(void) +{ + struct chromeec_command cmd; + struct ec_response_sku_id board_v; + + cmd.cmd_code = EC_CMD_GET_SKU_ID; + cmd.cmd_version = 0; + cmd.cmd_size_in = 0; + cmd.cmd_size_out = sizeof(board_v); + cmd.cmd_data_out = &board_v; + cmd.cmd_dev_index = 0; + + if (google_chromeec_command(&cmd) != 0) + return 0; + + return board_v.sku_id; +} + int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len) { struct chromeec_command cec_cmd; diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index b2b63e8..60d5a32 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -49,6 +49,7 @@ int google_chromeec_check_feature(int feature); uint8_t google_chromeec_calc_checksum(const uint8_t *data, int size); u16 google_chromeec_get_board_version(void); +u32 google_chromeec_get_sku_id(void); u32 google_chromeec_get_events_b(void); int google_chromeec_clear_events_b(u32 mask); int google_chromeec_kbbacklight(int percent); -- To view, visit https://review.coreboot.org/20946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82e324407b4b96495a3eb3d4caf110f9eae05116 Gerrit-Change-Number: 20946 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: ec/google: update ec_commands.h
by Patrick Georgi (Code Review) 10 Aug '17

10 Aug '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20945 Change subject: ec/google: update ec_commands.h ...................................................................... ec/google: update ec_commands.h Copy from chrome-ec codebase, except for keeping the long-form license header. BUG=b:64468585 BRANCH=none TEST=with the other sku-id related patches applied, coreboot obtains the right SKU ID from EC Change-Id: I513123547f3854945e827d2f7f6c0df6591886eb Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 30 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/20945/1 diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 3e093f6..25ef584 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -31,7 +31,7 @@ #ifndef __CROS_EC_EC_COMMANDS_H #define __CROS_EC_EC_COMMANDS_H -#ifndef __ACPI__ +#if !defined(__ACPI__) && !defined(__KERNEL__) #include <stdint.h> #endif @@ -1121,6 +1121,14 @@ }; /*****************************************************************************/ +/* Get the board's SKU ID from EC */ +#define EC_CMD_GET_SKU_ID 0x000E + +struct __ec_align4 ec_response_sku_id { + uint32_t sku_id; +}; + +/*****************************************************************************/ /* Flash commands */ /* Get flash info */ @@ -1151,6 +1159,13 @@ /* Flags for version 1+ flash info command */ /* EC flash erases bits to 0 instead of 1 */ #define EC_FLASH_INFO_ERASE_TO_0 (1 << 0) + +/* Flash must be selected for read/write/erase operations to succeed. This may + * be necessary on a chip where write/erase can be corrupted by other board + * activity, or where the chip needs to enable some sort of programming voltage, + * or where the read/write/erase operations require cleanly suspending other + * chip functionality. */ +#define EC_FLASH_INFO_SELECT_REQUIRED (1 << 1) /* * Version 1 returns the same initial fields as version 0, with additional @@ -1421,6 +1436,16 @@ /* Status registers from command 0x05 and 0x35 */ uint8_t sr1, sr2; }; + + +/* Select flash during flash operations */ +#define EC_CMD_FLASH_SELECT 0x0019 + +struct __ec_align4 ec_params_flash_select { + /* 1 to select flash, 0 to deselect flash */ + uint8_t select; +}; + /*****************************************************************************/ /* PWM commands */ @@ -2980,6 +3005,7 @@ #define EC_MKBP_POWER_BUTTON 0 #define EC_MKBP_VOL_UP 1 #define EC_MKBP_VOL_DOWN 2 +#define EC_MKBP_RECOVERY 3 /* Switches */ #define EC_MKBP_LID_OPEN 0 @@ -3935,6 +3961,9 @@ #define EC_CMD_USB_PD_PORTS 0x0102 +/* Maximum number of PD ports on a device, num_ports will be <= this */ +#define EC_USB_PD_MAX_PORTS 8 + struct __ec_align1 ec_response_usb_pd_ports { uint8_t num_ports; }; -- To view, visit https://review.coreboot.org/20945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I513123547f3854945e827d2f7f6c0df6591886eb Gerrit-Change-Number: 20945 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: common/block/lpss: Add CLK read function into LPSS common
by build bot (Jenkins) (Code Review) 10 Aug '17

10 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20938 ) Change subject: common/block/lpss: Add CLK read function into LPSS common ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58397/ : SUCCESS -- To view, visit https://review.coreboot.org/20938 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I420919ad9154c4cf426bc232c5eb59d95fd698d2 Gerrit-Change-Number: 20938 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 10 Aug 2017 17:31:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/external/tianocore: Add and apply patches for tianocore
by build bot (Jenkins) (Code Review) 10 Aug '17

10 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20639 ) Change subject: payloads/external/tianocore: Add and apply patches for tianocore ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58395/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13806/ : SUCCESS -- To view, visit https://review.coreboot.org/20639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eaa602418995a68753b1ed13af8c6374eaa312f Gerrit-Change-Number: 20639 Gerrit-PatchSet: 10 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Prabal Saha <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 10 Aug 2017 17:15:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Common ACPI
by build bot (Jenkins) (Code Review) 10 Aug '17

10 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20630 ) Change subject: soc/intel/common/block: Common ACPI ...................................................................... Patch Set 14: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58396/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13807/ : SUCCESS -- To view, visit https://review.coreboot.org/20630 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6eb6fd5366e6e28fd81bc22d050b0efa05a2e5d Gerrit-Change-Number: 20630 Gerrit-PatchSet: 14 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 10 Aug 2017 17:15:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads/external/tianocore: Add and apply patches for tianocore
by build bot (Jenkins) (Code Review) 10 Aug '17

10 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20639 ) Change subject: payloads/external/tianocore: Add and apply patches for tianocore ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58394/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13805/ : SUCCESS -- To view, visit https://review.coreboot.org/20639 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eaa602418995a68753b1ed13af8c6374eaa312f Gerrit-Change-Number: 20639 Gerrit-PatchSet: 9 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Prabal Saha <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 10 Aug 2017 17:01:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload/libpci: Add a constant for PCI class memory other
by Nico Huber (Code Review) 10 Aug '17

10 Aug '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/20930 ) Change subject: libpayload/libpci: Add a constant for PCI class memory other ...................................................................... libpayload/libpci: Add a constant for PCI class memory other Change-Id: I71e902c4ec843608c1518fe1e8b90fbcf98a13d1 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/20930 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M payloads/libpayload/include/pci/pci.h 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/payloads/libpayload/include/pci/pci.h b/payloads/libpayload/include/pci/pci.h index 6ce4dde..ee79d45 100644 --- a/payloads/libpayload/include/pci/pci.h +++ b/payloads/libpayload/include/pci/pci.h @@ -67,6 +67,8 @@ #define PCI_ROM_ADDRESS1 0x38 // on bridges #define PCI_ROM_ADDRESS_MASK ~0x7ff +#define PCI_CLASS_MEMORY_OTHER 0x0580 + #define PCI_VENDOR_ID_INTEL 0x8086 struct pci_dev { -- To view, visit https://review.coreboot.org/20930 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I71e902c4ec843608c1518fe1e8b90fbcf98a13d1 Gerrit-Change-Number: 20930 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017