coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 2760p
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18241 ) Change subject: mainboard/hp: Add HP Elitebook 2760p ...................................................................... Patch Set 36: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58563/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13957/ : SUCCESS -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 36 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Aug 2017 07:29:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8470p
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18985 ) Change subject: mainboard/hp: Add HP Elitebook 8470p ...................................................................... Patch Set 20: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58562/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13956/ : SUCCESS -- To view, visit https://review.coreboot.org/18985 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc051e2272b8ea73627940db15a56901d737472 Gerrit-Change-Number: 18985 Gerrit-PatchSet: 20 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Aug 2017 07:23:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8460p
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20501 ) Change subject: mainboard/hp: Add HP Elitebook 8460p ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58564/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13958/ : SUCCESS -- To view, visit https://review.coreboot.org/20501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 Gerrit-Change-Number: 20501 Gerrit-PatchSet: 11 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Aug 2017 07:21:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 2570p
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20489 ) Change subject: mainboard/hp: Add HP Elitebook 2570p ...................................................................... Patch Set 14: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58561/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13955/ : SUCCESS -- To view, visit https://review.coreboot.org/20489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f3cd124fc676d49add59e9f0a07f70a6bb0fff0 Gerrit-Change-Number: 20489 Gerrit-PatchSet: 14 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Aug 2017 07:10:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: kbc1126_ec_dump: fix signed integer error
by Iru Cai (Code Review) 15 Aug '17

15 Aug '17

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/21013 Change subject: kbc1126_ec_dump: fix signed integer error ...................................................................... kbc1126_ec_dump: fix signed integer error The error is found when using kbc1126_ec_dump on coreboot.rom which uses different EC firmware offsets from vendor firmware. Change-Id: Iacc4ea50515ea219bc1868dae0446d576e8dce0c Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M util/kbc1126/kbc1126_ec_dump.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/21013/1 diff --git a/util/kbc1126/kbc1126_ec_dump.c b/util/kbc1126/kbc1126_ec_dump.c index 7470012..cfa4b64 100644 --- a/util/kbc1126/kbc1126_ec_dump.c +++ b/util/kbc1126/kbc1126_ec_dump.c @@ -111,8 +111,8 @@ assert(offs[1] + offs[3] == '\xff'); assert(offs[4] + offs[6] == '\xff'); assert(offs[5] + offs[7] == '\xff'); - long offw1 = (offs[0] << 16) | (offs[1] << 8); - long offw2 = (offs[4] << 16) | (offs[5] << 8); + long offw1 = ((offs[0] << 16) & 0xff0000) | ((offs[1] << 8) & 0xff00); + long offw2 = ((offs[4] << 16) & 0xff0000) | ((offs[5] << 8) & 0xff00); dump_fw(fw1, fp, offw1); dump_fw(fw2, fp, offw2); -- To view, visit https://review.coreboot.org/21013 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iacc4ea50515ea219bc1868dae0446d576e8dce0c Gerrit-Change-Number: 21013 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8460p
by Iru Cai (Code Review) 15 Aug '17

15 Aug '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20501 to look at the new patch set (#11). Change subject: mainboard/hp: Add HP Elitebook 8460p ...................................................................... mainboard/hp: Add HP Elitebook 8460p The code is based on autoport. I'm using a machine with discrete GPU, and gfx.* in devicetree.cb is from 2760p. It can be debug with serial port on dock. Tested: - CPU and memory: i5-2540M, 4G+0 - Arch Linux (Linux 4.11.7, SeaBIOS payload, with ATOM BIOS extracted from vendor UEFI firmware) - USB ports - SD card reader - WLAN - DP display - S3 Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- A src/mainboard/hp/8460p/Kconfig A src/mainboard/hp/8460p/Kconfig.name A src/mainboard/hp/8460p/Makefile.inc A src/mainboard/hp/8460p/acpi/ec.asl A src/mainboard/hp/8460p/acpi/platform.asl A src/mainboard/hp/8460p/acpi/superio.asl A src/mainboard/hp/8460p/acpi_tables.c A src/mainboard/hp/8460p/board_info.txt A src/mainboard/hp/8460p/devicetree.cb A src/mainboard/hp/8460p/dsdt.asl A src/mainboard/hp/8460p/gma-mainboard.ads A src/mainboard/hp/8460p/gpio.c A src/mainboard/hp/8460p/hda_verb.c A src/mainboard/hp/8460p/mainboard.c A src/mainboard/hp/8460p/romstage.c 15 files changed, 842 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/20501/11 -- To view, visit https://review.coreboot.org/20501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 Gerrit-Change-Number: 20501 Gerrit-PatchSet: 11 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: toolchain build process: surround *.log with apostrophes when build f...
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21012 ) Change subject: toolchain build process: surround *.log with apostrophes when build fails ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-toolchain/350/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/58560/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13954/ : SUCCESS -- To view, visit https://review.coreboot.org/21012 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f214b71629eda5fc54e5671ce63e58948343656 Gerrit-Change-Number: 21012 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 15 Aug 2017 00:45:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: toolchain build process: surround *.log with apostrophes when build f...
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21012 ) Change subject: toolchain build process: surround *.log with apostrophes when build fails ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-toolchain/349/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/58558/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13953/ : SUCCESS -- To view, visit https://review.coreboot.org/21012 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f214b71629eda5fc54e5671ce63e58948343656 Gerrit-Change-Number: 21012 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 14 Aug 2017 23:26:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: toolchain build process: surround *.log with apostrophes when build f...
by Idwer Vollering (Code Review) 15 Aug '17

15 Aug '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21012 to look at the new patch set (#3). Change subject: toolchain build process: surround *.log with apostrophes when build fails ...................................................................... toolchain build process: surround *.log with apostrophes when build fails Apparently the script's output text is unclear. Emphasize the file name, keeping the dot to close the sentence. Change-Id: I1f214b71629eda5fc54e5671ce63e58948343656 Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/21012/3 -- To view, visit https://review.coreboot.org/21012 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1f214b71629eda5fc54e5671ce63e58948343656 Gerrit-Change-Number: 21012 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: toolchain build process: surround *.log with apostrophes when build f...
by build bot (Jenkins) (Code Review) 15 Aug '17

15 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21012 ) Change subject: toolchain build process: surround *.log with apostrophes when build fails ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58559/ : SUCCESS -- To view, visit https://review.coreboot.org/21012 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f214b71629eda5fc54e5671ce63e58948343656 Gerrit-Change-Number: 21012 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 14 Aug 2017 23:26:38 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017