coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: mb/lenovo/t430s: Enable libgfxinit
by Arthur Heymans (Code Review) 17 Aug '17

17 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21070 ) Change subject: mb/lenovo/t430s: Enable libgfxinit ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/21070/1/src/mainboard/lenovo/t430s/gma-main… File src/mainboard/lenovo/t430s/gma-mainboard.ads: https://review.coreboot.org/#/c/21070/1/src/mainboard/lenovo/t430s/gma-main… PS1, Line 1: with HW.GFX.GMA; licence header. -- To view, visit https://review.coreboot.org/21070 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb1471ecb18927c30c61c64011cbb0e20a465558 Gerrit-Change-Number: 21070 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Aug 2017 13:18:29 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3v: add libgfxinit support
by Arthur Heymans (Code Review) 17 Aug '17

17 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21071 ) Change subject: mb/gigabyte/ga-b75m-d3v: add libgfxinit support ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/21071/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21071/1//COMMIT_MSG@10 PS1, Line 10: both text mode and : fb mode. line wrapping is a bit weird. https://review.coreboot.org/#/c/21071/1/src/mainboard/gigabyte/ga-b75m-d3v/… File src/mainboard/gigabyte/ga-b75m-d3v/gma-mainboard.ads: https://review.coreboot.org/#/c/21071/1/src/mainboard/gigabyte/ga-b75m-d3v/… PS1, Line 1: with HW.GFX.GMA; Licence header. -- To view, visit https://review.coreboot.org/21071 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1513fc57b79eebc5d047c2e24585731c44bc215 Gerrit-Change-Number: 21071 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Aug 2017 13:17:47 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3v: add libgfxinit support
by Bill XIE (Code Review) 17 Aug '17

17 Aug '17

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/21071 Change subject: mb/gigabyte/ga-b75m-d3v: add libgfxinit support ...................................................................... mb/gigabyte/ga-b75m-d3v: add libgfxinit support Currently native video init works on port HDMI1 (wired to the on-board DVI-D socket), both text mode and fb mode. VGA port is not tested, for current I have no vga monitor with valid edid available. Every ports works on GNU/Linux. Change-Id: Ib1513fc57b79eebc5d047c2e24585731c44bc215 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/mainboard/gigabyte/ga-b75m-d3v/Kconfig M src/mainboard/gigabyte/ga-b75m-d3v/Makefile.inc A src/mainboard/gigabyte/ga-b75m-d3v/gma-mainboard.ads 3 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/21071/1 diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig index 33b7ed7..b8694f5 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig @@ -4,7 +4,7 @@ def_bool y select ARCH_X86 select CPU_INTEL_SOCKET_LGA1155 - select NORTHBRIDGE_INTEL_SANDYBRIDGE + select NORTHBRIDGE_INTEL_IVYBRIDGE select USE_NATIVE_RAMINIT select SOUTHBRIDGE_INTEL_C216 select SUPERIO_ITE_IT8728F @@ -16,6 +16,7 @@ select HAVE_SMI_HANDLER select INTEL_INT15 select SERIRQ_CONTINUOUS_MODE + select MAINBOARD_HAS_LIBGFXINIT config DRAM_RESET_GATE_GPIO int diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Makefile.inc b/src/mainboard/gigabyte/ga-b75m-d3v/Makefile.inc index d57c9b5..63976c4 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/Makefile.inc +++ b/src/mainboard/gigabyte/ga-b75m-d3v/Makefile.inc @@ -14,3 +14,4 @@ ## romstage-y += gpio.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/gma-mainboard.ads b/src/mainboard/gigabyte/ga-b75m-d3v/gma-mainboard.ads new file mode 100644 index 0000000..60019d3 --- /dev/null +++ b/src/mainboard/gigabyte/ga-b75m-d3v/gma-mainboard.ads @@ -0,0 +1,14 @@ +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (HDMI1, + Analog, + others => Disabled); + +end GMA.Mainboard; -- To view, visit https://review.coreboot.org/21071 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1513fc57b79eebc5d047c2e24585731c44bc215 Gerrit-Change-Number: 21071 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com>

1 0

Change in coreboot[master]: mb/lenovo/t430s: Enable libgfxinit
by Bill XIE (Code Review) 17 Aug '17

17 Aug '17

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/21070 Change subject: mb/lenovo/t430s: Enable libgfxinit ...................................................................... mb/lenovo/t430s: Enable libgfxinit Tested on T430s with an external screen connected to every one of the DP ports (miniDP on mainboard, two DP ports on dock), the GRUB payload can display on both the external screen and the internal LVDS screen. This is a copy-paste of I8f270d558668c1fe41bcdcc7d6d2aa7f053c85b6. Change-Id: Ifb1471ecb18927c30c61c64011cbb0e20a465558 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t430s/Makefile.inc A src/mainboard/lenovo/t430s/gma-mainboard.ads 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/21070/1 diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index 51c39e6..f45fb0d 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -19,6 +19,8 @@ select SANDYBRIDGE_IVYBRIDGE_LVDS select ENABLE_VMX select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_LIBGFXINIT + select GFX_GMA_INTERNAL_IS_LVDS # Workaround for EC/KBC IRQ1. select SERIRQ_CONTINUOUS_MODE diff --git a/src/mainboard/lenovo/t430s/Makefile.inc b/src/mainboard/lenovo/t430s/Makefile.inc index 9eb141a..cb01f1c 100644 --- a/src/mainboard/lenovo/t430s/Makefile.inc +++ b/src/mainboard/lenovo/t430s/Makefile.inc @@ -15,3 +15,4 @@ smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c romstage-y += gpio.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/lenovo/t430s/gma-mainboard.ads b/src/mainboard/lenovo/t430s/gma-mainboard.ads new file mode 100644 index 0000000..736dce7 --- /dev/null +++ b/src/mainboard/lenovo/t430s/gma-mainboard.ads @@ -0,0 +1,20 @@ +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (DP1, + DP2, + DP3, + HDMI1, + HDMI2, + HDMI3, + Analog, + Internal, + others => Disabled); + +end GMA.Mainboard; -- To view, visit https://review.coreboot.org/21070 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb1471ecb18927c30c61c64011cbb0e20a465558 Gerrit-Change-Number: 21070 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Lock sideband access in coreboot and not in FSP
by build bot (Jenkins) (Code Review) 17 Aug '17

17 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20956 ) Change subject: soc/intel/skylake: Lock sideband access in coreboot and not in FSP ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58753/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14128/ : SUCCESS -- To view, visit https://review.coreboot.org/20956 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dba4c97480200507969b0f2873337f97bd2ff6a Gerrit-Change-Number: 20956 Gerrit-PatchSet: 7 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 17 Aug 2017 12:50:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Move SPI lock down config after PCI enumeration
by build bot (Jenkins) (Code Review) 17 Aug '17

17 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21064 ) Change subject: soc/intel/skylake: Move SPI lock down config after PCI enumeration ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58752/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14127/ : SUCCESS -- To view, visit https://review.coreboot.org/21064 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f5a952656e51d3bf365917b90d3056b46f899c5 Gerrit-Change-Number: 21064 Gerrit-PatchSet: 3 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 11:56:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/common/mrc_cache: Move update_mrc_cache after BS_DEV_RESOURCES
by build bot (Jenkins) (Code Review) 17 Aug '17

17 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21028 ) Change subject: intel/common/mrc_cache: Move update_mrc_cache after BS_DEV_RESOURCES ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58751/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14126/ : SUCCESS -- To view, visit https://review.coreboot.org/21028 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ee26b5cc70433438cf4e45e707b8a54f89cf9b0 Gerrit-Change-Number: 21028 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 17 Aug 2017 11:55:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: common/block/fast_spi: Add function to DLOCK PR registers
by build bot (Jenkins) (Code Review) 17 Aug '17

17 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21063 ) Change subject: common/block/fast_spi: Add function to DLOCK PR registers ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58750/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14125/ : SUCCESS -- To view, visit https://review.coreboot.org/21063 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46e1948315ea9489932efdf7d60d6d78ab3948a6 Gerrit-Change-Number: 21063 Gerrit-PatchSet: 3 Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 11:54:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Remove TCO lock down programming
by build bot (Jenkins) (Code Review) 17 Aug '17

17 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21031 ) Change subject: soc/intel/skylake: Remove TCO lock down programming ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58749/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14124/ : SUCCESS -- To view, visit https://review.coreboot.org/21031 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec9e3075df01862f8558b303a458126c68202bff Gerrit-Change-Number: 21031 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 17 Aug 2017 11:50:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Move LPC lock down config after PCI enumeration
by build bot (Jenkins) (Code Review) 17 Aug '17

17 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21000 ) Change subject: soc/intel/skylake: Move LPC lock down config after PCI enumeration ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58745/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14120/ : SUCCESS -- To view, visit https://review.coreboot.org/21000 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I705a3a3c6ddc72ae7895419442d67b82f541edee Gerrit-Change-Number: 21000 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Thu, 17 Aug 2017 11:47:49 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017