coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: drv/intel/gma/opregion: Add interface for GNVS ASLB handling
by Patrick Rudolph (Code Review) 30 Jun '17

30 Jun '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20435 to look at the new patch set (#2). Change subject: drv/intel/gma/opregion: Add interface for GNVS ASLB handling ...................................................................... drv/intel/gma/opregion: Add interface for GNVS ASLB handling Add new interface to set and get GNVS' ASLB register. To be used by Intel's gma driver to set ASLB at ACPI table creation and to get ASLB on S3 resume. Change-Id: If30c6b2270069783b0892774802f47406404da5f Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/intel/gma/opregion.h M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c 5 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/20435/2 -- To view, visit https://review.coreboot.org/20435 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If30c6b2270069783b0892774802f47406404da5f Gerrit-Change-Number: 20435 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drv/intel/gma/opregion: Add method to restore ASLS
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20436 ) Change subject: drv/intel/gma/opregion: Add method to restore ASLS ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/56467/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/12054/ : SUCCESS -- To view, visit https://review.coreboot.org/20436 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254683081cbaf3a5938794dcba140ac9ee07f48a Gerrit-Change-Number: 20436 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 13:37:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drv/intel/gma/opregion: Add interface for GNVS ASLB handling
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20435 ) Change subject: drv/intel/gma/opregion: Add interface for GNVS ASLB handling ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/56466/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/12053/ : SUCCESS -- To view, visit https://review.coreboot.org/20435 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If30c6b2270069783b0892774802f47406404da5f Gerrit-Change-Number: 20435 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 13:36:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/sandybridge/gma: Set ASLS on S3 resume
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20284 ) Change subject: nb/intel/sandybridge/gma: Set ASLS on S3 resume ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/56464/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/12051/ : SUCCESS -- To view, visit https://review.coreboot.org/20284 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7132cd1848a75043d10f32ac5d0e6b45d2e0fe4 Gerrit-Change-Number: 20284 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 13:33:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/common/gma_opregion: Use new method to update ASLS
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20283 ) Change subject: nb/intel/common/gma_opregion: Use new method to update ASLS ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56463/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12050/ : SUCCESS -- To view, visit https://review.coreboot.org/20283 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I872ff86a778497df76ad7f9b1b6910c4e7c5941f Gerrit-Change-Number: 20283 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 13:32:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drv/intel/gma/opregion: Add function to set ASLS register
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20281 ) Change subject: drv/intel/gma/opregion: Add function to set ASLS register ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56462/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12049/ : SUCCESS -- To view, visit https://review.coreboot.org/20281 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4850500ac6d58f80b0eddc81514053c87774405c Gerrit-Change-Number: 20281 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 13:32:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drv/intel/gma/opregion: Add method to restore ASLS
by Patrick Rudolph (Code Review) 30 Jun '17

30 Jun '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20436 Change subject: drv/intel/gma/opregion: Add method to restore ASLS ...................................................................... drv/intel/gma/opregion: Add method to restore ASLS Add a new method to restore ASLS on S3 resume. Use new interface introduced in last commit. Change-Id: I254683081cbaf3a5938794dcba140ac9ee07f48a Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/intel/gma/opregion.c M src/drivers/intel/gma/opregion.h 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/20436/1 diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 7871981..503f729 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -18,6 +18,8 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <console/console.h> +#include <cbmem.h> #include "opregion.h" /* Write ASLS PCI register and prepare SWSCI register. */ @@ -47,3 +49,17 @@ reg16 |= SMISCISEL; pci_write_config16(igd, SWSCI, reg16); } + +/* Restore ASLS register on S3 resume and prepare SWSCI. */ +void +intel_gma_restore_opregion(void) +{ + if (acpi_is_wakeup_s3()) { + const void *const gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS); + + if (gnvs && gma_get_gnvs_aslb(gnvs)) + intel_gma_opregion_register(gma_get_gnvs_aslb(gnvs)); + else + printk(BIOS_ERR, "Error: GNVS or ASLB not set.\n"); + } +} diff --git a/src/drivers/intel/gma/opregion.h b/src/drivers/intel/gma/opregion.h index ff64aec..3e9ffd3 100644 --- a/src/drivers/intel/gma/opregion.h +++ b/src/drivers/intel/gma/opregion.h @@ -246,6 +246,7 @@ } __attribute__((packed)) optionrom_vbt_t; void intel_gma_opregion_register(uintptr_t opregion); +void intel_gma_restore_opregion(void); uintptr_t gma_get_gnvs_aslb(const void *gnvs); void gma_set_gnvs_aslb(const void *gnvs, uintptr_t aslb); -- To view, visit https://review.coreboot.org/20436 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I254683081cbaf3a5938794dcba140ac9ee07f48a Gerrit-Change-Number: 20436 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: drv/intel/gma/opregion: Add interface for GNVS ASLB handling
by Patrick Rudolph (Code Review) 30 Jun '17

30 Jun '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20435 Change subject: drv/intel/gma/opregion: Add interface for GNVS ASLB handling ...................................................................... drv/intel/gma/opregion: Add interface for GNVS ASLB handling Add new interface to set and get GNVS' ASLB register. To be used by Intel's gma driver to set ASLB at ACPI table creation and to get ASLB on S3 resume. Change-Id: If30c6b2270069783b0892774802f47406404da5f Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/intel/gma/opregion.h M src/northbridge/intel/fsp_sandybridge/gma.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c 5 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/20435/1 diff --git a/src/drivers/intel/gma/opregion.h b/src/drivers/intel/gma/opregion.h index c590805..ff64aec 100644 --- a/src/drivers/intel/gma/opregion.h +++ b/src/drivers/intel/gma/opregion.h @@ -246,5 +246,7 @@ } __attribute__((packed)) optionrom_vbt_t; void intel_gma_opregion_register(uintptr_t opregion); +uintptr_t gma_get_gnvs_aslb(const void *gnvs); +void gma_set_gnvs_aslb(const void *gnvs, uintptr_t aslb); #endif /* _COMMON_GMA_H_ */ diff --git a/src/northbridge/intel/fsp_sandybridge/gma.c b/src/northbridge/intel/fsp_sandybridge/gma.c index 8e2d968..daff050 100644 --- a/src/northbridge/intel/fsp_sandybridge/gma.c +++ b/src/northbridge/intel/fsp_sandybridge/gma.c @@ -53,6 +53,19 @@ return new_vendev; } +uintptr_t gma_get_gnvs_aslb(const void *gnvs) +{ + const global_nvs_t gnvs_ptr = gnvs; + return gnvs_ptr ? (uintptr_t)gnvs_ptr->aslb : NULL; +} + +void gma_set_gnvs_aslb(const void *gnvs, uintptr_t aslb) +{ + const global_nvs_t gnvs_ptr = gnvs; + if (gnvs_ptr) + gnvs_ptr->aslb = (u32)aslb; +} + static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device) { if (!vendor || !device) { diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index f22ff48..709c46b 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -215,6 +215,19 @@ return 0; } +uintptr_t gma_get_gnvs_aslb(const void *gnvs) +{ + const global_nvs_t gnvs_ptr = gnvs; + return gnvs_ptr ? (uintptr_t)gnvs_ptr->aslb : NULL; +} + +void gma_set_gnvs_aslb(const void *gnvs, uintptr_t aslb) +{ + const global_nvs_t gnvs_ptr = gnvs; + if (gnvs_ptr) + gnvs_ptr->aslb = (u32)aslb; +} + static void power_well_enable(void) { gtt_write(HSW_PWR_WELL_CTL1, HSW_PWR_WELL_ENABLE); diff --git a/src/northbridge/intel/nehalem/gma.c b/src/northbridge/intel/nehalem/gma.c index fa84f78..2aeec70 100644 --- a/src/northbridge/intel/nehalem/gma.c +++ b/src/northbridge/intel/nehalem/gma.c @@ -304,6 +304,19 @@ return 0; } +uintptr_t gma_get_gnvs_aslb(const void *gnvs) +{ + const global_nvs_t gnvs_ptr = gnvs; + return gnvs_ptr ? (uintptr_t)gnvs_ptr->aslb : NULL; +} + +void gma_set_gnvs_aslb(const void *gnvs, uintptr_t aslb) +{ + const global_nvs_t gnvs_ptr = gnvs; + if (gnvs_ptr) + gnvs_ptr->aslb = (u32)aslb; +} + static void gma_pm_init_pre_vbios(struct device *dev) { u32 reg32; diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 9611e64..0f91be0 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -311,6 +311,19 @@ return 0; } +uintptr_t gma_get_gnvs_aslb(const void *gnvs) +{ + const global_nvs_t gnvs_ptr = gnvs; + return gnvs_ptr ? (uintptr_t)gnvs_ptr->aslb : NULL; +} + +void gma_set_gnvs_aslb(const void *gnvs, uintptr_t aslb) +{ + const global_nvs_t gnvs_ptr = gnvs; + if (gnvs_ptr) + gnvs_ptr->aslb = (u32)aslb; +} + static void gma_pm_init_pre_vbios(struct device *dev) { u32 reg32; -- To view, visit https://review.coreboot.org/20435 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If30c6b2270069783b0892774802f47406404da5f Gerrit-Change-Number: 20435 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: soc/intel/quark/spi.c: Explain a read in order to flush buffers
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20411 ) Change subject: soc/intel/quark/spi.c: Explain a read in order to flush buffers ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56461/ : SUCCESS -- To view, visit https://review.coreboot.org/20411 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a364539c37005cfd637b75c8cc23b84e274294d Gerrit-Change-Number: 20411 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 13:19:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/quark/spi.c: Explain a read in order to flush buffers
by build bot (Jenkins) (Code Review) 30 Jun '17

30 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20411 ) Change subject: soc/intel/quark/spi.c: Explain a read in order to flush buffers ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56460/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12048/ : SUCCESS -- To view, visit https://review.coreboot.org/20411 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a364539c37005cfd637b75c8cc23b84e274294d Gerrit-Change-Number: 20411 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 30 Jun 2017 12:26:51 +0000 Gerrit-HasComments: No

1 0

← Newer
1
2
3
4
5
6
7
8
...
227
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017